truenas-truecloud-patch

Found on real hardware: a 256-snapshot backup of /mnt/Tap swept 253 and left 3 with
'dataset is busy'.

ZFS AUTOMOUNTS <dataset>/.zfs/snapshot/<snap> when it is read, and keeps it mounted
for zfs_expire_snapshot seconds (300 default) after the last access. teardown()
unmounts OUR bind mounts but not the automount underneath, so zfs destroy refuses for
exactly the datasets restic read most recently. cleanup_task() then removed the
sidecar anyway -- destroying the only record those snapshots existed. Nothing would
ever have reclaimed them.

- release_snapdirs() unmounts ZFS's own automounts (deepest first) before deleting.
- delete_snapshot_tree() retries the transient busy and RETURNS what it could not
  delete, instead of swallowing it.
- The sidecar is removed only on a confirmed-clean sweep -- including on the
  staging-failure path, which used to remove it before the caller swept. A sidecar
  left behind when the tree is gone costs one no-op delete; a sidecar removed while
  the tree exists is unrecoverable.

2026-07-13 19:18:22 +00:00

test_alert_source.py

v0.5.1: the update alert could have broken middlewared at startup

2026-07-13 16:52:23 +00:00

test_apply_blocks.py

Never touch CloudSync tasks; restore the logger the async cleanup path dropped

2026-07-13 18:30:35 +00:00

test_compat.py

compat: check the middlewared METHODS we call, not just the symbols we wrap

2026-07-13 18:25:14 +00:00

test_create_task.py

v0.3.3: keep the restic repo password out of argv and shell history