The test suite is not bloated -- 3,701 lines of test code against 3,760 lines of
product code, one duplicate pair in 356 tests, 8% single-assertion tests. The waste was
not volume, it was four tests that looked like coverage and provided none:
- test_parents_are_mounted_before_children: the fixture was already in depth order, so
the sort it exists for was never exercised. Deleting `mounts.sort(key=_depth)` passed
the whole suite. It now uses datasets whose NAME order differs from their MOUNTPOINT
depth, which is the only case the sort is for.
- test_it_NEVER_touches_the_current_run: the "current" snapshot was a minute old, so the
age floor excluded it regardless and the same-snapname guard never ran. That guard
only matters for a run that OUTLIVES the floor -- which a first full upload easily
does, and where collecting it would yank the snapshot out from under a backup that is
still reading from it. Now tested with a 12-hour-old current run.
- the fingerprint/unknown test put the unreadable file in `providers`, which is not
broken -- so fingerprint() skipped the whole module via is_broken() and the filter
under test never executed. The blip has to land in the module that IS broken.
- test_the_real_truenas_versions was a byte-identical copy of
test_async_middleware_is_detected under a name promising more. Replaced with the fact
actually worth pinning: the flavour probe must read STOCK source, because apply.sh
re-runs on an already-patched overlay and our own SNAPSHOT_SYNC block is a plain
`def create_snapshot` -- reading it would report a 25.10 box as synchronous and inject
the wrong wrapper.
All four now fail when the code they name is broken.
flan
df412eeff7