Dermot Duffy
ea251ca988
Closes #2531. ## Summary The full `nunjucks` templating engine (~226KB) plus `ha-nunjucks` (~46KB) — roughly **272KB, ~13% of the eager entry chunk** — was statically imported and downloaded by every card on initial load, even though templates only apply when a config value contains a `{{ … }}` / `{% … %}` delimiter. Most cards use no templates and never need the engine. This defers the engine behind a dynamic `import('ha-nunjucks/dist')` so it ships in a separate, on-demand chunk instead of the eager `card-*.js`. ## Approach The render path (`TemplateRenderer.renderRecursively`) is **kept synchronous** — it is called from many synchronous hot paths (condition/trigger evaluators, picture-elements rendering, actions, folder matchers), and making it async would be a large, high-risk refactor of the evaluation core. Instead: - **New `src/card-controller/templates/engine.ts`** — a module-level singleton lazy loader (`loadTemplateEngine()` / `getTemplateEngine()`) shared across all `TemplateRenderer` instances, plus a `containsTemplate()` delimiter helper. - **Delimiter gating** — strings without a delimiter never touch the engine (the overwhelming majority of renders). - **Pre-warm at config time** — because every template string originates in the config, a new mandatory `TEMPLATE_ENGINE` initialization aspect loads the engine before first render whenever the config contains a delimiter. This **guarantees no raw `{{ … }}` flash**: content/condition rendering is blocked until the engine is present for template-using cards. Cards without templates never load it. ## Result - nunjucks + ha-nunjucks move out of the eager chunk into a separate chunk fetched only when a card actually uses templates. - No change to the synchronous public render API; condition/trigger evaluation core untouched. ## Tests - New `engine.ts` loader coverage (concurrent load, cached reuse, not-loaded fallback). - The 11 existing test files that render real (delimiter-bearing) templates declare their dependency explicitly via `beforeAll(loadTemplateEngine)` — no global/implicit setup hook. - Full suite green (4764 tests), lint and ts-prune clean, per-file 100% coverage maintained for the affected directories. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016ykWemdkZrgywvC71pHc6c --- _Generated by [Claude Code](https://claude.ai/code/session_016ykWemdkZrgywvC71pHc6c)_
63 lines
3.8 KiB
TypeScript
63 lines
3.8 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
|
|
import { ConditionStateManager } from '../../../src/condition-trigger/conditions/state-manager';
|
|
import { createTriggerEvaluator } from '../../../src/condition-trigger/triggers/factory';
|
|
import { CallTrigger } from '../../../src/condition-trigger/triggers/triggers/call';
|
|
import { CameraTrigger } from '../../../src/condition-trigger/triggers/triggers/camera';
|
|
import { ConfigTrigger } from '../../../src/condition-trigger/triggers/triggers/config';
|
|
import { DisplayModeTrigger } from '../../../src/condition-trigger/triggers/triggers/display-mode';
|
|
import { EventTrigger } from '../../../src/condition-trigger/triggers/triggers/event';
|
|
import { ExpandTrigger } from '../../../src/condition-trigger/triggers/triggers/expand';
|
|
import { FullscreenTrigger } from '../../../src/condition-trigger/triggers/triggers/fullscreen';
|
|
import { InitializedTrigger } from '../../../src/condition-trigger/triggers/triggers/initialized';
|
|
import { InteractionTrigger } from '../../../src/condition-trigger/triggers/triggers/interaction';
|
|
import { KeyTrigger } from '../../../src/condition-trigger/triggers/triggers/key';
|
|
import { MediaLoadedTrigger } from '../../../src/condition-trigger/triggers/triggers/media-loaded';
|
|
import { MicrophoneTrigger } from '../../../src/condition-trigger/triggers/triggers/microphone';
|
|
import { NumericStateTrigger } from '../../../src/condition-trigger/triggers/triggers/numeric-state';
|
|
import { ScreenTrigger } from '../../../src/condition-trigger/triggers/triggers/screen';
|
|
import { StateTrigger } from '../../../src/condition-trigger/triggers/triggers/state';
|
|
import { TemplateTrigger } from '../../../src/condition-trigger/triggers/triggers/template';
|
|
import { TriggeredTrigger } from '../../../src/condition-trigger/triggers/triggers/triggered';
|
|
import type {
|
|
TriggerEvaluator,
|
|
TriggerEvaluatorContext,
|
|
} from '../../../src/condition-trigger/triggers/triggers/types';
|
|
import { ViewTrigger } from '../../../src/condition-trigger/triggers/triggers/view';
|
|
import type { Trigger } from '../../../src/config/schema/condition-trigger/triggers/types';
|
|
import { createHASSManager, createMockTemplateRenderer } from '../../test-utils';
|
|
|
|
type TriggerEvaluatorConstructor = new (...args: never[]) => TriggerEvaluator;
|
|
|
|
// @vitest-environment jsdom
|
|
describe('createTriggerEvaluator', () => {
|
|
const context = (): TriggerEvaluatorContext => ({
|
|
stateManager: new ConditionStateManager(),
|
|
templateRenderer: createMockTemplateRenderer(),
|
|
hassManager: createHASSManager(),
|
|
});
|
|
|
|
it.each<[Trigger, TriggerEvaluatorConstructor]>([
|
|
[{ trigger: 'event', event_type: 'zha_event' }, EventTrigger],
|
|
[{ trigger: 'state', entity_id: 'binary_sensor.x' }, StateTrigger],
|
|
[{ trigger: 'numeric_state', entity_id: 'sensor.x', above: 5 }, NumericStateTrigger],
|
|
[{ trigger: 'template', value_template: '{{ true }}' }, TemplateTrigger],
|
|
[{ trigger: 'call', call: true }, CallTrigger],
|
|
[{ trigger: 'camera', cameras: ['front'] }, CameraTrigger],
|
|
[{ trigger: 'config' }, ConfigTrigger],
|
|
[{ trigger: 'display_mode', display_mode: 'single' }, DisplayModeTrigger],
|
|
[{ trigger: 'expand', expand: true }, ExpandTrigger],
|
|
[{ trigger: 'fullscreen', fullscreen: true }, FullscreenTrigger],
|
|
[{ trigger: 'interaction', interaction: true }, InteractionTrigger],
|
|
[{ trigger: 'media_loaded', media_loaded: true }, MediaLoadedTrigger],
|
|
[{ trigger: 'microphone', muted: true }, MicrophoneTrigger],
|
|
[{ trigger: 'triggered' }, TriggeredTrigger],
|
|
[{ trigger: 'view', views: ['live'] }, ViewTrigger],
|
|
[{ trigger: 'initialized' }, InitializedTrigger],
|
|
[{ trigger: 'key', key: 'a' }, KeyTrigger],
|
|
[{ trigger: 'screen' }, ScreenTrigger],
|
|
])('should create the dedicated evaluator for a %o trigger', (trigger, expected) => {
|
|
expect(createTriggerEvaluator(trigger, context())).toBeInstanceOf(expected);
|
|
});
|
|
});
|