From e8cb390fe43f79ee8c7f3dc02177623c7a19669c Mon Sep 17 00:00:00 2001 From: Holden Date: Tue, 16 Jun 2026 18:04:38 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20address=202=20quality=20review=20finding?= =?UTF-8?q?s=20=E2=80=94=20begin=5Fbatch=20dirty=20guard,=20LIMIT<=3D0=20w?= =?UTF-8?q?arning?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- winnow/jobs.py | 4 ++-- winnow/upload_tracker.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/winnow/jobs.py b/winnow/jobs.py index 6857233..941551e 100644 --- a/winnow/jobs.py +++ b/winnow/jobs.py @@ -71,8 +71,8 @@ def _resolve_strategy(strategy: str, has_embedding: bool) -> tuple[int | str, st custom_limit = _getenv_optional_int("LIMIT") if custom_limit is not None and custom_limit > 0: return custom_limit, "smart" - if custom_limit == 0: - logger.warning("LIMIT=0 is invalid — ignoring and using auto strategy") + if custom_limit is not None and custom_limit <= 0: + logger.warning("LIMIT=%s is invalid — ignoring and using auto strategy", custom_limit) strategy_map = { "adaptive": ("auto", "smart"), diff --git a/winnow/upload_tracker.py b/winnow/upload_tracker.py index ec2055d..6089938 100644 --- a/winnow/upload_tracker.py +++ b/winnow/upload_tracker.py @@ -105,7 +105,7 @@ def begin_batch(filename: str) -> None: """ path = _tracker_path(filename) key = str(path) - if key in _deferred and key in _cache: + if key in _deferred and key in _dirty: try: _write_to_disk(path, _cache[key]) except Exception: