fix: correct path traversal docstring, total_raw inflation, and config re-stat (v0.5.8)

- executor.py: fix _safe_person_dir docstring — realpath+startswith is the
  load-bearing traversal guard; islink is a supplementary early-exit for the
  symlink sub-case only. The previous comment "checking after realpath would be
  too late" implied islink was the primary guard, which is backwards.

- immich_api.py: move total_raw accumulation to after the dead-end-page break
  so all-garbage pages don't inflate the count and produce misleading
  "N total, 0 recent" output. Mixed pages (some valid, some non-dict) still
  count page_count so transient schema issues don't shrink MIN_FACE_COUNT below
  threshold. Add warning when a RequestException interrupts pagination mid-way
  so operators know total_raw is a lower bound.

- config.py: eliminate residual TOCTOU — change `if config_file.exists():` to
  `if _data_cfg_exists or config_file.exists():` so _data_cfg is never
  stat'd twice (the v0.5.7 fix cached the first check but not the second).

This commit is contained in:

flan

2026-06-15 00:41:00 +00:00

parent 9685c310af

commit 1556d90bcc

6 changed files with 39 additions and 12 deletions

									
										pyproject.toml
									
		+1
		-1
	
												View File
												
				@@ -1,6 +1,6 @@

				[project]

				name = "winnow"

				version = "0.5.7"

				version = "0.5.8"

				description = "Selects diverse, high-quality photos from Immich as training data for Frigate face recognition."

				license = "AGPL-3.0-or-later"

				requires-python = ">=3.13"