Fix two findings from adversarial IX-perspective audit
- create_task.py: add MITM risk warning to --insecure flag help text; common home-user pattern (self-signed cert) exposes API key in transit - install.sh: replace bare systemctl restart with explicit failure check that prints a recovery hint when middlewared fails to start post-install
This commit is contained in:
+9
-1
@@ -106,7 +106,15 @@ fi
|
||||
# ── Restart middlewared ───────────────────────────────────────────────────────
|
||||
|
||||
echo "Restarting middlewared so the backend patch takes effect ..."
|
||||
systemctl restart middlewared
|
||||
if ! systemctl restart middlewared; then
|
||||
echo "" >&2
|
||||
echo "ERROR: middlewared failed to restart. The patch files are installed but" >&2
|
||||
echo "the hook is not yet active. Check the system log for the root cause:" >&2
|
||||
echo " journalctl -u middlewared -n 50" >&2
|
||||
echo "If the problem is unrelated to this patch, recover with:" >&2
|
||||
echo " bash $PATCH_DIR/recover.sh" >&2
|
||||
exit 1
|
||||
fi
|
||||
echo "Done."
|
||||
echo ""
|
||||
echo "Refresh your browser to pick up the UI change."
|
||||
|
||||
@@ -195,7 +195,9 @@ def main():
|
||||
p.add_argument("--api-key", default=None, metavar="KEY",
|
||||
help="TrueNAS API key — System → API Keys (required except for verify)")
|
||||
p.add_argument("--insecure", action="store_true",
|
||||
help="Skip TLS certificate verification (self-signed certs)")
|
||||
help="Skip TLS certificate verification (self-signed certs). "
|
||||
"WARNING: exposes your API key to network interception. "
|
||||
"Prefer adding your cert to the trust store instead.")
|
||||
|
||||
sub = p.add_subparsers(dest="cmd", required=True)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user