v0.3.3: keep the restic repo password out of argv and shell history

Security
--------
create_task.py shelled out to `midclt call cloud_backup.create '<json>'`, and that
JSON carries the restic repository password -- so it sat in the subprocess's argv,
which is world-readable via ps, for the duration of the call. That password is the
encryption key for the entire cloud backup repository.

It now talks to the middleware through truenas_api_client, the library that backs
midclt itself, so the password never leaves this process's memory. Verified on a
live box: list-tasks and list-credentials work through the new transport.

--password is also no longer required, because passing a secret as a CLI argument
writes it to shell history permanently. --password-stdin reads it from stdin, and
with neither flag the tool prompts via getpass. --password still works but warns.

Fixed
-----
uninstall.sh could leave every patch installed. It reverted by unmounting the
overlay -- but apply.sh only mounts one when the target directory is read-only. On
a writable /usr it patches the real files in place, and uninstall would remove the
boot hook, report success, and leave the patch applied. It now strips the appended
blocks from the middleware files explicitly. This also covers the case where the
overlay unmount fails.

create_task.py's __version__ had been stuck at 0.2.0 through three releases. The
version-drift check added in v0.3.1 only looked at VERSION= in shell scripts, so it
missed the one file that actually shows a version to users (--version). The check
now covers __version__ too -- and caught this immediately.

118 tests, ruff and shellcheck clean.

This commit is contained in:

flan

2026-07-13 15:43:24 +00:00

parent 8aa9038226

commit 60b3ac4557

8 changed files with 277 additions and 31 deletions

									
										patch/apply.sh
									
		+1
		-1
	
												View File
												
				@@ -32,7 +32,7 @@

				# Derive PATCH_DIR from this script's location (parent of the patch/ directory).

				PATCH_DIR="$(cd "$(dirname "$0")/.." && pwd)"

				LOG="$PATCH_DIR/apply.log"

				VERSION="0.3.2"

				VERSION="0.3.3"

				# Rotate log at 512 KB to avoid unbounded growth on a system volume.

				# Keep two prior generations (.1 and .2) so the last three boots are always available.