Apply the community-rating floor to rated titles as well
The audience tag admitted any title whose official rating sat at or below the ceiling, with no quality condition at all. The community-rating floor was only consulted when a title had no usable rating. On a real library that let 21 poorly reviewed but mildly rated titles through - Norbit, Cats, Super Mario Bros., Rocky V, Cool as Ice among them - none of which belong in a library whose entire purpose is to be smaller than the one it was carved out of. A ceiling answers whether a title is suitable; it says nothing about whether it is worth offering. MinCommunityRating now applies to rated titles, alongside the existing MinCommunityRatingWhenUnrated for titles with no rating to judge. The two are separate settings because an unrated title carries more uncertainty and may warrant a higher bar. A rated title with no community rating at all now fails, which is deliberate: with neither a score to check nor a reputation to weigh, there is nothing to decide on. Verified against the live library: a full pass over 2778 titles settles at 561 tagged, and the 21 are not re-added.
This commit is contained in:
@@ -84,6 +84,17 @@
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div class="inputContainer">
|
||||
<label class="inputLabel inputLabelUnfocused" for="MinCommunityRating">Community rating floor for rated items</label>
|
||||
<input is="emby-input" type="number" id="MinCommunityRating" min="0" max="10" step="0.1" />
|
||||
<div class="fieldDescription">
|
||||
A rated item must clear this as well as the ceiling. The point of the tag
|
||||
is to make an overwhelming library smaller, and a poorly reviewed film
|
||||
that happens to be rated PG adds noise rather than removing it. An item
|
||||
with no community rating at all fails this check.
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div class="inputContainer">
|
||||
<label class="inputLabel inputLabelUnfocused" for="MinCommunityRatingWhenUnrated">Community rating floor for unrated items</label>
|
||||
<input is="emby-input" type="number" id="MinCommunityRatingWhenUnrated" min="0" max="10" step="0.1" />
|
||||
@@ -129,6 +140,7 @@
|
||||
document.querySelector('#ApplyTags').checked = config.ApplyTags;
|
||||
document.querySelector('#TagName').value = config.TagName;
|
||||
document.querySelector('#MaxRatingScore').value = config.MaxRatingScore;
|
||||
document.querySelector('#MinCommunityRating').value = config.MinCommunityRating;
|
||||
document.querySelector('#MinCommunityRatingWhenUnrated').value = config.MinCommunityRatingWhenUnrated;
|
||||
document.querySelector('#RespectManualUntag').checked = config.RespectManualUntag;
|
||||
Dashboard.hideLoadingMsg();
|
||||
@@ -145,6 +157,7 @@
|
||||
config.ApplyTags = document.querySelector('#ApplyTags').checked;
|
||||
config.TagName = document.querySelector('#TagName').value;
|
||||
config.MaxRatingScore = parseInt(document.querySelector('#MaxRatingScore').value, 10);
|
||||
config.MinCommunityRating = parseFloat(document.querySelector('#MinCommunityRating').value);
|
||||
config.MinCommunityRatingWhenUnrated = parseFloat(document.querySelector('#MinCommunityRatingWhenUnrated').value);
|
||||
config.RespectManualUntag = document.querySelector('#RespectManualUntag').checked;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user