flan/ha-freshharvest
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Verify basket, subscribe and vacation-hold round trips against a live account
Validate / hassfest (push) Failing after 5s
Details
Validate / pytest (push) Failing after 7s
Details
Validate / HACS (push) Failing after 16s
Details

Browse Source 
Three fixes the round trips found:

The produce-box select reported the SUBSCRIPTION rather than the delivery. A
one-off switch changes the delivery while the standing order keeps naming the
old box, so during the exact week someone had changed it the entity showed the
wrong box. It now reads the order.

parse_vacation_holds looked for ISO dates. The page writes 'Tuesday, Dec 1 -
Monday, Dec 7', so it reported no holds on an account that had one — which is
indistinguishable from having none. Its test asserted the same wrong format,
so the test passed while the parser was blind.

Adds hold removal (POST /s/submit/pause-range-remove), whose popup only exists
while a hold does.
This commit is contained in:
flan
2026-08-03 20:35:49 +00:00
parent e7427082e3
commit 6ec06ee31a
3 changed files with 74 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_actions.py
+18 -5
View File
@@ -73,12 +73,25 @@ def test_no_subscriptions_is_empty_not_an_error():
assert actions.parse_subscriptions("<html><body>nothing</body></html>") == []
def test_vacation_holds_need_two_dates():
html = "<div class='account-item-container'>2026-09-01 to 2026-09-14</div>"
def test_vacation_hold_uses_the_sites_own_date_format():
"""The page writes "Tuesday, Dec 1 - Monday, Dec 7", never ISO.
The first version of this test asserted ISO dates, so it passed against a
format the site does not produce while the parser reported zero holds on an
account that had one.
"""
html = (
"<div class='account'><div class='account-item'>Upcoming Pauses"
"<div class='account-item-container'>Tuesday, Dec 1 - Monday, Dec 7"
"<a>Remove</a></div></div></div>"
)
holds = actions.parse_vacation_holds(html)
assert len(holds) == 1 and holds[0].start == "2026-09-01"
assert holds[0].end == "2026-09-14"
assert actions.parse_vacation_holds("<div class='account-item-container'>none</div>") == []
assert len(holds) == 1
assert (holds[0].start, holds[0].end) == ("Dec 1", "Dec 7")
def test_no_holds_parses_empty():
assert actions.parse_vacation_holds("<div class='account'>none</div>") == []
def test_frequency_names_map_to_site_values():