Add control entities: box to-do list, skip switch, donate button, subscriptions

The to-do list exists so Home Assistant's own conversation agent can manage the order through HassListAddItem rather than through anything bespoke. Skip is a switch because skipped/not-skipped is state worth reading back; donate is a button because it cannot be undone. Un-skip raises rather than guessing at an endpoint that has never been observed. Fixes subscription parsing, which matched the heading row and so reported zero on an account that has one.
2026-08-03 20:13:32 +00:00
parent 213c16d98e
commit 551d3240a2
14 changed files with 592 additions and 14 deletions
@@ -0,0 +1,87 @@
+"""Tests for the subscription and vacation-hold parsers.
+
+Written after a real bug: the first version matched `.account-item-multi-fields`,
+which is the HEADING row, so an account with a live subscription reported zero.
+A count of nothing looks exactly like an account with nothing.
+"""
+
+from __future__ import annotations
+
+import importlib
+import sys
+import types
+from pathlib import Path
+
+COMPONENT = Path(__file__).parent.parent / "custom_components"
+
+
+def _load():
+    if "aiohttp" not in sys.modules:
+        stub = types.ModuleType("aiohttp")
+        stub.ClientSession = object
+        stub.ClientError = Exception
+        sys.modules["aiohttp"] = stub
+    sys.path.insert(0, str(COMPONENT))
+    pkg = types.ModuleType("fh_pkg")
+    pkg.__path__ = [str(COMPONENT / "freshharvest")]
+    sys.modules["fh_pkg"] = pkg
+    return importlib.import_module("fh_pkg.actions")
+
+
+actions = _load()
+
+SUBS_HTML = """
+<div class='account'>
+  <div class='account-item'>
+    <div class='account-item-multi-fields'>
+      <div class='account-item-heading account-item-history-qty'>Qty</div>
+      <div class='account-item-heading account-item-description'>Item</div>
+      <div class='account-item-heading account-item-history'>Arriving</div>
+      <div class='account-item-heading account-item-history-vendor'>Partner</div>
+      <div class='account-item-heading account-item-history center'>Frequency</div>
+    </div>
+  </div>
+  <div class='account-item'>
+    <div class='account-item-container'>
+      <div class='account-item-text account-item-history-qty'><div class='center'>2</div></div>
+      <div class='account-item-text account-item-description'>Georgia Grown Small Box</div>
+      <div class='account-item-text account-item-history'>tomorrow</div>
+      <div class='account-item-text account-item-history-vendor'>Various Partners</div>
+      <div class='account-item-text account-item-history center'>Weekly</div>
+      <div class='account-item-action account-item-history-action right'>Change Basket</div>
+    </div>
+  </div>
+</div>
+"""
+
+
+def test_heading_row_is_not_a_subscription():
+    """The regression: the header row must not be counted, and must not hide the real one."""
+    subs = actions.parse_subscriptions(SUBS_HTML)
+    assert len(subs) == 1
+    assert subs[0].name == "Georgia Grown Small Box"
+
+
+def test_subscription_fields():
+    sub = actions.parse_subscriptions(SUBS_HTML)[0]
+    assert (sub.quantity, sub.frequency) == (2, "Weekly")
+    assert sub.partner == "Various Partners"
+    assert sub.arriving == "tomorrow"
+
+
+def test_no_subscriptions_is_empty_not_an_error():
+    assert actions.parse_subscriptions("<html><body>nothing</body></html>") == []
+
+
+def test_vacation_holds_need_two_dates():
+    html = "<div class='account-item-container'>2026-09-01 to 2026-09-14</div>"
+    holds = actions.parse_vacation_holds(html)
+    assert len(holds) == 1 and holds[0].start == "2026-09-01"
+    assert holds[0].end == "2026-09-14"
+    assert actions.parse_vacation_holds("<div class='account-item-container'>none</div>") == []
+
+
+def test_frequency_names_map_to_site_values():
+    assert actions.FREQUENCIES["weekly"] == "1"
+    # id='FrequencyID' but the POST field is popup-toggle; posting the id does nothing.
+    assert actions.FREQUENCY_FIELD == "popup-toggle"
@@ -13,7 +13,12 @@ from pathlib import Path
 import pytest

 COMPONENT = Path(__file__).parent.parent / "custom_components" / "freshharvest"
-PLATFORMS = {"sensor": "sensor.py", "binary_sensor": "binary_sensor.py"}
+PLATFORMS = {
+    "sensor": "sensor.py",
+    "binary_sensor": "binary_sensor.py",
+    "switch": "switch.py",
+    "button": "button.py",
+}


 def declared_keys(filename: str) -> set[str]:
@@ -29,6 +34,22 @@ def declared_keys(filename: str) -> set[str]:
    }


+def attr_keys(filename: str) -> set[str]:
+    """Collect `_attr_translation_key = "..."` assignments (entities without a
+    description object declare their name this way)."""
+    tree = ast.parse((COMPONENT / filename).read_text(encoding="utf-8"))
+    return {
+        node.value.value
+        for node in ast.walk(tree)
+        if isinstance(node, ast.Assign)
+        and any(
+            getattr(t, "id", getattr(t, "attr", None)) == "_attr_translation_key"
+            for t in node.targets
+        )
+        and isinstance(node.value, ast.Constant)
+    }
+
+
@pytest.fixture(name="strings")
 def strings_fixture() -> dict:
    return json.loads((COMPONENT / "strings.json").read_text(encoding="utf-8"))
@@ -64,3 +85,8 @@ def test_manifest_is_well_formed():
        assert manifest[key].startswith("https://github.com/"), (
            f"{key} must be a public URL, got {manifest[key]}"
        )
+
+
+def test_todo_entity_is_named(strings):
+    """todo.py declares its name via _attr_translation_key, not a description."""
+    assert attr_keys("todo.py") == set(strings["entity"]["todo"])