Closes #2531. ## Summary The full `nunjucks` templating engine (~226KB) plus `ha-nunjucks` (~46KB) — roughly **272KB, ~13% of the eager entry chunk** — was statically imported and downloaded by every card on initial load, even though templates only apply when a config value contains a `{{ … }}` / `{% … %}` delimiter. Most cards use no templates and never need the engine. This defers the engine behind a dynamic `import('ha-nunjucks/dist')` so it ships in a separate, on-demand chunk instead of the eager `card-*.js`. ## Approach The render path (`TemplateRenderer.renderRecursively`) is **kept synchronous** — it is called from many synchronous hot paths (condition/trigger evaluators, picture-elements rendering, actions, folder matchers), and making it async would be a large, high-risk refactor of the evaluation core. Instead: - **New `src/card-controller/templates/engine.ts`** — a module-level singleton lazy loader (`loadTemplateEngine()` / `getTemplateEngine()`) shared across all `TemplateRenderer` instances, plus a `containsTemplate()` delimiter helper. - **Delimiter gating** — strings without a delimiter never touch the engine (the overwhelming majority of renders). - **Pre-warm at config time** — because every template string originates in the config, a new mandatory `TEMPLATE_ENGINE` initialization aspect loads the engine before first render whenever the config contains a delimiter. This **guarantees no raw `{{ … }}` flash**: content/condition rendering is blocked until the engine is present for template-using cards. Cards without templates never load it. ## Result - nunjucks + ha-nunjucks move out of the eager chunk into a separate chunk fetched only when a card actually uses templates. - No change to the synchronous public render API; condition/trigger evaluation core untouched. ## Tests - New `engine.ts` loader coverage (concurrent load, cached reuse, not-loaded fallback). - The 11 existing test files that render real (delimiter-bearing) templates declare their dependency explicitly via `beforeAll(loadTemplateEngine)` — no global/implicit setup hook. - Full suite green (4764 tests), lint and ts-prune clean, per-file 100% coverage maintained for the affected directories. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016ykWemdkZrgywvC71pHc6c --- _Generated by [Claude Code](https://claude.ai/code/session_016ykWemdkZrgywvC71pHc6c)_
488 lines
16 KiB
TypeScript
488 lines
16 KiB
TypeScript
import {
|
|
html,
|
|
LitElement,
|
|
unsafeCSS,
|
|
type CSSResultGroup,
|
|
type PropertyValues,
|
|
type TemplateResult,
|
|
} from 'lit';
|
|
import { customElement, property, state } from 'lit/decorators.js';
|
|
import { isEqual } from 'lodash-es';
|
|
|
|
import type { IssueTriggerEventData } from '../card-controller/issues/types.js';
|
|
import type { TemplateRenderer } from '../card-controller/templates/index.js';
|
|
import { getTemplateRendererViaEvent } from '../card-controller/templates/renderer-via-event.js';
|
|
import { ConditionsManager } from '../condition-trigger/conditions/conditions-manager.js';
|
|
import { getConditionStateManagerViaEvent } from '../condition-trigger/conditions/state-manager-via-event.js';
|
|
import type { ConditionStateManager } from '../condition-trigger/conditions/state-manager.js';
|
|
import type {
|
|
StatusBarIcon,
|
|
StatusBarImage,
|
|
StatusBarItem,
|
|
StatusBarString,
|
|
} from '../config/schema/actions/types.js';
|
|
import type { MenuIcon } from '../config/schema/elements/custom/menu/icon.js';
|
|
import type { MenuStateIcon } from '../config/schema/elements/custom/menu/state-icon.js';
|
|
import type { MenuSubmenuSelect } from '../config/schema/elements/custom/menu/submenu-select.js';
|
|
import type { MenuSubmenu } from '../config/schema/elements/custom/menu/submenu.js';
|
|
import type { MenuItem } from '../config/schema/elements/custom/menu/types.js';
|
|
import type {
|
|
AdvancedCameraCardConditional,
|
|
PictureElements,
|
|
} from '../config/schema/elements/types.js';
|
|
import type { HomeAssistant } from '../ha/types.js';
|
|
import { localize } from '../localize/localize.js';
|
|
import elementsStyle from '../scss/elements.scss';
|
|
import { AdvancedCameraCardError } from '../types.js';
|
|
import { errorToConsole } from '../utils/basic.js';
|
|
import { fireAdvancedCameraCardEvent } from '../utils/fire-advanced-camera-card-event.js';
|
|
|
|
class ElementsCreationError extends AdvancedCameraCardError {
|
|
constructor(context?: unknown) {
|
|
super(localize('error.could_not_create_elements'), context);
|
|
}
|
|
}
|
|
|
|
/* A note on picture element rendering:
|
|
*
|
|
* To avoid needing to deal with the rendering of all the picture elements
|
|
* ourselves, instead the card relies on a stock conditional element (with no
|
|
* conditions) to render elements (this._root). This has a few advantages:
|
|
*
|
|
* - Does not depend on (much of!) an internal API -- conditional picture
|
|
* elements are unlikely to go away or change.
|
|
* - Forces usage of elements that HA understands. If the rendering is done
|
|
* directly, it is (ask me how I know!) very tempting to render things in such
|
|
* a way that a nested conditional element would not be able to render, i.e.
|
|
* the custom rendering logic would only apply at the first level.
|
|
*/
|
|
|
|
/* A note on custom elements:
|
|
*
|
|
* The native HA support for custom elements is used for the menu-icon and
|
|
* menu-state-icon elements. This ensures multi-nested conditionals will work
|
|
* correctly. These custom elements 'render' by firing events that are caught by
|
|
* the card to call for inclusion/exclusion of the menu icon in question.
|
|
*
|
|
* One major complexity here is that the top <advanced-camera-card-elements> element
|
|
* will not necessarily know when a menu icon is no longer rendered because of a
|
|
* conditional that no-longer evaluates to true. As such, it cannot know when to
|
|
* signal for the menu icon removal. Furthermore, the menu icon element itself
|
|
* will only know it's been removed _after_ it's been disconnected from the DOM,
|
|
* so normal event propagation at that point will not work. Instead, we must
|
|
* catch the menu icon _addition_ and register the eventhandler for the removal
|
|
* directly on the child (which will have no parent at time of calling). That
|
|
* then triggers <advanced-camera-card-elements> to re-dispatch a removal event for
|
|
* upper layers to handle correctly.
|
|
*/
|
|
|
|
interface HuiConditionalElement extends HTMLElement {
|
|
hass: HomeAssistant;
|
|
setConfig(config: unknown): void;
|
|
}
|
|
|
|
// A small wrapper around a HA conditional element used to render a set of
|
|
// picture elements.
|
|
@customElement('advanced-camera-card-elements-core')
|
|
export class AdvancedCameraCardElementsCore extends LitElement {
|
|
@property({ attribute: false })
|
|
public hass?: HomeAssistant;
|
|
|
|
@property({ attribute: false })
|
|
public elements?: PictureElements;
|
|
|
|
@property({ attribute: false })
|
|
public conditionStateManager?: ConditionStateManager;
|
|
|
|
@property({ attribute: false })
|
|
public templateRenderer?: TemplateRenderer;
|
|
|
|
@state()
|
|
private _root: HuiConditionalElement | null = null;
|
|
|
|
private _renderedElements?: PictureElements;
|
|
|
|
/**
|
|
* Create a transparent render root.
|
|
*/
|
|
createRenderRoot(): LitElement {
|
|
return this;
|
|
}
|
|
|
|
/**
|
|
* Create the root node for our picture elements.
|
|
* @returns The newly created root.
|
|
*/
|
|
private _createRoot(): HuiConditionalElement {
|
|
const elementConstructor = customElements.get('hui-conditional-element');
|
|
if (!elementConstructor || !this.hass) {
|
|
throw new ElementsCreationError(this._renderedElements);
|
|
}
|
|
|
|
const element = new elementConstructor() as HuiConditionalElement;
|
|
element.hass = this.hass;
|
|
const config = {
|
|
type: 'conditional',
|
|
conditions: [],
|
|
elements: this._renderedElements,
|
|
};
|
|
try {
|
|
element.setConfig(config);
|
|
} catch (e) {
|
|
errorToConsole(e, console.error);
|
|
throw new AdvancedCameraCardError(localize('error.invalid_elements_config'));
|
|
}
|
|
return element;
|
|
}
|
|
|
|
private _setNewRoot = (): void => {
|
|
if (!this.hass) {
|
|
return;
|
|
}
|
|
|
|
const elements = this.templateRenderer
|
|
? this.templateRenderer.renderRecursivelyAsType(this.hass, this.elements, {
|
|
conditionState: this.conditionStateManager?.getState(),
|
|
})
|
|
: this.elements;
|
|
|
|
// Condition state changes won't change the actual rendered config unless
|
|
// `elements` has a template, which is more likely does not. Avoid updating
|
|
// the root if nothing changes.
|
|
if (this._root && isEqual(this._renderedElements, elements)) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
this._renderedElements = elements;
|
|
this._root = this._createRoot();
|
|
} catch (e) {
|
|
errorToConsole(e);
|
|
fireAdvancedCameraCardEvent<IssueTriggerEventData>(this, 'issue:trigger', {
|
|
key: 'config_error',
|
|
error: new ElementsCreationError(elements),
|
|
});
|
|
}
|
|
};
|
|
|
|
connectedCallback(): void {
|
|
super.connectedCallback();
|
|
this.conditionStateManager?.addListener(this._setNewRoot);
|
|
}
|
|
|
|
disconnectedCallback(): void {
|
|
this.conditionStateManager?.removeListener(this._setNewRoot);
|
|
super.disconnectedCallback();
|
|
}
|
|
|
|
protected willUpdate(changedProps: PropertyValues): void {
|
|
if (changedProps.has('conditionStateManager') && this.conditionStateManager) {
|
|
changedProps.get('conditionStateManager')?.removeEventListener(this._setNewRoot);
|
|
this.conditionStateManager.addListener(this._setNewRoot);
|
|
}
|
|
|
|
// The root is only created once per elements configuration change, to
|
|
// avoid the elements being continually re-created & destroyed (for some
|
|
// elements, e.g. image, recreation causes a flicker).
|
|
if (
|
|
!this._root ||
|
|
changedProps.has('elements') ||
|
|
changedProps.has('conditionStateManager')
|
|
) {
|
|
this._setNewRoot();
|
|
}
|
|
}
|
|
|
|
protected render(): TemplateResult | void {
|
|
return html`${this._root || ''}`;
|
|
}
|
|
|
|
protected updated(): void {
|
|
if (this.hass && this._root) {
|
|
// Always update hass. It is used as a trigger to re-evaluate conditions
|
|
// down the chain, see the note on AdvancedCameraCardElementsConditional.
|
|
this._root.hass = this.hass;
|
|
}
|
|
}
|
|
}
|
|
|
|
@customElement('advanced-camera-card-elements')
|
|
export class AdvancedCameraCardElements extends LitElement {
|
|
@property({ attribute: false })
|
|
public hass?: HomeAssistant;
|
|
|
|
@property({ attribute: false })
|
|
public elements?: PictureElements;
|
|
|
|
@property({ attribute: false })
|
|
public conditionStateManager?: ConditionStateManager;
|
|
|
|
@property({ attribute: false })
|
|
public templateRenderer?: TemplateRenderer;
|
|
|
|
private _addHandler(
|
|
target: EventTarget,
|
|
eventName: string,
|
|
handler: (ev: Event) => void,
|
|
) {
|
|
// Ensure listener is only attached 1 time by removing it first.
|
|
target.removeEventListener(eventName, handler);
|
|
target.addEventListener(eventName, handler);
|
|
}
|
|
|
|
private _menuRemoveHandler = (ev: Event): void => {
|
|
// Re-dispatch event from this element (instead of the disconnected one, as
|
|
// there is no parent of the disconnected element).
|
|
fireAdvancedCameraCardEvent<MenuItem>(
|
|
this,
|
|
'menu:remove',
|
|
(ev as CustomEvent).detail,
|
|
);
|
|
};
|
|
|
|
private _statusBarRemoveHandler = (ev: Event): void => {
|
|
// Re-dispatch event from this element (instead of the disconnected one, as
|
|
// there is no parent of the disconnected element).
|
|
fireAdvancedCameraCardEvent<StatusBarItem>(
|
|
this,
|
|
'status-bar:remove',
|
|
(ev as CustomEvent).detail,
|
|
);
|
|
};
|
|
|
|
private _menuAddHandler = (ev: Event): void => {
|
|
ev = ev as CustomEvent<MenuItem>;
|
|
const path = ev.composedPath();
|
|
if (!path.length) {
|
|
return;
|
|
}
|
|
this._addHandler(
|
|
path[0],
|
|
'advanced-camera-card:menu:remove',
|
|
this._menuRemoveHandler,
|
|
);
|
|
};
|
|
|
|
private _statusBarAddHandler = (ev: Event): void => {
|
|
ev = ev as CustomEvent<MenuItem>;
|
|
const path = ev.composedPath();
|
|
if (!path.length) {
|
|
return;
|
|
}
|
|
this._addHandler(
|
|
path[0],
|
|
'advanced-camera-card:status-bar:remove',
|
|
this._statusBarRemoveHandler,
|
|
);
|
|
};
|
|
|
|
connectedCallback(): void {
|
|
super.connectedCallback();
|
|
|
|
// Catch icons being added to the menu or status-bar (so their removal can
|
|
// be subsequently handled).
|
|
this.addEventListener('advanced-camera-card:menu:add', this._menuAddHandler);
|
|
this.addEventListener(
|
|
'advanced-camera-card:status-bar:add',
|
|
this._statusBarAddHandler,
|
|
);
|
|
}
|
|
|
|
disconnectedCallback(): void {
|
|
this.removeEventListener('advanced-camera-card:menu:add', this._menuAddHandler);
|
|
this.addEventListener(
|
|
'advanced-camera-card:status-bar:add',
|
|
this._statusBarAddHandler,
|
|
);
|
|
super.disconnectedCallback();
|
|
}
|
|
|
|
protected render(): TemplateResult {
|
|
return html`<advanced-camera-card-elements-core
|
|
.conditionStateManager=${this.conditionStateManager}
|
|
.hass=${this.hass}
|
|
.elements=${this.elements}
|
|
.templateRenderer=${this.templateRenderer}
|
|
>
|
|
</advanced-camera-card-elements-core>`;
|
|
}
|
|
|
|
static get styles(): CSSResultGroup {
|
|
return unsafeCSS(elementsStyle);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* An element that can render others based on card state (e.g. only show
|
|
* overlays in particular views). This is the Advanced Camera Card equivalent to
|
|
* the HA conditional card.
|
|
*/
|
|
@customElement('advanced-camera-card-conditional')
|
|
export class AdvancedCameraCardElementsConditional extends LitElement {
|
|
private _config?: AdvancedCameraCardConditional;
|
|
private _conditionManager: ConditionsManager | null = null;
|
|
private _templateRenderer: TemplateRenderer | null = null;
|
|
|
|
// A note on hass as an update mechanism:
|
|
//
|
|
// Every set of hass is treated as a reason to re-evaluate. Given that this
|
|
// node may be buried down the DOM (as a descendent of non-Advanced Camera
|
|
// Card elements), the hass object is used as the (only) trigger for condition
|
|
// re-fetch even if hass itself has not changed.
|
|
@property({ attribute: false, hasChanged: () => true })
|
|
public hass?: HomeAssistant;
|
|
|
|
/**
|
|
* Set the card configuration.
|
|
* @param config The card configuration.
|
|
*/
|
|
public setConfig(config: AdvancedCameraCardConditional): void {
|
|
this._config = config;
|
|
this._createConditionManager();
|
|
}
|
|
|
|
/**
|
|
* Create a root into which to render. This card is "transparent".
|
|
* @returns
|
|
*/
|
|
createRenderRoot(): LitElement {
|
|
return this;
|
|
}
|
|
|
|
connectedCallback(): void {
|
|
super.connectedCallback();
|
|
|
|
// HA will automatically attach the 'element' class to picture elements. As
|
|
// this is a transparent 'conditional' element (just like the stock HA
|
|
// 'conditional' element), it should not have positioning.
|
|
this.className = '';
|
|
|
|
this._createConditionManager();
|
|
}
|
|
|
|
disconnectedCallback(): void {
|
|
this._conditionManager?.destroy();
|
|
super.disconnectedCallback();
|
|
}
|
|
|
|
private _createConditionManager(): void {
|
|
const conditionStateManager = getConditionStateManagerViaEvent(this);
|
|
const templateRenderer = getTemplateRendererViaEvent(this);
|
|
if (!this._config || !conditionStateManager || !templateRenderer) {
|
|
return;
|
|
}
|
|
this._templateRenderer = templateRenderer;
|
|
this._conditionManager?.destroy();
|
|
this._conditionManager = new ConditionsManager(
|
|
this._config.conditions,
|
|
templateRenderer,
|
|
conditionStateManager,
|
|
);
|
|
this._conditionManager.addListener(() => this.requestUpdate());
|
|
}
|
|
|
|
protected render(): TemplateResult | void {
|
|
if (this._conditionManager?.getEvaluation()?.result) {
|
|
return html` <advanced-camera-card-elements-core
|
|
.hass=${this.hass}
|
|
.elements=${this._config?.elements}
|
|
.templateRenderer=${this._templateRenderer}
|
|
>
|
|
</advanced-camera-card-elements-core>`;
|
|
}
|
|
}
|
|
}
|
|
|
|
// A base class for rendering menu icons / menu state icons.
|
|
export class AdvancedCameraCardElementsBaseItem<ConfigType> extends LitElement {
|
|
protected _eventCategory: string;
|
|
|
|
constructor(eventCategory: string) {
|
|
super();
|
|
this._eventCategory = eventCategory;
|
|
}
|
|
|
|
@state()
|
|
protected _config: ConfigType | null = null;
|
|
|
|
public setConfig(config: ConfigType): void {
|
|
this._config = config;
|
|
}
|
|
|
|
connectedCallback(): void {
|
|
super.connectedCallback();
|
|
if (this._config) {
|
|
fireAdvancedCameraCardEvent<ConfigType>(
|
|
this,
|
|
`${this._eventCategory}:add`,
|
|
this._config,
|
|
);
|
|
}
|
|
}
|
|
|
|
disconnectedCallback(): void {
|
|
if (this._config) {
|
|
fireAdvancedCameraCardEvent<ConfigType>(
|
|
this,
|
|
`${this._eventCategory}:remove`,
|
|
this._config,
|
|
);
|
|
}
|
|
super.disconnectedCallback();
|
|
}
|
|
}
|
|
|
|
export class AdvancedCameraCardElementsBaseMenuItem<
|
|
ConfigType,
|
|
> extends AdvancedCameraCardElementsBaseItem<ConfigType> {
|
|
constructor() {
|
|
super('menu');
|
|
}
|
|
}
|
|
|
|
@customElement('advanced-camera-card-menu-icon')
|
|
export class AdvancedCameraCardElementsMenuIcon extends AdvancedCameraCardElementsBaseMenuItem<MenuIcon> {}
|
|
|
|
@customElement('advanced-camera-card-menu-state-icon')
|
|
export class AdvancedCameraCardElementsMenuStateIcon extends AdvancedCameraCardElementsBaseMenuItem<MenuStateIcon> {}
|
|
|
|
@customElement('advanced-camera-card-menu-submenu')
|
|
export class AdvancedCameraCardElementsMenuSubmenu extends AdvancedCameraCardElementsBaseMenuItem<MenuSubmenu> {}
|
|
|
|
@customElement('advanced-camera-card-menu-submenu-select')
|
|
export class AdvancedCameraCardElementsMenuSubmenuSelect extends AdvancedCameraCardElementsBaseMenuItem<MenuSubmenuSelect> {}
|
|
|
|
export class AdvancedCameraCardElementsBaseStatusBarItem<
|
|
ConfigType,
|
|
> extends AdvancedCameraCardElementsBaseItem<ConfigType> {
|
|
constructor() {
|
|
super('status-bar');
|
|
}
|
|
}
|
|
|
|
@customElement('advanced-camera-card-status-bar-icon')
|
|
export class AdvancedCameraCardElementsStatusBarIcon extends AdvancedCameraCardElementsBaseStatusBarItem<StatusBarIcon> {}
|
|
|
|
@customElement('advanced-camera-card-status-bar-image')
|
|
export class AdvancedCameraCardElementsStatusBarImage extends AdvancedCameraCardElementsBaseStatusBarItem<StatusBarImage> {}
|
|
|
|
@customElement('advanced-camera-card-status-bar-string')
|
|
export class AdvancedCameraCardElementsStatusBarString extends AdvancedCameraCardElementsBaseStatusBarItem<StatusBarString> {}
|
|
|
|
declare global {
|
|
interface HTMLElementTagNameMap {
|
|
'advanced-camera-card-conditional': AdvancedCameraCardElementsConditional;
|
|
'advanced-camera-card-elements': AdvancedCameraCardElements;
|
|
'advanced-camera-card-elements-core': AdvancedCameraCardElementsCore;
|
|
|
|
'advanced-camera-card-menu-icon': AdvancedCameraCardElementsMenuIcon;
|
|
'advanced-camera-card-menu-state-icon': AdvancedCameraCardElementsMenuStateIcon;
|
|
'advanced-camera-card-menu-submenu': AdvancedCameraCardElementsMenuSubmenu;
|
|
'advanced-camera-card-menu-submenu-select': AdvancedCameraCardElementsMenuSubmenuSelect;
|
|
|
|
'advanced-camera-card-status-bar-icon': AdvancedCameraCardElementsStatusBarIcon;
|
|
'advanced-camera-card-status-bar-image': AdvancedCameraCardElementsStatusBarImage;
|
|
'advanced-camera-card-status-bar-string': AdvancedCameraCardElementsStatusBarString;
|
|
}
|
|
}
|