The card claimed a camera's ONVIF audio backchannel in two places that had nothing to do with a call: the capability probe at camera init (`µphone`), and a pre-armed `sendonly` audio transceiver on every live WebRTC offer. Merely looking at a dashboard occupied the camera's speaker line. Outbound audio now travels on its own audio-only WebRTC connection, opened when a call is answered and closed when it ends. - The backchannel is claimed only for the duration of a call. Idle viewing claims nothing. - Two-way audio now works in `mse`, `mp4` and `mjpeg` modes (note: the outbound audio still traverses WebRTC). - No renegotiation and no video blink at call start or end. - A call that cannot carry audio now reports it and ends, instead of showing a live microphone that goes nowhere. - `live.microphone.always_connected` is now purely about the browser microphone permission prompt. - Call setup measured at 66ms (LAN) and ~260ms (cellular) for ICE and DTLS, plus ~300ms for `go2rtc` to open an RTSP backchannel. Verified against a live Frigate + `go2rtc` instance, and by unit tests at 100% coverage. - Closes #2691 - Closes #2039 - Closes #2178 Ref #2299 -- the probe no longer opens a backchannel, but it still runs per camera on every load and reconnect, and still dials the camera on the direct-`go2rtc` path. Caching remains to be done. Ref AlexxIT/go2rtc#1860 -- once a call has opened a backchannel, `go2rtc` keeps that media set up on the camera's RTSP session for the life of the producer. Diagnoses #2678
130 lines
4.1 KiB
TypeScript
130 lines
4.1 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import { mock } from 'vitest-mock-extended';
|
|
|
|
import { supports2WayAudio } from '../../src/go2rtc/audio';
|
|
import { homeAssistantSignAndFetch } from '../../src/ha/fetch';
|
|
import type { HomeAssistant } from '../../src/ha/types';
|
|
import { createProxiedEndpointIfNecessary } from '../../src/ha/web-proxy';
|
|
import type { Endpoint } from '../../src/types';
|
|
|
|
vi.mock('../../src/ha/fetch');
|
|
vi.mock('../../src/ha/web-proxy');
|
|
|
|
describe('supports2WayAudio', () => {
|
|
const hass = mock<HomeAssistant>();
|
|
const endpoint: Endpoint = { endpoint: 'http://go2rtc', sign: true };
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it('should return false if no endpoint provided', async () => {
|
|
expect(await supports2WayAudio(hass, 2, null)).toBe(false);
|
|
});
|
|
|
|
it('should return false if fetch fails', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(endpoint);
|
|
vi.mocked(homeAssistantSignAndFetch).mockRejectedValue(new Error('fetch error'));
|
|
|
|
const spy = vi.spyOn(console, 'warn');
|
|
const result = await supports2WayAudio(hass, 2, endpoint);
|
|
|
|
expect(result).toBe(false);
|
|
expect(spy).toHaveBeenCalledWith('fetch error');
|
|
spy.mockRestore();
|
|
});
|
|
|
|
it('should return false if stream info has no producers', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(endpoint);
|
|
vi.mocked(homeAssistantSignAndFetch).mockResolvedValue({ producers: undefined });
|
|
|
|
expect(await supports2WayAudio(hass, 2, endpoint)).toBe(false);
|
|
});
|
|
|
|
it('should use default metadata fetch timeout', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(endpoint);
|
|
vi.mocked(homeAssistantSignAndFetch).mockResolvedValue({ producers: [] });
|
|
|
|
await supports2WayAudio(hass, 2, endpoint);
|
|
|
|
expect(homeAssistantSignAndFetch).toHaveBeenCalledWith(
|
|
hass,
|
|
endpoint,
|
|
expect.anything(),
|
|
{ timeoutSeconds: 2 },
|
|
);
|
|
});
|
|
|
|
it('should use custom metadata fetch timeout when provided', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(endpoint);
|
|
vi.mocked(homeAssistantSignAndFetch).mockResolvedValue({ producers: [] });
|
|
|
|
await supports2WayAudio(hass, 15, endpoint);
|
|
|
|
expect(homeAssistantSignAndFetch).toHaveBeenCalledWith(
|
|
hass,
|
|
endpoint,
|
|
expect.anything(),
|
|
{ timeoutSeconds: 15 },
|
|
);
|
|
});
|
|
|
|
it('should return false if no producer supports audio', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(endpoint);
|
|
vi.mocked(homeAssistantSignAndFetch).mockResolvedValue({
|
|
producers: [
|
|
{
|
|
medias: ['video,sendonly,h264'],
|
|
},
|
|
],
|
|
});
|
|
|
|
expect(await supports2WayAudio(hass, 2, endpoint)).toBe(false);
|
|
});
|
|
|
|
it('should return true if producer supports audio and sendonly', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(endpoint);
|
|
vi.mocked(homeAssistantSignAndFetch).mockResolvedValue({
|
|
producers: [
|
|
{
|
|
medias: ['audio,sendonly,opus'],
|
|
},
|
|
],
|
|
});
|
|
|
|
expect(await supports2WayAudio(hass, 2, endpoint)).toBe(true);
|
|
});
|
|
|
|
it('should return true if producer supports audio and sendrecv', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(endpoint);
|
|
vi.mocked(homeAssistantSignAndFetch).mockResolvedValue({
|
|
producers: [
|
|
{
|
|
medias: ['audio,sendrecv,pcmu'],
|
|
},
|
|
],
|
|
});
|
|
|
|
expect(await supports2WayAudio(hass, 2, endpoint)).toBe(true);
|
|
});
|
|
|
|
it('should handle missing medias in producer', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(endpoint);
|
|
vi.mocked(homeAssistantSignAndFetch).mockResolvedValue({
|
|
producers: [
|
|
{
|
|
medias: undefined,
|
|
},
|
|
],
|
|
});
|
|
|
|
expect(await supports2WayAudio(hass, 2, endpoint)).toBe(false);
|
|
});
|
|
|
|
it('should return false if proxied endpoint is null', async () => {
|
|
vi.mocked(createProxiedEndpointIfNecessary).mockResolvedValue(null);
|
|
|
|
expect(await supports2WayAudio(hass, 2, endpoint)).toBe(false);
|
|
});
|
|
});
|