Dermot Duffy
11cc543406
The card claimed a camera's ONVIF audio backchannel in two places that had nothing to do with a call: the capability probe at camera init (`µphone`), and a pre-armed `sendonly` audio transceiver on every live WebRTC offer. Merely looking at a dashboard occupied the camera's speaker line. Outbound audio now travels on its own audio-only WebRTC connection, opened when a call is answered and closed when it ends. - The backchannel is claimed only for the duration of a call. Idle viewing claims nothing. - Two-way audio now works in `mse`, `mp4` and `mjpeg` modes (note: the outbound audio still traverses WebRTC). - No renegotiation and no video blink at call start or end. - A call that cannot carry audio now reports it and ends, instead of showing a live microphone that goes nowhere. - `live.microphone.always_connected` is now purely about the browser microphone permission prompt. - Call setup measured at 66ms (LAN) and ~260ms (cellular) for ICE and DTLS, plus ~300ms for `go2rtc` to open an RTSP backchannel. Verified against a live Frigate + `go2rtc` instance, and by unit tests at 100% coverage. - Closes #2691 - Closes #2039 - Closes #2178 Ref #2299 -- the probe no longer opens a backchannel, but it still runs per camera on every load and reconnect, and still dials the camera on the direct-`go2rtc` path. Caching remains to be done. Ref AlexxIT/go2rtc#1860 -- once a call has opened a backchannel, `go2rtc` keeps that media set up on the camera's RTSP session for the life of the producer. Diagnoses #2678
60 lines
1.9 KiB
TypeScript
60 lines
1.9 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
|
|
import { OffscreenVideo } from '../../../../../src/components-lib/live/providers/go2rtc-experimental/offscreen-video';
|
|
import { FakeMediaStream, FakeMediaStreamTrack } from '../../../../go2rtc/test-utils';
|
|
|
|
// @vitest-environment jsdom
|
|
describe('OffscreenVideo', () => {
|
|
it('should create the video from the factory on get', () => {
|
|
const video = document.createElement('video');
|
|
const offscreen = new OffscreenVideo(() => video);
|
|
|
|
expect(offscreen.get()).toBe(video);
|
|
});
|
|
|
|
it('should reuse the same video across repeated get', () => {
|
|
const create = vi.fn(() => document.createElement('video'));
|
|
const offscreen = new OffscreenVideo(create);
|
|
|
|
expect(offscreen.get()).toBe(offscreen.get());
|
|
expect(create).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('should create a video with the default factory when none is injected', () => {
|
|
const offscreen = new OffscreenVideo();
|
|
|
|
expect(offscreen.get()).toBeInstanceOf(HTMLVideoElement);
|
|
});
|
|
|
|
it('should detach src and srcObject on clear', () => {
|
|
const video = document.createElement('video');
|
|
const offscreen = new OffscreenVideo(() => video);
|
|
offscreen.get();
|
|
video.src = 'data:video/mp4;base64,AAAA';
|
|
video.srcObject = new FakeMediaStream([
|
|
new FakeMediaStreamTrack('video'),
|
|
]).asMediaStream();
|
|
|
|
offscreen.clear();
|
|
|
|
expect(video.hasAttribute('src')).toBe(false);
|
|
expect(video.srcObject).toBeNull();
|
|
});
|
|
|
|
it('should create a fresh video after clear', () => {
|
|
const create = vi.fn(() => document.createElement('video'));
|
|
const offscreen = new OffscreenVideo(create);
|
|
offscreen.get();
|
|
offscreen.clear();
|
|
offscreen.get();
|
|
|
|
expect(create).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it('should tolerate clear when no video is held', () => {
|
|
const offscreen = new OffscreenVideo(() => document.createElement('video'));
|
|
|
|
expect(() => offscreen.clear()).not.toThrow();
|
|
});
|
|
});
|