Dermot Duffy
11cc543406
The card claimed a camera's ONVIF audio backchannel in two places that had nothing to do with a call: the capability probe at camera init (`µphone`), and a pre-armed `sendonly` audio transceiver on every live WebRTC offer. Merely looking at a dashboard occupied the camera's speaker line. Outbound audio now travels on its own audio-only WebRTC connection, opened when a call is answered and closed when it ends. - The backchannel is claimed only for the duration of a call. Idle viewing claims nothing. - Two-way audio now works in `mse`, `mp4` and `mjpeg` modes (note: the outbound audio still traverses WebRTC). - No renegotiation and no video blink at call start or end. - A call that cannot carry audio now reports it and ends, instead of showing a live microphone that goes nowhere. - `live.microphone.always_connected` is now purely about the browser microphone permission prompt. - Call setup measured at 66ms (LAN) and ~260ms (cellular) for ICE and DTLS, plus ~300ms for `go2rtc` to open an RTSP backchannel. Verified against a live Frigate + `go2rtc` instance, and by unit tests at 100% coverage. - Closes #2691 - Closes #2039 - Closes #2178 Ref #2299 -- the probe no longer opens a backchannel, but it still runs per camera on every load and reconnect, and still dials the camera on the direct-`go2rtc` path. Caching remains to be done. Ref AlexxIT/go2rtc#1860 -- once a call has opened a backchannel, `go2rtc` keeps that media set up on the camera's RTSP session for the life of the producer. Diagnoses #2678
82 lines
2.8 KiB
TypeScript
82 lines
2.8 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { mock } from 'vitest-mock-extended';
|
|
|
|
import { Camera } from '../../../../src/camera-manager/camera';
|
|
import type { CameraManagerEngine } from '../../../../src/camera-manager/engine';
|
|
import { FrigateCamera } from '../../../../src/camera-manager/frigate/camera';
|
|
import { createBackchannel } from '../../../../src/components-lib/live/backchannel/factory';
|
|
import { Go2RTCBackchannel } from '../../../../src/components-lib/live/backchannel/go2rtc';
|
|
import type { HomeAssistant } from '../../../../src/ha/types';
|
|
import { createCameraConfig } from '../../../config/test-utils';
|
|
|
|
describe('createBackchannel', () => {
|
|
it('should create a backchannel for a go2rtc camera', () => {
|
|
const camera = new Camera(
|
|
createCameraConfig({
|
|
live_provider: 'go2rtc',
|
|
go2rtc: { url: 'https://go2rtc', stream: 'office' },
|
|
}),
|
|
mock<CameraManagerEngine>(),
|
|
);
|
|
|
|
expect(createBackchannel(mock<HomeAssistant>(), camera)).toBeInstanceOf(
|
|
Go2RTCBackchannel,
|
|
);
|
|
});
|
|
|
|
it('should create a backchannel for a go2rtc-experimental camera', () => {
|
|
const camera = new Camera(
|
|
createCameraConfig({
|
|
live_provider: 'go2rtc-experimental',
|
|
go2rtc: { url: 'https://go2rtc', stream: 'office' },
|
|
}),
|
|
mock<CameraManagerEngine>(),
|
|
);
|
|
|
|
expect(createBackchannel(mock<HomeAssistant>(), camera)).toBeInstanceOf(
|
|
Go2RTCBackchannel,
|
|
);
|
|
});
|
|
|
|
it('should not create a backchannel for a non-go2rtc camera', () => {
|
|
const camera = new Camera(
|
|
createCameraConfig({
|
|
camera_entity: 'camera.office',
|
|
live_provider: 'ha',
|
|
}),
|
|
mock<CameraManagerEngine>(),
|
|
);
|
|
|
|
expect(createBackchannel(mock<HomeAssistant>(), camera)).toBeNull();
|
|
});
|
|
|
|
it('should not create a backchannel without a go2rtc endpoint', () => {
|
|
const camera = new Camera(
|
|
createCameraConfig({ live_provider: 'go2rtc' }),
|
|
mock<CameraManagerEngine>(),
|
|
);
|
|
|
|
expect(createBackchannel(mock<HomeAssistant>(), camera)).toBeNull();
|
|
});
|
|
|
|
it('should use the endpoint the camera engine resolves', () => {
|
|
// A Frigate camera serves go2rtc through the Frigate integration's proxy
|
|
// rather than at a directly-configured URL, so the endpoint must come from
|
|
// the camera rather than being rebuilt from its configuration.
|
|
const camera = new FrigateCamera(
|
|
createCameraConfig({
|
|
live_provider: 'go2rtc',
|
|
frigate: { client_id: 'frigate', camera_name: 'office' },
|
|
}),
|
|
mock<CameraManagerEngine>(),
|
|
);
|
|
|
|
expect(camera.getEndpoints()?.go2rtc?.endpoint).toBe(
|
|
'/api/frigate/frigate/mse/api/ws?src=office',
|
|
);
|
|
expect(createBackchannel(mock<HomeAssistant>(), camera)).toBeInstanceOf(
|
|
Go2RTCBackchannel,
|
|
);
|
|
});
|
|
});
|