Files
Dermot Duffy 17146c8ca6 fix: Clear the initialized condition state when the card is not usable (#2646)
The `initialized` state (used in conditions/triggers) was written once
and never cleared, so it meant "has this card ever been initialized"
while everything reading it took it as "is this card usable now". Home
Assistant takes a card off the page and puts it back whenever its
dashboard tab is left and returned to, so the card initialized again
while the state claimed it was initialized throughout: `trigger:
initialized` fired once per card rather than once per startup, and
automations were dropped in between.

The card lifecycle is now an explicit state machine (`SessionManager`),
the only writer of `initialized`, which separates a card that is
starting up from one initializing part of itself again while it runs. A
new `ever` parameter (conditions/triggers) selects the old latched
behaviour.

`remote_control` uses that parameter to keep its two camera priorities
correct under repeated starts. With `camera_priority: entity` the card
now re-reads the entity every time it starts, so a camera selected while
the card was away is picked up on return. With `camera_priority: card`
the card writes the entity on its first start only, unchanged, since
repeating that write would overwrite a camera the user had selected.

Closes: #2642


BREAKING CHANGE: `condition: initialized` is now `false` whenever the
card is not usable, and `trigger: initialized` fires each time the card
starts up rather than only the first time. Set `ever: true` on either to
keep the previous behaviour.
2026-08-02 12:52:58 -07:00

62 lines
3.8 KiB
TypeScript

import { describe, expect, it } from 'vitest';
import { ConditionStateManager } from '../../../src/condition-trigger/conditions/state-manager';
import { createTriggerEvaluator } from '../../../src/condition-trigger/triggers/factory';
import { CallTrigger } from '../../../src/condition-trigger/triggers/triggers/call';
import { CameraTrigger } from '../../../src/condition-trigger/triggers/triggers/camera';
import { ConfigTrigger } from '../../../src/condition-trigger/triggers/triggers/config';
import { DisplayModeTrigger } from '../../../src/condition-trigger/triggers/triggers/display-mode';
import { EventTrigger } from '../../../src/condition-trigger/triggers/triggers/event';
import { ExpandTrigger } from '../../../src/condition-trigger/triggers/triggers/expand';
import { FullscreenTrigger } from '../../../src/condition-trigger/triggers/triggers/fullscreen';
import { InitializedTrigger } from '../../../src/condition-trigger/triggers/triggers/initialized';
import { InteractionTrigger } from '../../../src/condition-trigger/triggers/triggers/interaction';
import { KeyTrigger } from '../../../src/condition-trigger/triggers/triggers/key';
import { MediaLoadedTrigger } from '../../../src/condition-trigger/triggers/triggers/media-loaded';
import { MicrophoneTrigger } from '../../../src/condition-trigger/triggers/triggers/microphone';
import { NumericStateTrigger } from '../../../src/condition-trigger/triggers/triggers/numeric-state';
import { ScreenTrigger } from '../../../src/condition-trigger/triggers/triggers/screen';
import { StateTrigger } from '../../../src/condition-trigger/triggers/triggers/state';
import { TemplateTrigger } from '../../../src/condition-trigger/triggers/triggers/template';
import { TriggeredTrigger } from '../../../src/condition-trigger/triggers/triggers/triggered';
import type {
TriggerEvaluator,
TriggerEvaluatorContext,
} from '../../../src/condition-trigger/triggers/triggers/types';
import { ViewTrigger } from '../../../src/condition-trigger/triggers/triggers/view';
import type { Trigger } from '../../../src/config/schema/condition-trigger/triggers/types';
import { createHASSManager, createMockTemplateRenderer } from '../../test-utils';
type TriggerEvaluatorConstructor = new (...args: never[]) => TriggerEvaluator;
describe('createTriggerEvaluator', () => {
const context = (): TriggerEvaluatorContext => ({
stateManager: new ConditionStateManager(),
templateRenderer: createMockTemplateRenderer(),
hassManager: createHASSManager(),
});
it.each<[Trigger, TriggerEvaluatorConstructor]>([
[{ trigger: 'event', event_type: 'zha_event' }, EventTrigger],
[{ trigger: 'state', entity_id: 'binary_sensor.x' }, StateTrigger],
[{ trigger: 'numeric_state', entity_id: 'sensor.x', above: 5 }, NumericStateTrigger],
[{ trigger: 'template', value_template: '{{ true }}' }, TemplateTrigger],
[{ trigger: 'call', to: 'answered' }, CallTrigger],
[{ trigger: 'camera', cameras: ['front'] }, CameraTrigger],
[{ trigger: 'config' }, ConfigTrigger],
[{ trigger: 'display_mode', display_mode: 'single' }, DisplayModeTrigger],
[{ trigger: 'expand', expand: true }, ExpandTrigger],
[{ trigger: 'fullscreen', fullscreen: true }, FullscreenTrigger],
[{ trigger: 'interaction', interaction: true }, InteractionTrigger],
[{ trigger: 'media_loaded', media_loaded: true }, MediaLoadedTrigger],
[{ trigger: 'microphone', muted: true }, MicrophoneTrigger],
[{ trigger: 'triggered' }, TriggeredTrigger],
[{ trigger: 'view', views: ['live'] }, ViewTrigger],
[{ trigger: 'initialized', ever: false }, InitializedTrigger],
[{ trigger: 'key', key: 'a' }, KeyTrigger],
[{ trigger: 'screen' }, ScreenTrigger],
])('should create the dedicated evaluator for a %o trigger', (trigger, expected) => {
expect(createTriggerEvaluator(trigger, context())).toBeInstanceOf(expected);
});
});