fix: Replace max_height with height (#1539)

* fix: Replace `max_height` with `height`

BREAKING CHANGE: This entirely removes `min_height`, and replaces `max_height` with `height`. The behavior is obviously not exactly the same, but the prior behavior did not actually work correctly. CSS does not  limit the height of child elements that are `100%` of their parents height if the parent does not have an explicit height set (this caused spillage over the set max height). As such, it's simpler to just allow the user to set the actual height of the card should they need to do so, with a (hopefully) minor loss of flexibility.

* Test fixes
This commit is contained in:
Dermot Duffy
2024-09-15 17:29:05 -07:00
committed by GitHub
parent e13e53b430
commit f924537025
17 changed files with 72 additions and 52 deletions
+1 -2
View File
@@ -267,8 +267,7 @@
"static": "Relació d'aspecte estàtica",
"unconstrained": "Relació d'aspecte sense restriccions"
},
"max_height": "Alçada màxima de la targeta en unitats CSS (p. ex., '100vh')",
"min_height": "Alçada mínima de la targeta en unitats CSS (p. ex., '100 px')"
"height": ""
},
"live": {
"auto_mute": "Silencia automàticament les càmeres en directe",
+1 -2
View File
@@ -267,8 +267,7 @@
"static": "Static aspect ratio",
"unconstrained": "Unconstrained aspect ratio"
},
"max_height": "Maximum card height in CSS units (e.g. '100vh')",
"min_height": "Minimum card height in CSS units (e.g. '100px')"
"height": "Card height in CSS units (e.g. '500px')"
},
"live": {
"auto_mute": "Automatically mute live cameras",
+1 -2
View File
@@ -267,8 +267,7 @@
"static": "Rapport hauteur/largeur statique",
"unconstrained": "Rapport hauteur/largeur sans contrainte"
},
"max_height": "Hauteur maximale de la carte en unités CSS (par exemple '100vh')",
"min_height": "Hauteur minimale de la carte en unités CSS (par exemple « 100 px »)"
"height": ""
},
"live": {
"auto_mute": "Couper automatiquement le son des caméras en direct",
+1 -2
View File
@@ -267,8 +267,7 @@
"static": "Proporzioni statiche",
"unconstrained": "Proporzioni non vincolate"
},
"max_height": "",
"min_height": ""
"height": ""
},
"live": {
"auto_mute": "Muta automaticamente le telecamere in diretta",
+1 -2
View File
@@ -267,8 +267,7 @@
"static": "Proporção estática",
"unconstrained": "Proporção irrestrita"
},
"max_height": "",
"min_height": ""
"height": ""
},
"live": {
"auto_mute": "Silenciar câmeras ao vivo automaticamente",
+1 -2
View File
@@ -267,8 +267,7 @@
"static": "Proporção estática",
"unconstrained": "Proporção irrestrita"
},
"max_height": "",
"min_height": ""
"height": ""
},
"live": {
"auto_mute": "Silenciar câmeras ao vivo automaticamente",