fix: Replace max_height with height (#1539)
* fix: Replace `max_height` with `height` BREAKING CHANGE: This entirely removes `min_height`, and replaces `max_height` with `height`. The behavior is obviously not exactly the same, but the prior behavior did not actually work correctly. CSS does not limit the height of child elements that are `100%` of their parents height if the parent does not have an explicit height set (this caused spillage over the set max height). As such, it's simpler to just allow the user to set the actual height of the card should they need to do so, with a (hopefully) minor loss of flexibility. * Test fixes
This commit is contained in:
+2
-4
@@ -1857,8 +1857,7 @@ export type GalleryConfig = z.infer<typeof galleryConfigSchema>;
|
||||
const dimensionsConfigDefault = {
|
||||
aspect_ratio_mode: 'dynamic' as const,
|
||||
aspect_ratio: [16, 9],
|
||||
max_height: '100vh',
|
||||
min_height: '100px',
|
||||
height: 'auto',
|
||||
};
|
||||
|
||||
export const dimensionsConfigSchema = z
|
||||
@@ -1867,8 +1866,7 @@ export const dimensionsConfigSchema = z
|
||||
.enum(['dynamic', 'static', 'unconstrained'])
|
||||
.default(dimensionsConfigDefault.aspect_ratio_mode),
|
||||
aspect_ratio: aspectRatioSchema.default(dimensionsConfigDefault.aspect_ratio),
|
||||
max_height: z.string().default(dimensionsConfigDefault.max_height),
|
||||
min_height: z.string().default(dimensionsConfigDefault.min_height),
|
||||
height: z.string().default(dimensionsConfigDefault.height),
|
||||
})
|
||||
.default(dimensionsConfigDefault);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user