flan/advanced-camera-card
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: Improve timezone resilience / cleanliness of tests (#2279)

Browse Source 
- Related: https://github.com/dermotduffy/advanced-camera-card/pull/2278
- Reported by @0x464e
This commit is contained in:
Dermot Duffy
2025-12-11 05:33:48 -08:00
committed by GitHub
parent 236f3b7b57
commit f64690335b
6 changed files with 63 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components-lib/thumbnail/details-controller.test.ts
+12 -4
View File
@@ -1,7 +1,9 @@
import { format } from 'date-fns';
import { describe, expect, it } from 'vitest';
import { mock } from 'vitest-mock-extended';
import { CameraManager } from '../../../src/camera-manager/manager';
import { ThumbnailDetailsController } from '../../../src/components-lib/thumbnail/details-controller';
import { formatDateAndTime } from '../../../src/utils/basic';
import { ViewFolder, ViewMediaType } from '../../../src/view/item';
import { createFolder, TestViewMedia } from '../../test-utils';
@@ -135,14 +137,17 @@ describe('ThumbnailDetailsController', () => {
});
it('should have start time in details', () => {
const startTime = new Date('2025-05-18T17:03:00Z');
const item = new TestViewMedia({
startTime: new Date('2025-05-18T17:03:00Z'),
startTime,
});
const controller = new ThumbnailDetailsController();
controller.calculate(null, item);
// Use formatDateAndTime to generate expected value (formats in local time with seconds)
expect(controller.getDetails()).toContainEqual({
title: '2025-05-18 17:03:00',
title: formatDateAndTime(startTime, true),
hint: 'Start',
icon: { icon: 'mdi:calendar-clock-outline' },
});
@@ -249,11 +254,14 @@ describe('ThumbnailDetailsController', () => {
it('should have seek in details', () => {
const item = new TestViewMedia();
const seekTime = new Date('2025-05-20T07:14:57Z');
const controller = new ThumbnailDetailsController();
controller.calculate(null, item, new Date('2025-05-20T07:14:57Z'));
controller.calculate(null, item, seekTime);
// Use format() to generate expected value (formats in local time)
expect(controller.getDetails()).toContainEqual({
title: '07:14:57',
title: format(seekTime, 'HH:mm:ss'),
hint: 'Seek',
icon: { icon: 'mdi:clock-fast' },
});
tests/components-lib/thumbnail/feature/controller.test.ts
+7 -2
View File
@@ -1,3 +1,4 @@
import { format } from 'date-fns';
import { describe, expect, it } from 'vitest';
import { mock } from 'vitest-mock-extended';
import { CameraManager } from '../../../../src/camera-manager/manager';
@@ -18,7 +19,9 @@ describe('ThumbnailFeatureController', () => {
controller.calculate(null, itemWithTime, false);
expect(controller.getTitle()).toBe('17:03');
// Use format() to generate expected time in local timezone
const expectedTime = format(itemWithTime.getStartTime()!, 'HH:mm');
expect(controller.getTitle()).toBe(expectedTime);
});
it('should not set title when details are shown ', () => {
@@ -50,7 +53,9 @@ describe('ThumbnailFeatureController', () => {
controller.calculate(null, itemWithTime, false);
expect(controller.getSubtitles()).toContain('May 18th');
// Use format() to generate expected date string (formats in local time)
const expectedDate = format(itemWithTime.getStartTime()!, 'MMM do');
expect(controller.getSubtitles()).toContain(expectedDate);
});
it('should set subtitle with source from item title ', () => {