Remove confusing carousel methods.

This commit is contained in:
Dermot Duffy
2023-01-24 19:36:54 -08:00
parent 1762b5530f
commit eefe665f25
5 changed files with 61 additions and 102 deletions
+1 -2
View File
@@ -9,7 +9,6 @@ import {
getRecordingTitle,
} from '../camera/frigate/util.js';
import { FrigateEvent, FrigateRecording } from '../camera/frigate/types.js';
import { ViewMediaClassifier } from './media-classifier.js';
export type ViewMediaType = 'clip' | 'snapshot' | 'recording';
export type ViewMediaSourceType = FrigateEvent | FrigateRecording;
@@ -129,7 +128,7 @@ export class FrigateEventViewMedia
cameraConfig.frigate.client_id,
cameraConfig.frigate.camera_name,
this._source,
ViewMediaClassifier.isClip(this) ? 'clips' : 'snapshots',
this._mediaType === 'clip' ? 'clips' : 'snapshots',
);
}
-4
View File
@@ -1,7 +1,3 @@
// Easy:
// - TODO: In MediaQueriesBase, do we need to generic? Just have T be a MediaQuery?
// - TODO: In the viewer @click handlers should I use this.selected instead of calling carouselScrollPrevious()
// Medium:
// - TODO: Callers of all async methods of data-engine need to catch errors.
// - TODO: Add garbage collecting of segments not present in the recording summaries anymore.