perf(bundle): lazy-load the nunjucks template engine (#2535)
Closes #2531. ## Summary The full `nunjucks` templating engine (~226KB) plus `ha-nunjucks` (~46KB) — roughly **272KB, ~13% of the eager entry chunk** — was statically imported and downloaded by every card on initial load, even though templates only apply when a config value contains a `{{ … }}` / `{% … %}` delimiter. Most cards use no templates and never need the engine. This defers the engine behind a dynamic `import('ha-nunjucks/dist')` so it ships in a separate, on-demand chunk instead of the eager `card-*.js`. ## Approach The render path (`TemplateRenderer.renderRecursively`) is **kept synchronous** — it is called from many synchronous hot paths (condition/trigger evaluators, picture-elements rendering, actions, folder matchers), and making it async would be a large, high-risk refactor of the evaluation core. Instead: - **New `src/card-controller/templates/engine.ts`** — a module-level singleton lazy loader (`loadTemplateEngine()` / `getTemplateEngine()`) shared across all `TemplateRenderer` instances, plus a `containsTemplate()` delimiter helper. - **Delimiter gating** — strings without a delimiter never touch the engine (the overwhelming majority of renders). - **Pre-warm at config time** — because every template string originates in the config, a new mandatory `TEMPLATE_ENGINE` initialization aspect loads the engine before first render whenever the config contains a delimiter. This **guarantees no raw `{{ … }}` flash**: content/condition rendering is blocked until the engine is present for template-using cards. Cards without templates never load it. ## Result - nunjucks + ha-nunjucks move out of the eager chunk into a separate chunk fetched only when a card actually uses templates. - No change to the synchronous public render API; condition/trigger evaluation core untouched. ## Tests - New `engine.ts` loader coverage (concurrent load, cached reuse, not-loaded fallback). - The 11 existing test files that render real (delimiter-bearing) templates declare their dependency explicitly via `beforeAll(loadTemplateEngine)` — no global/implicit setup hook. - Full suite green (4764 tests), lint and ts-prune clean, per-file 100% coverage maintained for the affected directories. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016ykWemdkZrgywvC71pHc6c --- _Generated by [Claude Code](https://claude.ai/code/session_016ykWemdkZrgywvC71pHc6c)_
This commit is contained in:
committed by
dermotduffy
parent
b33c034810
commit
ea251ca988
@@ -30,6 +30,7 @@ import type { PIPManager } from './pip-manager';
|
||||
import type { QueryStringManager } from './query-string-manager';
|
||||
import type { StatusBarItemManager } from './status-bar-item-manager';
|
||||
import type { StyleManager } from './style-manager';
|
||||
import type { TemplateManager } from './templates';
|
||||
import type { ViewItemManager } from './view/item-manager';
|
||||
import type { ViewManager } from './view/view-manager';
|
||||
|
||||
@@ -62,6 +63,7 @@ export interface CardActionsAPI {
|
||||
getIssueManager(): IssueManager;
|
||||
getStatusBarItemManager(): StatusBarItemManager;
|
||||
getCameraTriggersManager(): CameraTriggersManager;
|
||||
getTemplateManager(): TemplateManager;
|
||||
getViewItemManager(): ViewItemManager;
|
||||
getViewManager(): ViewManager;
|
||||
}
|
||||
@@ -75,6 +77,7 @@ export interface CardAutomationsAPI {
|
||||
getInitializationManager(): InitializationManager;
|
||||
getNotificationManager(): NotificationManager;
|
||||
getIssueManager(): IssueManager;
|
||||
getTemplateManager(): TemplateManager;
|
||||
}
|
||||
|
||||
export interface CardCallAPI {
|
||||
@@ -123,6 +126,7 @@ export interface CardConfigAPI {
|
||||
getIssueManager(): IssueManager;
|
||||
getStatusBarItemManager(): StatusBarItemManager;
|
||||
getStyleManager(): StyleManager;
|
||||
getTemplateManager(): TemplateManager;
|
||||
getViewManager(): ViewManager;
|
||||
}
|
||||
|
||||
@@ -184,6 +188,7 @@ export interface CardFoldersAPI {
|
||||
getConfigManager(): ConfigManager;
|
||||
getHASSManager(): HASSManager;
|
||||
getResolvedMediaCache(): ResolvedMediaCache;
|
||||
getTemplateManager(): TemplateManager;
|
||||
}
|
||||
|
||||
export interface CardFullscreenAPI {
|
||||
@@ -220,6 +225,7 @@ export interface CardInitializerAPI {
|
||||
createMicrophoneManager(): void;
|
||||
getMicrophoneManager(): MicrophoneManager;
|
||||
|
||||
getAutomationsManager(): AutomationsManager;
|
||||
getCardElementManager(): CardElementManager;
|
||||
getConditionStateManager(): ConditionStateManager;
|
||||
getConfigManager(): ConfigManager;
|
||||
@@ -231,6 +237,7 @@ export interface CardInitializerAPI {
|
||||
getQueryStringManager(): QueryStringManager;
|
||||
getResolvedMediaCache(): ResolvedMediaCache;
|
||||
getCameraTriggersManager(): CameraTriggersManager;
|
||||
getTemplateManager(): TemplateManager;
|
||||
getViewManager(): ViewManager;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user