flan/advanced-camera-card
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Experimental fix for pan issues on slower devices (#2270)

Browse Source 
- Related: #2223
This commit is contained in:
Dermot Duffy
2025-12-09 07:23:18 -08:00
committed by GitHub
parent f41454580c
commit dacde91f3a
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components-lib/zoom/zoom-controller.ts
+8 -1
View File
@@ -303,14 +303,21 @@ export class ZoomController {
// "contain" the pan within the parent, this creates somewhat of an async // "contain" the pan within the parent, this creates somewhat of an async
// situation where we need to ensure the zoom completes first. Using // situation where we need to ensure the zoom completes first. Using
// `requestAnimationFrame` appears to reliably allow the zoom to finish // `requestAnimationFrame` appears to reliably allow the zoom to finish
// rendering first, before the pain is applied. // rendering first, before the pan is applied.
// //
// See: https://github.com/timmywil/panzoom?tab=readme-ov-file#a-note-on-the-async-nature-of-panzoom // See: https://github.com/timmywil/panzoom?tab=readme-ov-file#a-note-on-the-async-nature-of-panzoom
window.requestAnimationFrame(() => { window.requestAnimationFrame(() => {
// On slow Android WebView devices, the zoom transform may not have fully
// painted by the time this callback runs. Panzoom's contain logic would
// then clip the pan to incorrect bounds. Temporarily disable containment
// for this programmatic pan, then restore it.
// See: https://github.com/dermotduffy/advanced-camera-card/issues/2223
this._panzoom?.setOptions({ contain: undefined });
this._panzoom?.pan(x, y, { this._panzoom?.pan(x, y, {
animate: true, animate: true,
duration: 100, duration: 100,
}); });
this._panzoom?.setOptions({ contain: 'outside' });
}); });
} }