From d727593ed8e7e121af7be5c4880b25441a412e42 Mon Sep 17 00:00:00 2001
From: Dermot Duffy <dermot.duffy@gmail.com>
Date: Tue, 26 Oct 2021 14:04:37 -0700
Subject: [PATCH] Use an LRU for the resolved media instead of growing
 unbounded.

---
 package.json                   |  1 +
 src/localize/languages/en.json |  3 ++-
 src/resolved-media.ts          | 19 ++++++++++++++-----
 3 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/package.json b/package.json
index 10d675a6..4354e004 100644
--- a/package.json
+++ b/package.json
@@ -22,6 +22,7 @@
     "embla-carousel": "^5.0.1",
     "home-assistant-js-websocket": "^5.11.1",
     "lit": "^2.0.2",
+    "quick-lru": "github:sindresorhus/quick-lru",
     "screenfull": "^5.1.0",
     "zod": "^3.10.0"
   },
diff --git a/src/localize/languages/en.json b/src/localize/languages/en.json
index 7e988568..7152651e 100644
--- a/src/localize/languages/en.json
+++ b/src/localize/languages/en.json
@@ -34,7 +34,8 @@
     "label": "Frigate label/object filter (Optional)",
     "live_provider": "Live view provider (Optional)",
     "live_preload": "Preload live view",
-    "image": "Static image URL for image view (Optional)"
+    "image": "Static image URL for image view (Optional)",
+    "lazy_load": "Lazily load event media"
   },
   "menu": {
     "frigate": "Frigate Menu / Default View",
diff --git a/src/resolved-media.ts b/src/resolved-media.ts
index 531b64b8..4268719e 100644
--- a/src/resolved-media.ts
+++ b/src/resolved-media.ts
@@ -6,24 +6,33 @@ import {
   ResolvedMedia,
   resolvedMediaSchema,
 } from './types.js';
+import QuickLRU from 'quick-lru';
+
+// It's important the cache size be at least as large as the largest likely
+// media query or media items will from a given query will be evicted for other
+// items in the same query (which would result in only partial results being
+// returned to the user).
+// Note: Each entry is about 400 bytes. 
+
+const RESOLVED_MEDIA_CACHE_SIZE = 1000; 
 
 export class ResolvedMediaCache {
-  protected _cache: Record<string, ResolvedMedia>;
+  protected _cache: QuickLRU<string, ResolvedMedia>;
 
   constructor() {
-    this._cache = {};
+    this._cache = new QuickLRU({maxSize: RESOLVED_MEDIA_CACHE_SIZE});
   }
 
   public has(id: string): boolean {
-    return id in this._cache;
+    return this._cache.has(id);
   }
 
   public get(id: string): ResolvedMedia | undefined {
-    return this._cache[id];
+    return this._cache.get(id);
   }
 
   public set(id: string, resolvedMedia: ResolvedMedia): void {
-    this._cache[id] = resolvedMedia;
+    this._cache.set(id, resolvedMedia);
   }
 }