From d1755eedcbc7176094909a7b784a09c0b94d54dc Mon Sep 17 00:00:00 2001
From: Dermot Duffy <dermot.duffy@gmail.com>
Date: Mon, 30 Jan 2023 20:30:26 -0800
Subject: [PATCH] Reset the timeline data source when the cameraIDs change.

---
 src/components/timeline-core.ts | 16 ++++++++--------
 src/utils/timeline-source.ts    | 13 ++-----------
 2 files changed, 10 insertions(+), 19 deletions(-)

diff --git a/src/components/timeline-core.ts b/src/components/timeline-core.ts
index a54153e4..3e75ae9e 100644
--- a/src/components/timeline-core.ts
+++ b/src/components/timeline-core.ts
@@ -186,7 +186,7 @@ export class FrigateCardTimelineCore extends LitElement {
   // Which cameraIDs to include in the timeline. If not specified, all cameraIDs
   // are shown.
   @property({ attribute: false, hasChanged: contentsChanged })
-  public  cameraIDs?: Set<string>;
+  public cameraIDs?: Set<string>;
 
   @property({ attribute: false })
   public cameraManager?: CameraManager;
@@ -342,7 +342,8 @@ export class FrigateCardTimelineCore extends LitElement {
 
     const targetBarOn =
       !this._locked ||
-      (this.mini && this._timeline.getSelection().some((id) => {
+      (this.mini &&
+        this._timeline.getSelection().some((id) => {
           const item = this._timelineSource?.dataset?.get(id);
           return (
             item &&
@@ -596,8 +597,8 @@ export class FrigateCardTimelineCore extends LitElement {
       !MediaQueriesClassifier.areRecordingQueries(this.view.query)
     ) {
       const newView = await this._createViewWithEventMediaQuery(
-          this._createEventMediaQuerys({ window: this._timeline.getWindow() }),
-        )
+        this._createEventMediaQuerys({ window: this._timeline.getWindow() }),
+      );
 
       // Specifically avoid dispatching new results on range change unless there
       // is something to be gained by doing so. Example usecase: On initial view
@@ -607,9 +608,7 @@ export class FrigateCardTimelineCore extends LitElement {
       // 'flicker' for the user as the viewer reloads all the media).
       const newResults = newView?.queryResults;
       if (newView && newResults && !this.view.queryResults?.isSupersetOf(newResults)) {
-        newView
-          ?.mergeInContext(this._setWindowInContext())
-          ?.dispatchChangeEvent(this);
+        newView?.mergeInContext(this._setWindowInContext())?.dispatchChangeEvent(this);
       }
     }
   }
@@ -1036,7 +1035,8 @@ export class FrigateCardTimelineCore extends LitElement {
     if (
       changedProps.has('cameraManager') ||
       changedProps.has('cameras') ||
-      changedProps.has('timelineConfig')
+      changedProps.has('timelineConfig') ||
+      changedProps.has('cameraIDs')
     ) {
       if (this.cameraManager && this.cameras && this.timelineConfig) {
         this._timelineSource = new TimelineDataSource(
diff --git a/src/utils/timeline-source.ts b/src/utils/timeline-source.ts
index de6d3b02..ab84cf00 100644
--- a/src/utils/timeline-source.ts
+++ b/src/utils/timeline-source.ts
@@ -3,9 +3,9 @@ import add from 'date-fns/add';
 import sub from 'date-fns/sub';
 import { DataSet } from 'vis-data';
 import { IdType, TimelineItem, TimelineWindow } from 'vis-timeline/esnext';
-import { ClipsOrSnapshotsOrAll, RecordingSegment } from '../types';
+import { ClipsOrSnapshotsOrAll } from '../types';
 import { CameraManager } from '../camera-manager/manager';
-import { EventQuery } from '../camera-manager/types';
+import { EventQuery, RecordingSegment } from '../camera-manager/types';
 import { capEndDate, convertRangeToCacheFriendlyTimes } from '../camera-manager/util';
 import { ViewMedia } from '../view/media';
 import {
@@ -64,15 +64,6 @@ export class TimelineDataSource {
     return this._dataset;
   }
 
-  public clearEvents(): void {
-    this._eventRanges.clear();
-    this._dataset.remove(
-      this._dataset.get({
-        filter: (item) => item.type !== 'background',
-      }),
-    );
-  }
-
   public rewriteEvent(id: IdType): void {
     // Hack: For timeline uses of the event dataset clustering may not update
     // unless the dataset changes, artifically update the dataset to ensure the