feat: Rename the card to advanced-camera-card (#1873)
Whilst the Frigate support in this card is the best among camera engines, the name incorrectly suggests that Frigate is a requirement. Instead, to broaden the appeal, change to more camera agnostic name. This does not suggest any change in priority, role or support for Frigate. This change is likely to be bug prone, due to the size of the rename -- the code contains 1500+ references to "Frigate" most of which make sense to rename, some which do not, all of which needed human assessment. - Closes #1298 BREAKING CHANGE: References to `frigate-card` in all kinds of configuration need to be updated to `advanced-camera-card`. An automated config upgrade should take care of the majority of usecases (click `Edit -> Upgrade -> Save`), though may not be perfect.
This commit is contained in:
@@ -4,7 +4,7 @@ import {
|
||||
MediaActionsController,
|
||||
MediaActionsControllerOptions,
|
||||
} from '../../src/components-lib/media-actions-controller';
|
||||
import { FrigateCardMediaPlayer } from '../../src/types';
|
||||
import { AdvancedCameraCardMediaPlayer } from '../../src/types';
|
||||
import {
|
||||
IntersectionObserverMock,
|
||||
MutationObserverMock,
|
||||
@@ -18,11 +18,11 @@ import { callVisibilityHandler, createTestSlideNodes } from '../utils/embla/test
|
||||
const getPlayer = (
|
||||
element: HTMLElement,
|
||||
selector: string,
|
||||
): (HTMLElement & FrigateCardMediaPlayer) | null => {
|
||||
): (HTMLElement & AdvancedCameraCardMediaPlayer) | null => {
|
||||
return element.querySelector(selector);
|
||||
};
|
||||
|
||||
const createPlayer = (): HTMLElement & FrigateCardMediaPlayer => {
|
||||
const createPlayer = (): HTMLElement & AdvancedCameraCardMediaPlayer => {
|
||||
const player = document.createElement('video');
|
||||
|
||||
player['play'] = vi.fn();
|
||||
@@ -35,7 +35,7 @@ const createPlayer = (): HTMLElement & FrigateCardMediaPlayer => {
|
||||
player['setControls'] = vi.fn();
|
||||
player['isPaused'] = vi.fn();
|
||||
|
||||
return player as unknown as HTMLElement & FrigateCardMediaPlayer;
|
||||
return player as unknown as HTMLElement & AdvancedCameraCardMediaPlayer;
|
||||
};
|
||||
|
||||
const createPlayerSlideNodes = (n = 10): HTMLElement[] => {
|
||||
@@ -231,7 +231,7 @@ describe('MediaActionsController', () => {
|
||||
controller.unsetTarget();
|
||||
|
||||
getPlayer(children[0], 'video')?.dispatchEvent(
|
||||
new Event('frigate-card:media:loaded'),
|
||||
new Event('advanced-camera-card:media:loaded'),
|
||||
);
|
||||
await flushPromises();
|
||||
|
||||
@@ -255,7 +255,7 @@ describe('MediaActionsController', () => {
|
||||
expect(getPlayer(children[0], 'video')?.play).toBeCalledTimes(1);
|
||||
|
||||
getPlayer(children[0], 'video')?.dispatchEvent(
|
||||
new Event('frigate-card:media:loaded'),
|
||||
new Event('advanced-camera-card:media:loaded'),
|
||||
);
|
||||
|
||||
await flushPromises();
|
||||
@@ -277,7 +277,7 @@ describe('MediaActionsController', () => {
|
||||
expect(getPlayer(children[0], 'video')?.unmute).toBeCalledTimes(1);
|
||||
|
||||
getPlayer(children[0], 'video')?.dispatchEvent(
|
||||
new Event('frigate-card:media:loaded'),
|
||||
new Event('advanced-camera-card:media:loaded'),
|
||||
);
|
||||
|
||||
await flushPromises();
|
||||
@@ -299,7 +299,7 @@ describe('MediaActionsController', () => {
|
||||
await controller.setTarget(0, true);
|
||||
|
||||
getPlayer(children[9], 'video')?.dispatchEvent(
|
||||
new Event('frigate-card:media:loaded'),
|
||||
new Event('advanced-camera-card:media:loaded'),
|
||||
);
|
||||
|
||||
await flushPromises();
|
||||
@@ -325,7 +325,7 @@ describe('MediaActionsController', () => {
|
||||
expect(getPlayer(children[0], 'video')?.unmute).toBeCalledTimes(1);
|
||||
|
||||
getPlayer(children[0], 'video')?.dispatchEvent(
|
||||
new Event('frigate-card:media:loaded'),
|
||||
new Event('advanced-camera-card:media:loaded'),
|
||||
);
|
||||
|
||||
await flushPromises();
|
||||
|
||||
Reference in New Issue
Block a user