fix: Fix issue with media view incorrectly rejecting cameras (#2061)

For issue: #1748
This commit is contained in:
Dermot Duffy
2025-05-23 20:02:13 -07:00
committed by GitHub
parent 14cf80c7b4
commit b97e1358d0
7 changed files with 21 additions and 24 deletions
@@ -19,6 +19,7 @@ describe('FoldersManager', () => {
const api = createCardAPI();
const manager = new FoldersManager(api);
expect(manager.getFolderCount()).toBe(0);
expect(manager.hasFolders()).toBe(false);
});
describe('should add folders', () => {
@@ -32,6 +33,7 @@ describe('FoldersManager', () => {
...folder,
title: 'Folder 0',
});
expect(manager.hasFolders()).toBe(true);
});
it('should add a folder correctly with a title', () => {
@@ -128,7 +130,7 @@ describe('FoldersManager', () => {
const folder: FolderConfig = createFolder();
const query: FolderQuery = {
folder,
path: ['media-source://'],
path: [{ id: 'media-source://' }],
};
const executor = mock<FoldersExecutor>();
@@ -144,7 +146,7 @@ describe('FoldersManager', () => {
const folder: FolderConfig = createFolder();
const query: FolderQuery = {
folder,
path: ['media-source://'],
path: [{ id: 'media-source://' }],
};
const executor = mock<FoldersExecutor>();
@@ -160,7 +162,7 @@ describe('FoldersManager', () => {
const folder: FolderConfig = createFolder();
const query: FolderQuery = {
folder,
path: ['media-source://'],
path: [{ id: 'media-source://' }],
};
const executor = mock<FoldersExecutor>();
@@ -188,7 +190,7 @@ describe('FoldersManager', () => {
const engineOptions = {};
const query: FolderQuery = {
folder,
path: ['media-source://'],
path: [{ id: 'media-source://' }],
};
expect(await manager.expandFolder(query, engineOptions)).toEqual([media]);
@@ -203,7 +205,7 @@ describe('FoldersManager', () => {
const folder = createFolder({ id: 'folder-1' });
expect(
await manager.expandFolder({ folder, path: ['media-source://'] }),
await manager.expandFolder({ folder, path: [{ id: 'media-source://' }] }),
).toBeNull();
expect(executor.expandFolder).not.toBeCalled();
+2 -2
View File
@@ -20,7 +20,7 @@ describe('getViewDefault', () => {
expect(factory.getViewDefault()).toBeNull();
});
it('should return null if no cameras support view', () => {
it('should throw if no cameras support view', () => {
const api = createCardAPI();
vi.mocked(api.getConfigManager().getConfig).mockReturnValue(createConfig());
vi.mocked(api.getCameraManager).mockReturnValue(createCameraManager());
@@ -44,7 +44,7 @@ describe('getViewDefault', () => {
);
const factory = new ViewFactory(api);
expect(factory.getViewDefault()).toBeNull();
expect(() => factory.getViewDefault()).toThrowError(/No cameras support this view/);
});
it('should create view', () => {
@@ -313,7 +313,7 @@ describe('isViewSupportedByCamera', () => {
['recording' as const, false],
['recordings' as const, false],
['timeline' as const, false],
['media' as const, false],
['media' as const, true],
])('%s', (viewName: AdvancedCameraCardView, expected: boolean) => {
const api = createInitializedCardAPI();
vi.mocked(api.getCameraManager).mockReturnValue(createCameraManager());