Minor codereview fixes.

This commit is contained in:
Dermot Duffy
2022-09-25 18:14:36 -07:00
parent 046313eb47
commit ac35a5ff23
2 changed files with 6 additions and 8 deletions
+1 -1
View File
@@ -8,7 +8,7 @@ import {
TemplateResult, TemplateResult,
unsafeCSS, unsafeCSS,
} from 'lit'; } from 'lit';
import { customElement, property, state } from 'lit/decorators.js'; import { customElement, property } from 'lit/decorators.js';
import { classMap } from 'lit/directives/class-map.js'; import { classMap } from 'lit/directives/class-map.js';
import { createRef, ref, Ref } from 'lit/directives/ref.js'; import { createRef, ref, Ref } from 'lit/directives/ref.js';
import thumbnailCarouselStyle from '../scss/thumbnail-carousel.scss'; import thumbnailCarouselStyle from '../scss/thumbnail-carousel.scss';
+4 -6
View File
@@ -730,8 +730,10 @@ export class FrigateCardTimelineCore extends LitElement {
}) })
.mergeInContext(context) .mergeInContext(context)
.dispatchChangeEvent(this); .dispatchChangeEvent(this);
if (this.view.is('timeline')) {
dispatchFrigateCardEvent(this, 'thumbnails:open'); dispatchFrigateCardEvent(this, 'thumbnails:open');
} else { }
} else if (this.view.is('timeline')) {
dispatchFrigateCardEvent(this, 'thumbnails:close'); dispatchFrigateCardEvent(this, 'thumbnails:close');
} }
} }
@@ -966,7 +968,7 @@ export class FrigateCardTimelineCore extends LitElement {
} }
/** /**
* Handle timeline resize. * Get timeline options.
*/ */
protected _getOptions(): TimelineOptions | null { protected _getOptions(): TimelineOptions | null {
if (!this.timelineConfig) { if (!this.timelineConfig) {
@@ -1287,10 +1289,6 @@ export class FrigateCardTimelineCore extends LitElement {
...(window && { window: window }), ...(window && { window: window }),
}; };
this._ignoreClick = false; this._ignoreClick = false;
// if (ev.what && ['background', 'axis'].includes(ev.what)) {
// this._setTargetBarAppropriately(ev.time);
// }
}); });
this._timeline.on('mouseUp', () => { this._timeline.on('mouseUp', () => {
this._pointerHeld = null; this._pointerHeld = null;