feat: Add 'call' support to improve 2-way audio experience (#2486)
Draws significant inspiration (and direct styling) from https://github.com/dermotduffy/advanced-camera-card/pull/2447 . Thank you @Maudfer ! BREAKING CHANGE: The microphone condition previously bundled two unrelated signals — whether a two-way-audio session was connected and whether the microphone was muted. Connection state is now its own dedicated call condition, and microphone is reserved purely for mute state. Configs are upgraded automatically (the card rewrites affected conditions under overrides, elements, and automations). If you maintain config by hand, convert as follows: If you only used connected: # Before ```yaml condition: microphone connected: true ``` # After ```yaml condition: call call: true ``` If you used both connected and muted — they must be split into two conditions, since they no longer live together: # Before ```yaml condition: microphone connected: true muted: false ``` # After ```yaml condition: and conditions: - condition: call call: true - condition: microphone muted: false ```
This commit is contained in:
committed by
dermotduffy
parent
bb061a1a55
commit
abcba884e5
@@ -0,0 +1,18 @@
|
||||
import { POP_OUT_ANIMATION_NAME } from '../const.js';
|
||||
|
||||
/**
|
||||
* Whether `ev` marks the end of a pop-out (exit) animation on the element the
|
||||
* handler is bound to.
|
||||
*
|
||||
* `animationend` bubbles and `pop-out` is a shared keyframe name, so an event
|
||||
* originating on a descendant that uses the same animation is excluded by
|
||||
* requiring the animation to have run on the listening element itself.
|
||||
*/
|
||||
export function hasPopOutAnimationEnded(
|
||||
// Only the fields actually read are required, rather than a full
|
||||
// `AnimationEvent`. jsdom has no `AnimationEvent` constructor, so this lets
|
||||
// tests pass a plain object instead of mocking the event.
|
||||
ev: Pick<AnimationEvent, 'target' | 'currentTarget' | 'animationName'>,
|
||||
): boolean {
|
||||
return ev.target === ev.currentTarget && ev.animationName === POP_OUT_ANIMATION_NAME;
|
||||
}
|
||||
Reference in New Issue
Block a user