chore: Enforce a few house rules via eslint (#2539)

tests/card-controller/actions/actions/ptz.test.ts

@@ -501,7 +501,7 @@ describe('should handle ptz action', () => {
 
       // Emulate the stop being called while the action is running, but before
       // the *next* timer is scheduled.
-      let resolve: () => void;
+      let resolve: () => void = () => {};
       const promise: Promise<void> = new Promise((_resolve) => {
         resolve = _resolve;
       });
@@ -512,7 +512,7 @@ describe('should handle ptz action', () => {
 
       action.stop();
 
-      resolve!();
+      resolve();
       await vi.runOnlyPendingTimersAsync();
 
       // There should be no additional calls.

tests/card-controller/call/tones/custom.test.ts

@@ -10,13 +10,13 @@ interface AudioMocks {
 }
 
 // Uses real jsdom HTMLAudioElement instances and only stubs the parts jsdom
-// can't fulfil (`play()` / `pause()` — no audio backend). Tests then exercise
-// observable behaviour: registered listeners fire via `dispatchEvent`,
-// property writes round-trip on the element, etc.
+// can't fulfil (`play()` / `pause()` -- no audio backend). Tests then exercise
+// observable behaviour: registered listeners fire via `dispatchEvent`, property
+// writes round-trip on the element, etc.
 //
 // Called once at module load. The `beforeEach`/`afterEach` calls inside this
-// helper register Vitest hooks at the file level — Vitest picks them up just
-// as if they had been written at the top of the file — so every test in the
+// helper register Vitest hooks at the file level -- Vitest picks them up just
+// as if they had been written at the top of the file -- so every test in the
 // file gets fresh mocks installed/torn down automatically.
 const useAudioElementMocks = (): AudioMocks => {
   const handle = { instances: [] as HTMLAudioElement[] } as AudioMocks;

tests/card-controller/call/tones/test-utils.ts

@@ -5,8 +5,9 @@ import { mock, MockProxy } from 'vitest-mock-extended';
 // constructs an AudioContext directly; here we stub the global `AudioContext`
 // to return a deep-mocked instance whose `createOscillator()` / `createGain()`
 // factories return a *fresh* mock per call (not a shared one). This lets tests
-// assert against individual notes — e.g. `audio.oscillators[2].frequency.value`
-// — instead of having every call write over the same observable state.
+// assert against individual notes -- e.g.
+// `audio.oscillators[2].frequency.value` -- instead of having every call write
+// over the same observable state.
 interface AudioMocks {
   audioContext: MockProxy<AudioContext>;
   audioContextCtor: Mock<[], MockProxy<AudioContext>>;
@@ -15,7 +16,7 @@ interface AudioMocks {
   oscillators: MockProxy<OscillatorNode>[];
   gains: MockProxy<GainNode>[];
 
-  // gainParams[i] is the AudioParam exposed by `gains[i].gain` — kept as a
+  // gainParams[i] is the AudioParam exposed by `gains[i].gain` -- kept as a
   // parallel array because `mock<GainNode>()` doesn't auto-populate the
   // AudioParam interface as a callable deep mock (we wire it up by hand).
   gainParams: MockProxy<AudioParam>[];
@@ -26,9 +27,9 @@ interface AudioMocks {
 // can read its fields after each `beforeEach` runs.
 //
 // Called once at module load. The `beforeEach`/`afterEach` calls inside this
-// helper register Vitest hooks at the file level — Vitest picks them up just as
-// if they had been written at the top of the file — so every test in the file
-// gets fresh mocks installed/torn down automatically.
+// helper register Vitest hooks at the file level -- Vitest picks them up just
+// as if they had been written at the top of the file -- so every test in the
+// file gets fresh mocks installed/torn down automatically.
 export const useAudioMocks = (): AudioMocks => {
   const audio = {} as AudioMocks;
 
@@ -64,7 +65,7 @@ export const useAudioMocks = (): AudioMocks => {
 
     // The source chains `.catch(...)` on the close() Promise.
     vi.mocked(audio.audioContext.close).mockResolvedValue();
-    // The base class reads `_currentTime` from this — left as a deep-mock spy
+    // The base class reads `_currentTime` from this -- left as a deep-mock spy
     // by default it'd return a function, so anchor it at 0 for predictable
     // scheduling assertions.
     Object.defineProperty(audio.audioContext, 'currentTime', {

tests/card-controller/config/overrides-manager.test.ts

@@ -355,7 +355,7 @@ describe('OverridesManager', () => {
     it('with `invalid_type` surfacing the attempted value', () => {
       const error = runInvalidOverride((config) => {
         assert(config.overrides);
-        // @ts-expect-error — intentionally invalid runtime value to trigger
+        // @ts-expect-error -- intentionally invalid runtime value to trigger
         // Zod's `invalid_type` issue code.
         config.overrides[0].merge = 6;
       });

tests/card-controller/fullscreen/screenfull/index.test.ts

@@ -1,7 +1,7 @@
 import screenfull from 'screenfull';
-import { afterEach, describe, expect, it, vi } from 'vitest';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { ScreenfullFullScreenProvider } from '../../../../src/card-controller/fullscreen/screenfull';
-import { createCardAPI, setScreenfulEnabled } from '../../../test-utils';
+import { createCardAPI, flushPromises, setScreenfulEnabled } from '../../../test-utils';
 
 vi.mock('screenfull', () => ({
   default: {
@@ -21,6 +21,11 @@ const setScreenfulFullscreen = (fullscreen: boolean): void => {
 
 // @vitest-environment jsdom
 describe('ScreenfullFullScreenProvider', () => {
+  beforeEach(() => {
+    vi.mocked(screenfull.request).mockResolvedValue();
+    vi.mocked(screenfull.exit).mockResolvedValue();
+  });
+
   afterEach(() => {
     vi.restoreAllMocks();
   });
@@ -158,5 +163,30 @@ describe('ScreenfullFullScreenProvider', () => {
       expect(screenfull.request).not.toBeCalled();
       expect(screenfull.exit).not.toBeCalled();
     });
+
+    it('should swallow a rejected fullscreen request', async () => {
+      setScreenfulEnabled(true);
+      const api = createCardAPI();
+      const element = document.createElement('div');
+      vi.mocked(api.getCardElementManager().getElement).mockReturnValue(element);
+      vi.mocked(screenfull.request).mockRejectedValue(new Error('denied'));
+      const provider = new ScreenfullFullScreenProvider(api, vi.fn());
+
+      provider.setFullscreen(true);
+      await flushPromises();
+
+      expect(screenfull.request).toBeCalledWith(element);
+    });
+
+    it('should swallow a rejected fullscreen exit', async () => {
+      setScreenfulEnabled(true);
+      vi.mocked(screenfull.exit).mockRejectedValue(new Error('not in fullscreen'));
+      const provider = new ScreenfullFullScreenProvider(createCardAPI(), vi.fn());
+
+      provider.setFullscreen(false);
+      await flushPromises();
+
+      expect(screenfull.exit).toBeCalled();
+    });
   });
 });

tests/card-controller/fullscreen/webkit/index.test.ts

@@ -3,7 +3,11 @@ import { mock } from 'vitest-mock-extended';
 import { WebkitFullScreenProvider } from '../../../../src/card-controller/fullscreen/webkit';
 import { ConditionStateManager } from '../../../../src/condition-trigger/conditions/state-manager';
 import { MediaPlayerController, WebkitHTMLVideoElement } from '../../../../src/types';
-import { createCardAPI, createMediaLoadedInfo } from '../../../test-utils';
+import {
+  createCardAPI,
+  createMediaLoadedInfo,
+  flushPromises,
+} from '../../../test-utils';
 
 const createWebkitVideoElement = (): HTMLVideoElement &
   Partial<WebkitHTMLVideoElement> => {
@@ -242,7 +246,7 @@ describe('WebkitFullScreenProvider', () => {
     provider.connect();
 
     const element = createWebkitVideoElement();
-    element.play = vi.fn();
+    element.play = vi.fn().mockResolvedValue(undefined);
 
     const mediaPlayerController = createMediaPlayerController(element);
     vi.mocked(api.getMediaLoadedInfoManager().get).mockReturnValue(
@@ -263,4 +267,30 @@ describe('WebkitFullScreenProvider', () => {
 
     expect(element.play).toBeCalled();
   });
+
+  it('should swallow a rejected video replay after fullscreen ends', async () => {
+    const api = createCardAPI();
+    const stateManager = new ConditionStateManager();
+    vi.mocked(api.getConditionStateManager).mockReturnValue(stateManager);
+
+    const provider = new WebkitFullScreenProvider(api, vi.fn());
+    provider.connect();
+
+    const element = createWebkitVideoElement();
+    element.play = vi.fn().mockRejectedValue(new Error('denied'));
+
+    const mediaPlayerController = createMediaPlayerController(element);
+    vi.mocked(api.getMediaLoadedInfoManager().get).mockReturnValue(
+      createMediaLoadedInfo({ mediaPlayerController }),
+    );
+    stateManager.setState({
+      mediaLoadedInfo: createMediaLoadedInfo({ mediaPlayerController }),
+    });
+
+    element.dispatchEvent(new Event('webkitendfullscreen'));
+    vi.runOnlyPendingTimers();
+    await flushPromises();
+
+    expect(element.play).toBeCalled();
+  });
 });

tests/card-controller/hass/hass-manager.test.ts

@@ -145,7 +145,7 @@ describe('HASSManager', () => {
       startingHASS.config.state = STATE_STARTING;
       manager.setHASS(startingHASS);
 
-      // No reinit yet — HA isn't fully ready.
+      // No reinit yet -- HA isn't fully ready.
       expect(api.getInitializationManager().uninitialize).not.toBeCalled();
       expect(api.getCameraManager().destroy).not.toBeCalled();
 
@@ -176,7 +176,7 @@ describe('HASSManager', () => {
       startingHASS.config.state = STATE_STARTING;
       manager.setHASS(startingHASS);
 
-      // WS came back but integrations still loading — wait for RUNNING.
+      // WS came back but integrations still loading -- wait for RUNNING.
       expect(api.getInitializationManager().uninitialize).not.toBeCalled();
       expect(api.getCameraManager().destroy).not.toBeCalled();
     });
@@ -190,9 +190,9 @@ describe('HASSManager', () => {
       readyHASS.config.state = STATE_RUNNING;
       manager.setHASS(readyHASS);
 
-      // First-ever hass set — there's no "previous not-ready state" to
-      // transition from, so the normal first-load init flow applies and we
-      // must not blow away cameras.
+      // First-ever hass set -- there's no "previous not-ready state" to
+      // transition from, so the normal first-load init flow applies and we must
+      // not blow away cameras.
       expect(api.getInitializationManager().uninitialize).not.toBeCalled();
       expect(api.getCameraManager().destroy).not.toBeCalled();
     });

tests/card-controller/issues/issue-manager.test.ts

@@ -198,11 +198,11 @@ describe('IssueManager', () => {
 
       const manager = new IssueManager(api);
 
-      // hasIssue returns true from the start — simulates trigger() having
-      // already mutated state before detectDynamic snapshots. The
-      // before/after check inside detectDynamic sees true→true (no
-      // transition), but the presence comparison against ConditionState
-      // must still detect the change.
+      // hasIssue returns true from the start -- simulates trigger() having
+      // already mutated state before detectDynamic snapshots. The before/after
+      // check inside detectDynamic sees true→true (no transition), but the
+      // presence comparison against ConditionState must still detect the
+      // change.
       const description = createIssueDescription();
       const issue = createIssue('config_error', {
         hasIssue: vi.fn().mockReturnValue(true),
@@ -219,7 +219,7 @@ describe('IssueManager', () => {
       expect(api.getCardElementManager().update).toBeCalled();
     });
 
-    it('should never auto-popup on trigger — non-full-card issues surface via the status-bar icon; user clicks to open', () => {
+    it('should never auto-popup on trigger -- non-full-card issues surface via the status-bar icon; user clicks to open', () => {
       const api = createCardAPI();
       vi.mocked(api.getConditionStateManager().getState).mockReturnValue({});
 
@@ -250,8 +250,8 @@ describe('IssueManager', () => {
 
       expect(issue.retry).toBeCalled();
 
-      // Timer should have been reset — advancing less than retrySeconds
-      // should not fire it again.
+      // Timer should have been reset -- advancing less than retrySeconds should
+      // not fire it again.
       assert(issue.retry);
       vi.mocked(issue.retry).mockClear();
       vi.advanceTimersByTime(500);
@@ -312,11 +312,11 @@ describe('IssueManager', () => {
     });
 
     it('should call update when an active issue swaps sub-states without changing the key set', () => {
-      // Simulates ConnectionIssue going from 'lost' to 'starting': the
-      // presence key set ({connection}) is identical, but the description
-      // value differs. Because IssuePresence is a Map<key, description>,
-      // the condition state diff sees the value-level change and fires
-      // listeners — the IssueManager's own listener calls update().
+      // Simulates ConnectionIssue going from 'lost' to 'starting': the presence
+      // key set ({connection}) is identical, but the description value differs.
+      // Because IssuePresence is a Map<key, description>, the condition state
+      // diff sees the value-level change and fires listeners -- the
+      // IssueManager's own listener calls update().
       const api = createCardAPI();
 
       // Real ConditionStateManager so its isEqual-based diff actually runs.
@@ -638,7 +638,7 @@ describe('IssueManager', () => {
       const { manager, issue } = createRetriableSetup({ retrySeconds: 'auto' });
       manager.evaluate();
 
-      // Run two retries — second delay should be 2x the first.
+      // Run two retries -- second delay should be 2x the first.
       vi.advanceTimersByTime(RETRY_EXPONENTIAL_BASE_SECONDS * 0.75 * 1000);
       vi.advanceTimersByTime(RETRY_EXPONENTIAL_BASE_SECONDS * 2 * 0.75 * 1000);
       expect(issue.retry).toBeCalledTimes(2);
@@ -671,16 +671,16 @@ describe('IssueManager', () => {
       });
       manager.evaluate();
 
-      // Three gated firings — each at the base delay (22.5s with 0.75 jitter).
-      // If the counter were incrementing on gated fires, the second would be
-      // at 45s and we'd never reach it after only 22.5s.
+      // Three gated firings -- each at the base delay (22.5s with 0.75 jitter).
+      // If the counter were incrementing on gated fires, the second would be at
+      // 45s and we'd never reach it after only 22.5s.
       vi.advanceTimersByTime(RETRY_EXPONENTIAL_BASE_SECONDS * 0.75 * 1000);
       vi.advanceTimersByTime(RETRY_EXPONENTIAL_BASE_SECONDS * 0.75 * 1000);
       vi.advanceTimersByTime(RETRY_EXPONENTIAL_BASE_SECONDS * 0.75 * 1000);
       expect(issue.retry).not.toBeCalled();
 
-      // Clear the interaction. The next firing — still at the base delay —
-      // is now allowed and the retry runs.
+      // Clear the interaction. The next firing -- still at the base delay -- is
+      // now allowed and the retry runs.
       vi.mocked(api.getInteractionManager().hasInteraction).mockReturnValue(false);
       vi.advanceTimersByTime(RETRY_EXPONENTIAL_BASE_SECONDS * 0.75 * 1000);
       expect(issue.retry).toBeCalledTimes(1);
@@ -854,7 +854,7 @@ describe('IssueManager', () => {
       vi.mocked(api.getConditionStateManager().getState).mockReturnValue({});
 
       const manager = new IssueManager(api);
-      // Plain Issue implementation — no optional methods installed.
+      // Plain Issue implementation -- no optional methods installed.
       const issue: Issue = {
         key: 'config_error',
         hasIssue: () => false,

tests/card-controller/issues/issues/media-load.test.ts

@@ -2,9 +2,9 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { mock } from 'vitest-mock-extended';
 import { MediaLoadIssue } from '../../../../src/card-controller/issues/issues/media-load';
 import { InternalCallbackActionConfig } from '../../../../src/config/schema/actions/custom/internal';
+import { IMAGE_VIEW_TARGET_ID_SENTINEL } from '../../../../src/view/target-id';
 import { View } from '../../../../src/view/view';
 import { createCardAPI, createMediaLoadedInfo } from '../../../test-utils';
-import { IMAGE_VIEW_TARGET_ID_SENTINEL } from '../../../../src/view/target-id';
 
 const createAPI = () => createCardAPI();
 
@@ -133,7 +133,7 @@ describe('MediaLoadIssue', () => {
       vi.advanceTimersByTime(10000);
       expect(issue.hasIssue()).toBe(true);
 
-      // Same target, different media view — issue stays active.
+      // Same target, different media view -- issue stays active.
       issue.detectDynamic({ targetID: 'camera-1', view: 'clip' });
       expect(issue.hasIssue()).toBe(true);
     });
@@ -145,7 +145,7 @@ describe('MediaLoadIssue', () => {
       vi.advanceTimersByTime(10000);
       expect(issue.hasIssue()).toBe(true);
 
-      // Switch to camera-2 which has no error — should deactivate and start
+      // Switch to camera-2 which has no error -- should deactivate and start
       // a fresh timer for the new target.
       issue.detectDynamic({ targetID: 'camera-2', view: 'live' });
       expect(issue.hasIssue()).toBe(false);
@@ -164,7 +164,7 @@ describe('MediaLoadIssue', () => {
       issue.detectDynamic({ targetID: 'camera-1', view: 'live' });
       expect(issue.hasIssue()).toBe(true);
 
-      // Switch to camera-2 which also has an error — should stay active.
+      // Switch to camera-2 which also has an error -- should stay active.
       issue.detectDynamic({ targetID: 'camera-2', view: 'live' });
       expect(issue.hasIssue()).toBe(true);
     });
@@ -456,7 +456,7 @@ describe('MediaLoadIssue', () => {
 
       issue.retry();
 
-      // Issue remains active — no new 10s grace period. The error stays
+      // Issue remains active -- no new 10s grace period. The error stays
       // visible while the provider re-attempts loading underneath.
       expect(issue.hasIssue()).toBe(true);
     });
@@ -542,9 +542,9 @@ describe('MediaLoadIssue', () => {
 
       issue.retry();
 
-      // After retry, the issue stays active and the errored target is
-      // preserved — no new 10s grace period. If media:loaded fires, the
-      // existing _handleMediaLoaded path will clear everything.
+      // After retry, the issue stays active and the errored target is preserved
+      // -- no new 10s grace period. If media:loaded fires, the existing
+      // _handleMediaLoaded path will clear everything.
       expect(issue.hasIssue()).toBe(true);
       issue.detectDynamic({ targetID: 'camera-1', view: 'live' });
       expect(issue.hasIssue()).toBe(true);
@@ -579,8 +579,8 @@ describe('MediaLoadIssue', () => {
       // Card detaches: timer must stop.
       issue.suspend();
 
-      // Full 10s later (plus margin) the timer has NOT matured — the user
-      // was offscreen and that time does not count against them.
+      // Full 10s later (plus margin) the timer has NOT matured -- the user was
+      // offscreen and that time does not count against them.
       vi.advanceTimersByTime(20000);
       expect(issue.hasIssue()).toBe(false);
       expect(onChange).not.toBeCalled();
@@ -594,7 +594,7 @@ describe('MediaLoadIssue', () => {
       vi.advanceTimersByTime(10000);
       expect(issue.hasIssue()).toBe(true);
 
-      // Card detaches — issue must remain visible on reattach.
+      // Card detaches -- issue must remain visible on reattach.
       issue.suspend();
 
       expect(issue.hasIssue()).toBe(true);
@@ -609,8 +609,8 @@ describe('MediaLoadIssue', () => {
       issue.suspend();
 
       // Reattach: the manager's resume() triggers evaluate() → detectDynamic.
-      // The target is still loading, so the timer arms with a fresh 10s
-      // window — not whatever was left when we suspended.
+      // The target is still loading, so the timer arms with a fresh 10s window
+      // -- not whatever was left when we suspended.
       issue.detectDynamic({ targetID: 'camera-1', view: 'live' });
 
       vi.advanceTimersByTime(9999);

tests/card-controller/issues/state-manager.test.ts

@@ -68,6 +68,28 @@ describe('IssueStateManager', () => {
       expect(mockLegacyResource.detectStatic).toBeCalledWith(hass);
       expect(mockMediaLoad.detectStatic).toBeCalledWith(hass);
     });
+
+    it('should isolate a failing issue and continue detecting the rest', async () => {
+      const spy = vi.spyOn(console, 'warn').mockReturnValue();
+      assert(mockConfigUpgrade.detectStatic);
+      assert(mockLegacyResource.detectStatic);
+      assert(mockMediaLoad.detectStatic);
+
+      vi.mocked(mockConfigUpgrade.detectStatic).mockRejectedValue(new Error('boom'));
+
+      // A second failure, a non-Error rejection, is isolated and logged too.
+      vi.mocked(mockLegacyResource.detectStatic).mockRejectedValue('bad');
+
+      const manager = createManager();
+      const hass = createHASS();
+
+      await expect(manager.detectStatic(hass)).resolves.toBeUndefined();
+
+      // Detection continued to the final issue despite the two earlier failures.
+      expect(mockMediaLoad.detectStatic).toBeCalledWith(hass);
+      expect(spy).toBeCalledTimes(2);
+      spy.mockRestore();
+    });
   });
 
   describe('trigger', () => {

tests/card-controller/media-player-manager.test.ts

@@ -451,9 +451,9 @@ describe('MediaPlayerManager', () => {
           const api = createCardAPI();
           vi.mocked(api.getCameraManager).mockReturnValue(createCameraManager());
 
-          // Bypass schema validation — the code has a runtime guard (TypeScript
-          // narrowing) for the case where dashboard config is present but
-          // dashboard_path / view_path are missing.
+          // Bypass schema validation -- the code has a runtime guard
+          // (TypeScript narrowing) for the case where dashboard config is
+          // present but dashboard_path / view_path are missing.
           const configWithNoDashboardPaths = createCameraConfig({
             camera_entity: 'camera.foo',
           });

tests/card-controller/view/view-manager.test.ts

@@ -509,7 +509,7 @@ describe('should handle exceptions', () => {
       expect.objectContaining({ error }),
     );
 
-    // The loading flag must be cleared on error — otherwise gallery/viewer
+    // The loading flag must be cleared on error -- otherwise gallery/viewer
     // components render "Awaiting media" indefinitely on top of the error
     // notification.
     expect(manager.getView()?.context?.loading?.query).toBeUndefined();
@@ -538,9 +538,9 @@ describe('should handle exceptions', () => {
       viewQueryExecutor: viewQueryExecutor,
     });
 
-    // Concurrent reset during the await — clears `_view` before the
-    // rejection is processed. The error path must not crash on the null
-    // view when attempting to clear the loading flag.
+    // Concurrent reset during the await -- clears `_view` before the rejection
+    // is processed. The error path must not crash on the null view when
+    // attempting to clear the loading flag.
     viewQueryExecutor.getNewQueryModifiers.mockImplementation(async () => {
       manager.reset();
       throw error;