flan/advanced-camera-card
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Connect the microphone when an inbound call is *answered* (#2609) (#2612)

Browse Source 
- Closes: #2609
This commit is contained in:
Dermot Duffy authored and GitHub committed 2026-07-25 20:56:07 -07:00
1 parent 2a84f199de
commit 8f953547b1
5 files changed
+297 -88
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

docs/images/call-sequence.svg
+1 -1
View File
@@ -1 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" contentStyleType="text/css" data-diagram-type="SEQUENCE" height="998px" preserveAspectRatio="none" style="width:951px;height:998px;background:#FFFFFF;" version="1.1" viewBox="0 0 951 998" width="951px" zoomAndPan="magnify"><?plantuml 1.2026.3?><defs/><g><rect fill="none" height="110.5313" style="stroke:#000000;stroke-width:1.5;" width="888.5503" x="34" y="98.2969"/><rect fill="none" height="110.5313" style="stroke:#000000;stroke-width:1.5;" width="878.7109" x="34" y="302.2266"/><rect fill="none" height="75.3984" style="stroke:#000000;stroke-width:1.5;" width="784.6914" x="34" y="635.8203"/><g class="participant-lifeline" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-lifeline"><g><title>User</title><rect fill="#000000" fill-opacity="0.00000" height="834.8516" width="8" x="58.9551" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="62" x2="62" y1="81.2969" y2="916.1484"/></g></g><g class="participant-lifeline" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-lifeline"><g><title>Call</title><rect fill="#000000" fill-opacity="0.00000" height="834.8516" width="8" x="344.8721" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="348.8052" x2="348.8052" y1="81.2969" y2="916.1484"/></g></g><g class="participant-lifeline" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-lifeline"><g><title>Microphone</title><rect fill="#000000" fill-opacity="0.00000" height="834.8516" width="8" x="699.6738" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="702.7744" x2="702.7744" y1="81.2969" y2="916.1484"/></g></g><g class="participant-lifeline" data-entity-uid="part4" data-qualified-name="Guest" data-source-line="6" id="part4-lifeline"><g><title>Guest</title><rect fill="#000000" fill-opacity="0.00000" height="834.8516" width="8" x="781.1323" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="784.5732" x2="784.5732" y1="81.2969" y2="916.1484"/></g></g><g class="participant participant-head" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-head"><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="31.9102" x="44" y="77.9951">User</text><ellipse cx="62.9551" cy="13.5" fill="#E2E2F0" rx="8" ry="8" style="stroke:#181818;stroke-width:0.5;"/><path d="M62.9551,21.5 L62.9551,48.5 M49.9551,29.5 L75.9551,29.5 M62.9551,48.5 L49.9551,63.5 M62.9551,48.5 L75.9551,63.5" fill="none" style="stroke:#181818;stroke-width:0.5;"/></g><g class="participant participant-tail" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-tail"><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="31.9102" x="44" y="928.1436">User</text><ellipse cx="62.9551" cy="939.9453" fill="#E2E2F0" rx="8" ry="8" style="stroke:#181818;stroke-width:0.5;"/><path d="M62.9551,947.9453 L62.9551,974.9453 M49.9551,955.9453 L75.9551,955.9453 M62.9551,974.9453 L49.9551,989.9453 M62.9551,974.9453 L75.9551,989.9453" fill="none" style="stroke:#181818;stroke-width:0.5;"/></g><g class="participant participant-head" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-head"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="40.1338" x="328.8052" y="50"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="26.1338" x="335.8052" y="69.9951">Call</text></g><g class="participant participant-tail" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-tail"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="40.1338" x="328.8052" y="915.1484"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="26.1338" x="335.8052" y="935.1436">Call</text></g><g class="participant participant-head" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-head"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="95.7988" x="655.7744" y="50"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="81.7988" x="662.7744" y="69.9951">Microphone</text></g><g class="participant participant-tail" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-tail"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="95.7988" x="655.7744" y="915.1484"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="81.7988" x="662.7744" y="935.1436">Microphone</text></g><g class="participant participant-head" Line truncated
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" contentStyleType="text/css" data-diagram-type="SEQUENCE" height="1183px" preserveAspectRatio="none" style="width:949px;height:1183px;background:#FFFFFF;" version="1.1" viewBox="0 0 949 1183" width="949px" zoomAndPan="magnify"><?plantuml 1.2026.3?><defs/><g><rect fill="none" height="110.5313" style="stroke:#000000;stroke-width:1.5;" width="888.5503" x="32" y="98.2969"/><rect fill="none" height="235" style="stroke:#000000;stroke-width:1.5;" width="784.6914" x="32" y="222.8281"/><rect fill="none" height="110.5313" style="stroke:#000000;stroke-width:1.5;" width="878.7109" x="32" y="471.8281"/><rect fill="none" height="75.3984" style="stroke:#000000;stroke-width:1.5;" width="784.6914" x="32" y="820.5547"/><g class="participant-lifeline" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-lifeline"><g><title>User</title><rect fill="#000000" fill-opacity="0.00000" height="1019.5859" width="8" x="56.9551" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="60" x2="60" y1="81.2969" y2="1100.8828"/></g></g><g class="participant-lifeline" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-lifeline"><g><title>Call</title><rect fill="#000000" fill-opacity="0.00000" height="1019.5859" width="8" x="342.8721" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="346.8052" x2="346.8052" y1="81.2969" y2="1100.8828"/></g></g><g class="participant-lifeline" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-lifeline"><g><title>Microphone</title><rect fill="#000000" fill-opacity="0.00000" height="1019.5859" width="8" x="697.6738" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="700.7744" x2="700.7744" y1="81.2969" y2="1100.8828"/></g></g><g class="participant-lifeline" data-entity-uid="part4" data-qualified-name="Guest" data-source-line="6" id="part4-lifeline"><g><title>Guest</title><rect fill="#000000" fill-opacity="0.00000" height="1019.5859" width="8" x="779.1323" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="782.5732" x2="782.5732" y1="81.2969" y2="1100.8828"/></g></g><g class="participant participant-head" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-head"><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="31.9102" x="42" y="77.9951">User</text><ellipse cx="60.9551" cy="13.5" fill="#E2E2F0" rx="8" ry="8" style="stroke:#181818;stroke-width:0.5;"/><path d="M60.9551,21.5 L60.9551,48.5 M47.9551,29.5 L73.9551,29.5 M60.9551,48.5 L47.9551,63.5 M60.9551,48.5 L73.9551,63.5" fill="none" style="stroke:#181818;stroke-width:0.5;"/></g><g class="participant participant-tail" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-tail"><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="31.9102" x="42" y="1112.8779">User</text><ellipse cx="60.9551" cy="1124.6797" fill="#E2E2F0" rx="8" ry="8" style="stroke:#181818;stroke-width:0.5;"/><path d="M60.9551,1132.6797 L60.9551,1159.6797 M47.9551,1140.6797 L73.9551,1140.6797 M60.9551,1159.6797 L47.9551,1174.6797 M60.9551,1159.6797 L73.9551,1174.6797" fill="none" style="stroke:#181818;stroke-width:0.5;"/></g><g class="participant participant-head" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-head"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="40.1338" x="326.8052" y="50"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="26.1338" x="333.8052" y="69.9951">Call</text></g><g class="participant participant-tail" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-tail"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="40.1338" x="326.8052" y="1099.8828"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="26.1338" x="333.8052" y="1119.8779">Call</text></g><g class="participant participant-head" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-head"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="95.7988" x="653.7744" y="50"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="81.7988" x="660.7744" y="69.9951">Microphone</text></g><g class="participant participant-tail" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-tail"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="95.7988" x="653.7744" y="1099.8828"/><text fill="#000000" font-family="sans-serif" font-size="1Line truncated
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 23 KiB

After

Width:  |  Height:  |  Size: 27 KiB

docs/uml/call-sequence.puml
+18 -7
View File
@@ -12,11 +12,21 @@ opt <color:#43a047>**""live.microphone.always_connected""**</color> is enabled
Mic --> User : Microphone access granted
end
User -> Card : Start a call
note over User, Card
Via Call menu button or <color:#43a047>**""call_start""**</color> action.
Needs a camera that supports 2-way audio
end note
alt Outbound call
User -> Card : Start a call
note over User, Card
Via Call menu button or <color:#43a047>**""call_start""**</color> action.
Needs a camera that supports 2-way audio
end note
else Inbound call
Guest -> Card : Rings
note over Card
Via a <color:#43a047>**""view.triggers.actions.trigger: call""**</color> trigger, e.g. a doorbell.
The card rings (<color:#43a047>**""live.controls.call.ringtone""**</color>) until answered,
rejected, or <color:#43a047>**""live.controls.call.unanswered_timeout_seconds""**</color> elapses
end note
User -> Card : Answer the call
end
opt <color:#43a047>**""live.microphone.always_connected""**</color> not enabled
Card -> Mic : Microphone connection attempted (muted)
@@ -25,8 +35,9 @@ opt <color:#43a047>**""live.microphone.always_connected""**</color> not enabled
end
note over User, Mic
The microphone must connect for the call to proceed --
if access is denied or unsupported, the call does not start
The microphone is connected when the call is answered -- immediately
for an outbound call. An inbound call rings without it, so a doorbell
can ring even where microphone access needs a tap to be granted
end note
Card --> User : You hear the caller