fix: Download recordings with a video file extension (#2712)

- Closes: #2711

src/card-controller/view/item-manager.ts

@@ -128,7 +128,7 @@ export class ViewItemManager {
         (cameraID ? toFilename(cameraID) : 'media') +
         (id ? `_${toFilename(id)}` : '') +
         (startTime ? `_${format(startTime, `yyyy-MM-dd-HH-mm-ss`)}` : '') +
-        ('.' + (item.getMediaType() === 'clip' ? 'mp4' : 'jpg'))
+        ('.' + (ViewItemClassifier.isVideo(item) ? 'mp4' : 'jpg'))
       );
     }
 

tests/card-controller/view/item-manager.test.ts

@@ -238,6 +238,22 @@ describe('ViewItemManager', () => {
         expect(downloadURL).toHaveBeenCalledWith('foo', 'camera_id.jpg');
       });
 
+      it('should generate filename for recording', async () => {
+        const api = createCardAPI();
+        vi.mocked(api.getHASSManager().getHASS).mockReturnValue(createHASS());
+
+        const manager = new ViewItemManager(api);
+        const item = new TestViewMedia({ mediaType: ViewMediaType.Recording });
+
+        vi.mocked(api.getCameraManager().getMediaDownloadPath).mockResolvedValue({
+          sign: false,
+          endpoint: 'foo',
+        });
+
+        expect(await manager.download(item)).toBe(true);
+        expect(downloadURL).toHaveBeenCalledWith('foo', 'camera_id.mp4');
+      });
+
       it('should generate filename for folder without title', async () => {
         const api = createCardAPI();
         vi.mocked(api.getHASSManager().getHASS).mockReturnValue(createHASS());