flan/advanced-camera-card
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Sort TODO list.

Browse Source
This commit is contained in:
Dermot Duffy
2023-01-24 19:36:54 -08:00
parent 66ee65f8cc
commit 6415597e9b
1 changed files with 27 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/view.ts
+27 -26
View File
@@ -1,29 +1,30 @@
// TODO: Implement gallery. // Easy:
// TODO: Improve data storage in data-manager to allow fetching by limit not time. // - TODO: Search for references to frigate.js and see where it's being called outside of the dataManager. Can I collapse some of those functions in?
// TODO: Live should get most recent events regardless of when they were. // - TODO: Refactor thumbnailsControlSchema to all use the shortform for other thumbnail users beyond live.
// TODO: Refactor thumbnailsControlSchema to all use the shortform for other thumbnail users beyond live. // - TODO: limit param in recordings should do something
// TODO: Should be able to set live media to 'all' and have it work. // - TODO: Should be able to set live media to 'all' and have it work.
// TODO: If I replace the indexdb backend with just a map / array, does it work? Might be better. // - TODO: Are there elements of ViewMedia (e.g. getEventCount) that should be moved into subclasses (e.g. a recording subclass).
// TODO: limit param in recordings should do something // - TODO: In MediaQueriesBase, do we need to generic? Just have T be a MediaQuery?
// TODO: Callers of all async methods of data-engine need to catch errors. // - TODO: Are areEventQueries and areRecordingQueries should be in a classifier to keep with the pattern used elsewhere.
// TODO: Search for references to frigate.js and see where it's being called outside of the dataManager. Can I collapse some of those functions in? // - TODO: Callers to the creation of new views for events/recordings need to dispatch events themselves when none are found.
// TODO: Are there elements of ViewMedia (e.g. getEventCount) that should be moved into subclasses (e.g. a recording subclass). // - TODO: In the viewer @click handlers should I use this.selected instead of calling carouselScrollPrevious()
// TODO: ts-prune https://camchenry.com/blog/deleting-dead-code-in-typescript // - TODO: Can _timelineClickHandler be an async method in timeline-core to improve cleanliness?
// TODO: In MediaQueriesBase, do we need to generic? Just have T be a MediaQuery? // - TODO: Can _timelineRangeChangedHandler be an async method in timeline-core to improve cleanliness?
// TODO: Are areEventQueries and areRecordingQueries should be in a classifier to keep with the pattern used elsewhere.
// TODO: Callers to the creation of new views for events/recordings need to dispatch events themselves when none are found. // Medium:
// TODO: Examine how much of utils/frigate.ts can be moved into the Frigate data engine. // - TODO: Callers of all async methods of data-engine need to catch errors.
// TODO: Add garbage collecting of segments not present in the recording summaries anymore. // - TODO: Add garbage collecting of segments not present in the recording summaries anymore.
// TODO: Do I need to dedup recordings? (i.e. multiple zones on same camera may need to be dedup'd somewhere before returning the view). The media getID() call may be useful for this. // - TODO: Do I need to dedup recordings? (i.e. multiple zones on same camera may need to be dedup'd somewhere before returning the view). The media getID() call may be useful for this.
// TODO: Verify that scrolling the timeline will seek forward in both Frigate recordings & events. // - TODO: Do a fresh media query in the viewer on snapshot click, since the first query may (e.g.) only have requested events with snapshots (which would miss an event with just a clip).
// TODO: In generateMediaViewerContext there is an assumption that recordings start/end on the hour, which is true for Frigate but that assumption should be in the engine. // - TODO: ts-prune https://camchenry.com/blog/deleting-dead-code-in-typescript
// TODO: Do a fresh media query in the viewer on snapshot click, since the first query may (e.g.) only have requested events with snapshots (which would miss an event with just a clip).
// TODO: In the viewer @click handlers should I use this.selected instead of calling carouselScrollPrevious() // Hard:
// TODO: Implement seeking when the timeline is dragged. // - TODO: Implement dragging the timeline seeking forward in both Frigate recordings & events.
// TODO: Can _timelineClickHandler be an async method in timeline-core to improve cleanliness? // - TODO: Implement gallery.
// TODO: Can _timelineRangeChangedHandler be an async method in timeline-core to improve cleanliness? // - TODO: In generateMediaViewerContext there is an assumption that recordings start/end on the hour, which is true for Frigate but that assumption should be in the engine.
// TODO: What should the timeline do when an event is clicked on that is not in the queryResults (or if queryResults is empty)? // - TODO: What should the timeline do when an event is clicked on that is not in the queryResults (or if queryResults is empty)?
// TODO: Should the timeline data source clear events (as it currently does) when the query changes? // - TODO: Should the timeline data source clear events (as it currently does) when the query changes?
import isEqual from 'lodash-es/isEqual'; import isEqual from 'lodash-es/isEqual';
import clone from 'lodash-es/clone.js'; import clone from 'lodash-es/clone.js';