flan/advanced-camera-card
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Fix z-index rendering issue when card is expanded (#2274)

Browse Source 
- Closes #2155
This commit is contained in:
Dermot Duffy
2025-12-09 23:45:07 -08:00
committed by GitHub
parent 252ead62dc
commit 639c5c3e4b
4 changed files with 51 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/card-controller/expand-manager.test.ts
+39 -1
View File
@@ -1,7 +1,8 @@
import { describe, expect, it, vi } from 'vitest';
import { ExpandManager } from '../../src/card-controller/expand-manager';
import { createCardAPI } from '../test-utils';
import { createCardAPI, createLitElement } from '../test-utils';
// @vitest-environment jsdom
describe('ExpandManager', () => {
it('should construct', () => {
const api = createCardAPI();
@@ -19,6 +20,8 @@ describe('ExpandManager', () => {
it('should set expanded', () => {
const api = createCardAPI();
const element = createLitElement();
vi.mocked(api.getCardElementManager().getElement).mockReturnValue(element);
vi.mocked(api.getFullscreenManager().isInFullscreen).mockReturnValue(true);
const manager = new ExpandManager(api);
@@ -28,10 +31,13 @@ describe('ExpandManager', () => {
expect(api.getFullscreenManager().setFullscreen).toBeCalledWith(false);
expect(api.getConditionStateManager().setState).toBeCalledWith({ expand: true });
expect(api.getCardElementManager().update).toBeCalled();
expect(element.hasAttribute('expanded')).toBeTruthy();
});
it('should not exit fullscreen when not in fullscreen', () => {
const api = createCardAPI();
const element = createLitElement();
vi.mocked(api.getCardElementManager().getElement).mockReturnValue(element);
vi.mocked(api.getFullscreenManager().isInFullscreen).mockReturnValue(false);
const manager = new ExpandManager(api);
@@ -42,13 +48,45 @@ describe('ExpandManager', () => {
it('should toggle expanded', () => {
const api = createCardAPI();
const element = createLitElement();
vi.mocked(api.getCardElementManager().getElement).mockReturnValue(element);
vi.mocked(api.getFullscreenManager().isInFullscreen).mockReturnValue(false);
const manager = new ExpandManager(api);
manager.toggleExpanded();
expect(manager.isExpanded()).toBeTruthy();
expect(element.hasAttribute('expanded')).toBeTruthy();
manager.toggleExpanded();
expect(manager.isExpanded()).toBeFalsy();
expect(element.hasAttribute('expanded')).toBeFalsy();
});
it('should set expanded attribute on card element when expanded', () => {
const api = createCardAPI();
const element = createLitElement();
vi.mocked(api.getCardElementManager().getElement).mockReturnValue(element);
vi.mocked(api.getFullscreenManager().isInFullscreen).mockReturnValue(false);
const manager = new ExpandManager(api);
expect(element.hasAttribute('expanded')).toBeFalsy();
manager.setExpanded(true);
expect(element.hasAttribute('expanded')).toBeTruthy();
});
it('should remove expanded attribute on card element when collapsed', () => {
const api = createCardAPI();
const element = createLitElement();
vi.mocked(api.getCardElementManager().getElement).mockReturnValue(element);
vi.mocked(api.getFullscreenManager().isInFullscreen).mockReturnValue(false);
const manager = new ExpandManager(api);
manager.setExpanded(true);
expect(element.hasAttribute('expanded')).toBeTruthy();
manager.setExpanded(false);
expect(element.hasAttribute('expanded')).toBeFalsy();
});
});