fix: Honor configured home preset / merge presets. (#2553)

- Closes:
https://github.com/dermotduffy/advanced-camera-card/issues/2525
This commit is contained in:
Dermot Duffy
2026-06-30 17:45:13 -07:00
committed by dermotduffy
parent d833edb65b
commit 5c97e55a56
8 changed files with 243 additions and 10 deletions
@@ -507,6 +507,47 @@ describe('ReolinkCamera', () => {
zoomOut: ['continuous'],
});
});
it('should union configured presets with detected presets', async () => {
const config = createCameraConfig({
camera_entity: 'camera.office_reolink',
ptz: {
presets: {
home: {
action: 'perform-action',
perform_action: 'button.press',
target: { entity_id: 'button.office_guard' },
},
},
},
});
const camera = new ReolinkCamera(config, mock<CameraManagerEngine>());
await camera.initialize({
hassManager: createHASSManager({
hass: createHASS({
'select.office_reolink_ptz_preset': createStateEntity({
state: 'foo',
attributes: {
options: ['preset-one', 'preset-two'],
},
}),
}),
}),
entityRegistryManager: ptzPopulatedEntityRegistryManager,
deviceRegistryManager: mock<DeviceRegistryManager>(),
});
expect(camera.getCapabilities()?.getPTZCapabilities()).toEqual({
left: ['continuous'],
right: ['continuous'],
up: ['continuous'],
down: ['continuous'],
zoomIn: ['continuous'],
zoomOut: ['continuous'],
presets: ['home', 'preset-one', 'preset-two'],
});
});
});
});
+63
View File
@@ -4,8 +4,10 @@ import {
getConfiguredPTZAction,
getConfiguredPTZMovementType,
getPTZCapabilitiesFromCameraConfig,
mergePTZCapabilities,
} from '../../../src/camera-manager/utils/ptz';
import type { PTZAction } from '../../../src/config/schema/actions/custom/ptz';
import { PTZMovementType } from '../../../src/types';
import { createCameraConfig } from '../../test-utils';
const action = {
@@ -186,3 +188,64 @@ describe('getPTZCapabilitiesFromCameraConfig', () => {
});
});
});
describe('mergePTZCapabilities', () => {
it('should return null when both are null', () => {
expect(mergePTZCapabilities(null, null)).toBeNull();
});
it('should return engine capabilities when no config capabilities', () => {
expect(
mergePTZCapabilities(
{ left: [PTZMovementType.Continuous], presets: ['Staw', 'Piwnica'] },
null,
),
).toEqual({
left: [PTZMovementType.Continuous],
presets: ['Staw', 'Piwnica'],
});
});
it('should return config capabilities when no engine capabilities', () => {
expect(mergePTZCapabilities(null, { presets: ['home'] })).toEqual({
presets: ['home'],
});
});
it('should union presets with configured presets first', () => {
expect(
mergePTZCapabilities(
{ left: [PTZMovementType.Continuous], presets: ['Staw', 'Piwnica'] },
{ presets: ['home'] },
),
).toEqual({
left: [PTZMovementType.Continuous],
presets: ['home', 'Staw', 'Piwnica'],
});
});
it('should not duplicate presets present in both sources', () => {
expect(
mergePTZCapabilities({ presets: ['home', 'Staw'] }, { presets: ['home'] }),
).toEqual({
presets: ['home', 'Staw'],
});
});
it('should let configured movement actions override engine equivalents', () => {
expect(
mergePTZCapabilities(
{ left: [PTZMovementType.Continuous] },
{ left: [PTZMovementType.Relative] },
),
).toEqual({
left: [PTZMovementType.Relative],
});
});
it('should omit presets when neither source has any', () => {
expect(mergePTZCapabilities({ left: [PTZMovementType.Continuous] }, null)).toEqual({
left: [PTZMovementType.Continuous],
});
});
});