fix: Improve reliability of connection cleanup (#2009)

- Closes #1992
This commit is contained in:
Dermot Duffy
2025-04-14 16:58:17 +01:00
committed by GitHub
parent da17c689b8
commit 54ee1e1cf3
7 changed files with 25 additions and 3 deletions
+1
View File
@@ -301,6 +301,7 @@ export class AdvancedCameraCardElementsConditional extends LitElement {
disconnectedCallback(): void {
this._conditionManager?.destroy();
super.disconnectedCallback();
}
protected _createConditionManager(): void {
+1
View File
@@ -128,6 +128,7 @@ export class AdvancedCameraCardLiveProvider extends LitElement implements MediaP
public disconnectedCallback(): void {
this._isVideoMediaLoaded = false;
super.disconnectedCallback();
}
protected _videoMediaShowHandler(): void {
@@ -68,6 +68,7 @@ export class AdvancedCameraCardGo2RTC extends LitElement implements MediaPlayer
disconnectedCallback(): void {
this._player = undefined;
this._message = null;
super.disconnectedCallback();
}
connectedCallback(): void {
+1 -1
View File
@@ -30,7 +30,6 @@ export class AdvancedCameraCardSurroundBasic extends LitElement {
}
disconnectedCallback(): void {
super.disconnectedCallback();
this.removeEventListener(
'advanced-camera-card:drawer:open',
this._boundDrawerHandler,
@@ -39,6 +38,7 @@ export class AdvancedCameraCardSurroundBasic extends LitElement {
'advanced-camera-card:drawer:close',
this._boundDrawerHandler,
);
super.disconnectedCallback();
}
protected _drawerHandler(ev: Event) {
+2 -2
View File
@@ -64,16 +64,16 @@ export class AdvancedCameraCardThumbnailFeatureThumbnail extends LitElement {
* Component connected callback.
*/
connectedCallback(): void {
this._intersectionObserver.observe(this);
super.connectedCallback();
this._intersectionObserver.observe(this);
}
/**
* Component disconnected callback.
*/
disconnectedCallback(): void {
super.disconnectedCallback();
this._intersectionObserver.disconnect();
super.disconnectedCallback();
}
protected willUpdate(changedProps: PropertyValues): void {
+1
View File
@@ -40,6 +40,7 @@ export class AdvancedCameraCardZoomer extends LitElement {
this._zoom?.deactivate();
this.removeEventListener('advanced-camera-card:zoom:zoomed', this._zoomHandler);
this.removeEventListener('advanced-camera-card:zoom:unzoomed', this._unzoomHandler);
super.disconnectedCallback();
}
protected willUpdate(changedProps: PropertyValues): void {