From 54a4dd854fa28ffef0caf07120f7866f952e9a97 Mon Sep 17 00:00:00 2001
From: Dermot Duffy <dermot.duffy@gmail.com>
Date: Sun, 8 Jan 2023 15:41:20 -0800
Subject: [PATCH] Don't pass cameraConfig in with favouriteMedia request.

---
 src/camera/manager.ts       | 5 ++++-
 src/components/thumbnail.ts | 3 +--
 src/view/view.ts            | 1 -
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/camera/manager.ts b/src/camera/manager.ts
index 61f16d3b..1cbddacd 100644
--- a/src/camera/manager.ts
+++ b/src/camera/manager.ts
@@ -236,10 +236,13 @@ export class CameraManager {
 
   public async favoriteMedia(
     hass: HomeAssistant,
-    cameraConfig: CameraConfig,
     media: ViewMedia,
     favorite: boolean,
   ): Promise<void> {
+    const cameraConfig = this._cameras.get(media.getCameraID());
+    if (!cameraConfig) {
+      return;
+    }
     const engine = this._engineFactory.getEngineForCamera(cameraConfig);
     if (engine) {
       const queryStartTime = new Date();
diff --git a/src/components/thumbnail.ts b/src/components/thumbnail.ts
index a116a90e..f7b3aeee 100644
--- a/src/components/thumbnail.ts
+++ b/src/components/thumbnail.ts
@@ -296,11 +296,10 @@ export class FrigateCardThumbnail extends LitElement {
             title=${localize('thumbnail.retain_indefinitely')}
             @click=${async (ev: Event) => {
               stopEventFromActivatingCardWideActions(ev);
-              if (this.hass && this.cameraConfig && this.media) {
+              if (this.hass && this.media) {
                 try {
                   await this.cameraManager?.favoriteMedia(
                     this.hass,
-                    this.cameraConfig,
                     this.media,
                     !this.media?.isFavorite(),
                   );
diff --git a/src/view/view.ts b/src/view/view.ts
index 9411f86c..10e41f5d 100644
--- a/src/view/view.ts
+++ b/src/view/view.ts
@@ -2,7 +2,6 @@
 //  - TODO: Add garbage collecting of segments not present in the recording summaries anymore.
 //  - TODO: Move frigate specific view-media under the camera manager.
 //  - TODO: ts-prune https://camchenry.com/blog/deleting-dead-code-in-typescript
-//  - TODO: Engine should not need cameraConfig to favorite since it already has cameras.
 
 // Hard:
 //  - TODO: Implement dragging the timeline seeking forward in both Frigate recordings & events.