flan/advanced-camera-card
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Use toggleAttribute natively where possible (#2494)

Browse Source
This commit is contained in:
Dermot Duffy
2026-06-30 17:45:13 -07:00
committed by dermotduffy
parent 2acec49b29
commit 48761f0478
13 changed files with 37 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components-lib/status-bar-controller.test.ts
+7 -8
View File
@@ -4,7 +4,6 @@ import {
StatusBarConfig,
statusBarConfigSchema,
} from '../../src/config/schema/status-bar';
import { setOrRemoveAttribute } from '../../src/utils/basic';
import { createInteractionActionEvent, createLitElement } from '../test-utils';
const createConfig = (config?: unknown): StatusBarConfig => {
@@ -35,7 +34,7 @@ describe('StatusBarController', () => {
it('should not hide when not in popup style', () => {
const host = createLitElement();
setOrRemoveAttribute(host, true, 'hide');
host.toggleAttribute('hide', true);
const controller = new StatusBarController(host);
@@ -52,7 +51,7 @@ describe('StatusBarController', () => {
it('should not show when in popup style', () => {
const host = createLitElement();
setOrRemoveAttribute(host, true, 'hide');
host.toggleAttribute('hide', true);
const controller = new StatusBarController(host);
@@ -181,7 +180,7 @@ describe('StatusBarController', () => {
describe('should deal with popup styles correctly', () => {
it('should show from empty to sufficient', () => {
const host = createLitElement();
setOrRemoveAttribute(host, true, 'hide');
host.toggleAttribute('hide', true);
const controller = new StatusBarController(host);
controller.setConfig(
@@ -203,7 +202,7 @@ describe('StatusBarController', () => {
it('should not show from empty to insufficient', () => {
const host = createLitElement();
setOrRemoveAttribute(host, true, 'hide');
host.toggleAttribute('hide', true);
const controller = new StatusBarController(host);
controller.setConfig(
@@ -255,13 +254,13 @@ describe('StatusBarController', () => {
controller.setItems([sufficientString]);
// Emulate the popup being hidden.
setOrRemoveAttribute(host, true, 'hide');
host.toggleAttribute('hide', true);
controller.setItems([sufficientIcon]);
expect(host.getAttribute('hide')).toBe(null);
// Emulate the popup being hidden.
setOrRemoveAttribute(host, true, 'hide');
host.toggleAttribute('hide', true);
controller.setItems([sufficientImage]);
expect(host.getAttribute('hide')).toBe(null);
@@ -269,7 +268,7 @@ describe('StatusBarController', () => {
it('should not start popup timer when permanent items are present', () => {
const host = createLitElement();
setOrRemoveAttribute(host, true, 'hide');
host.toggleAttribute('hide', true);
const controller = new StatusBarController(host);
controller.setConfig(