flan/advanced-camera-card
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: Various minor timeline performance improvements (#1952)

Browse Source 
- Closes #1930
This commit is contained in:
Dermot Duffy
2025-03-08 17:31:25 -08:00
committed by GitHub
parent dbd47c93c1
commit 480c3d0ab7
4 changed files with 211 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/view/media-queries-results.test.ts
+2
View File
@@ -30,9 +30,11 @@ describe('dispatchViewContextChangeEvent', () => {
expect(results.selectIndex(0)).toEqual(results);
expect(results.getSelectedResult()).toBeNull();
// eslint-disable-next-line @typescript-eslint/no-unused-vars
expect(results.selectResultIfFound((_media: ViewMedia) => true)).toEqual(results);
expect(results.getSelectedResult()).toBeNull();
// eslint-disable-next-line @typescript-eslint/no-unused-vars
expect(results.selectBestResult((_media: ViewMedia[]) => null)).toEqual(results);
expect(results.getSelectedResult()).toBeNull();
expect(results.getMultipleSelectedResults()).toEqual([]);
tests/view/media-queries.test.ts
+164
View File
@@ -96,6 +96,170 @@ describe('EventMediaQueries', () => {
newCameraIDs,
);
});
describe('should determine when queries are a superset', () => {
it('should return true with itself', () => {
const queries_1 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
expect(queries_1.isSupersetOf(queries_1)).toBeTruthy();
});
it('should return true with an identical but shorter query', () => {
const queries_1 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
const queries_2 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T01:00:00.000Z'),
end: new Date('2025-03-07T23:00:00.000Z'),
},
]);
expect(queries_1.isSupersetOf(queries_2)).toBeTruthy();
});
it('should return false with an identical but longer query', () => {
const queries_1 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
const queries_2 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-06T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
expect(queries_1.isSupersetOf(queries_2)).toBeFalsy();
});
it('should return false with a non-matching query', () => {
const queries_1 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
const queries_2 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['DIFFERENT']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
expect(queries_1.isSupersetOf(queries_2)).toBeFalsy();
});
it('should return true with a matching query where the source has multiple', () => {
const queries_1 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
{
type: QueryType.Event,
cameraIDs: new Set(['kitchen']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
const queries_2 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
expect(queries_1.isSupersetOf(queries_2)).toBeTruthy();
});
it('should return false with a matching query where the target has multiple', () => {
const queries_1 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
const queries_2 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
{
type: QueryType.Event,
cameraIDs: new Set(['kitchen']),
start: new Date('2025-03-07T00:00:00.000Z'),
end: new Date('2025-03-08T00:00:00.000Z'),
},
]);
expect(queries_1.isSupersetOf(queries_2)).toBeFalsy();
});
it('should return true when queries do not have start or end', () => {
const queries_1 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
},
]);
const queries_2 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
},
]);
expect(queries_1.isSupersetOf(queries_2)).toBeTruthy();
});
it('should return true when target has no queries', () => {
const queries_1 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
},
]);
const queries_2 = new EventMediaQueries();
expect(queries_1.isSupersetOf(queries_2)).toBeTruthy();
});
it('should return false when source has no queries', () => {
const queries_1 = new EventMediaQueries();
const queries_2 = new EventMediaQueries([
{
type: QueryType.Event,
cameraIDs: new Set(['office']),
},
]);
expect(queries_1.isSupersetOf(queries_2)).toBeFalsy();
});
});
});
describe('RecordingMediaQueries', () => {