From 9a71440ca15cd0201e52060b720b8bf447947916 Mon Sep 17 00:00:00 2001 From: Dermot Duffy Date: Sun, 8 May 2022 17:24:47 -0700 Subject: [PATCH 1/2] Don't use deprecated keyCode --- src/action-handler-directive.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/action-handler-directive.ts b/src/action-handler-directive.ts index cd2d1c3a..827a1a19 100644 --- a/src/action-handler-directive.ts +++ b/src/action-handler-directive.ts @@ -142,10 +142,9 @@ class ActionHandler extends HTMLElement implements ActionHandler { }; const handleEnter = (ev: KeyboardEvent): void => { - if (ev.keyCode !== 13) { - return; + if (ev.key === 'Enter') { + end(ev); } - end(ev); }; element.addEventListener('touchstart', start, { passive: true }); From 221ce96c7e39fe5ed6c5afd81ec5a25be1c427de Mon Sep 17 00:00:00 2001 From: Dermot Duffy Date: Sun, 8 May 2022 17:25:57 -0700 Subject: [PATCH 2/2] Add comment. --- src/action-handler-directive.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/action-handler-directive.ts b/src/action-handler-directive.ts index 827a1a19..25fcd421 100644 --- a/src/action-handler-directive.ts +++ b/src/action-handler-directive.ts @@ -152,9 +152,11 @@ class ActionHandler extends HTMLElement implements ActionHandler { element.addEventListener('touchcancel', end); element.addEventListener('mousedown', start, { passive: true }); - element.addEventListener('pointerdown', start, { passive: true }); element.addEventListener('click', end); + // For the timeline which generates native pointer events. + element.addEventListener('pointerdown', start, { passive: true }); + element.addEventListener('keyup', handleEnter); } }