refactor: Clone context when a view is cloned (#2493)

src/card-controller/call/manager.ts

@@ -1,4 +1,3 @@
-import { cloneDeep } from 'lodash-es';
 import { createNotificationFromText } from '../../components-lib/notification/factory';
 import { ConditionStateChange } from '../../conditions/types';
 import { localize } from '../../localize/localize';
@@ -88,12 +87,10 @@ export class CallManager {
 
     // Store the previous view so it can be restored later. A call superseding
     // another inherits the earlier call's previous view -- the user never left
-    // the call. `queryResults` are dropped (re-fetched fresh on restore);
-    // `context` is deep-cloned so the call engaging its own substream below
-    // cannot mutate the snapshot.
+    // the call. `queryResults` are dropped (re-fetched fresh on restore).
     const previousView = existingCall
       ? existingCall.previousView
-      : view.evolve({ queryResults: null, context: cloneDeep(view.context) });
+      : view.evolve({ queryResults: null });
 
     const needsNavigation = !view.is('live') || view.camera !== parentID;
 

src/components/viewer/carousel.ts

@@ -383,8 +383,10 @@ export class AdvancedCameraCardViewerCarousel extends LitElement {
       // on media load, since the media may or may not have been loaded at
       // this point).
       if (
-        this.viewManagerEpoch?.manager.getView()?.context?.mediaViewer !==
-        this.viewManagerEpoch?.oldView?.context?.mediaViewer
+        this.viewManagerEpoch?.manager
+          .getView()
+          ?.context?.mediaViewer?.seek?.getTime() !==
+        this.viewManagerEpoch?.oldView?.context?.mediaViewer?.seek?.getTime()
       ) {
         this._seekHandler();
       }

src/view/view.ts

@@ -1,4 +1,4 @@
-import { merge } from 'lodash-es';
+import { cloneDeep, merge } from 'lodash-es';
 import { ViewContext } from 'view';
 import { AdvancedCameraCardView } from '../config/schema/common/const';
 import { ViewDisplayMode } from '../config/schema/common/display';
@@ -95,7 +95,7 @@ export class View {
       camera: this.camera,
       query: this.query?.clone() ?? null,
       queryResults: this.queryResults?.clone() ?? null,
-      context: this.context,
+      context: cloneDeep(this.context),
       displayMode: this.displayMode,
     });
   }
@@ -114,7 +114,7 @@ export class View {
         params.queryResults !== undefined
           ? params.queryResults
           : this.queryResults?.clone() ?? null,
-      context: params.context !== undefined ? params.context : this.context,
+      context: params.context !== undefined ? params.context : cloneDeep(this.context),
       displayMode:
         params.displayMode !== undefined ? params.displayMode : this.displayMode,
     });