fix: Untriggering to default should reset to default camera (#1571)

This commit is contained in:
Dermot Duffy
2024-09-22 16:00:08 -07:00
committed by GitHub
parent 766f3422a9
commit 299d21acab
2 changed files with 65 additions and 14 deletions
+45 -4
View File
@@ -27,6 +27,33 @@ describe('getViewDefault', () => {
expect(factory.getViewDefault()).toBeNull();
});
it('should return null if no cameras support view', () => {
const api = createCardAPI();
vi.mocked(api.getConfigManager().getConfig).mockReturnValue(createConfig());
vi.mocked(api.getCameraManager).mockReturnValue(createCameraManager());
// No cameras support live.
vi.mocked(api.getCameraManager().getStore).mockReturnValue(
createStore([
{
cameraID: 'camera.office',
capabilities: createCapabilities({
live: false,
}),
},
{
cameraID: 'camera.kitchen',
capabilities: createCapabilities({
live: false,
}),
},
]),
);
const factory = new ViewFactory(api);
expect(factory.getViewDefault()).toBeNull();
});
it('should create view', () => {
const factory = new ViewFactory(createPopulatedAPI());
const view = factory.getViewDefault();
@@ -64,17 +91,31 @@ describe('getViewDefault', () => {
expect(view?.camera).toBe('camera.office');
});
it('should respect parameters', () => {
it('should use default camera when camera unspecified', () => {
// Even though baseView has a camera, since default is called it should
// use that camera.
const factory = new ViewFactory(createPopulatedAPI());
const baseView = createView({ camera: 'camera.kitchen' });
const view = factory.getViewDefault({
params: {
camera: 'camera.office',
},
baseView: baseView,
});
expect(view?.is('live')).toBeTruthy();
expect(view?.camera).toBe('camera.office');
});
it('should respect parameters', () => {
const factory = new ViewFactory(createPopulatedAPI());
const view = factory.getViewDefault({
params: {
camera: 'camera.kitchen',
},
});
expect(view?.is('live')).toBeTruthy();
expect(view?.camera).toBe('camera.kitchen');
});
});
describe('getViewByParameters', () => {