fix: Fix styling and severity in status bar (#2352)

This commit is contained in:
Dermot Duffy
2026-02-16 13:57:45 -08:00
committed by GitHub
parent 47880e4306
commit 282983cbba
3 changed files with 48 additions and 21 deletions
@@ -48,7 +48,9 @@ export class StatusBarItemManager {
: null; : null;
const engineIcon = cameraMetadata?.engineIcon ?? null; const engineIcon = cameraMetadata?.engineIcon ?? null;
const selectedResult = options?.view?.queryResults?.getSelectedResult(); const selectedResult = options?.view?.queryResults?.getSelectedResult();
const severity = selectedResult?.getSeverity() ?? null; const severity = options?.view?.isViewerView()
? selectedResult?.getSeverity() ?? null
: null;
const title = options?.view?.is('live') const title = options?.view?.is('live')
? cameraMetadata?.title ?? null ? cameraMetadata?.title ?? null
: options?.view?.isViewerView() : options?.view?.isViewerView()
+3 -3
View File
@@ -1,6 +1,6 @@
@use 'dark.scss'; @import 'dark.scss';
@use 'light.scss'; @import 'light.scss';
@use 'traditional.scss'; @import 'traditional.scss';
:host { :host {
/********* /*********
@@ -241,7 +241,8 @@ describe('StatusBarItemManager', () => {
}); });
}); });
it('should have severity', () => { describe('severity', () => {
it('should have severity in a viewer view', () => {
const manager = new StatusBarItemManager(createCardAPI()); const manager = new StatusBarItemManager(createCardAPI());
const selectedResult = new TestViewMedia({ const selectedResult = new TestViewMedia({
cameraID: 'camera-1', cameraID: 'camera-1',
@@ -255,7 +256,7 @@ describe('StatusBarItemManager', () => {
expect( expect(
manager.calculateItems({ manager.calculateItems({
view: createView({ queryResults: queryResults }), view: createView({ view: 'media', queryResults: queryResults }),
}), }),
).toContainEqual({ ).toContainEqual({
type: 'custom:advanced-camera-card-status-bar-icon' as const, type: 'custom:advanced-camera-card-status-bar-icon' as const,
@@ -263,5 +264,29 @@ describe('StatusBarItemManager', () => {
severity: 'high', severity: 'high',
}); });
}); });
it('should not have severity in live view', () => {
const manager = new StatusBarItemManager(createCardAPI());
const selectedResult = new TestViewMedia({
cameraID: 'camera-1',
});
vi.spyOn(selectedResult, 'getSeverity').mockReturnValue('high');
const queryResults = new QueryResults({
results: [selectedResult],
selectedIndex: 0,
});
expect(
manager.calculateItems({
view: createView({ view: 'live', queryResults: queryResults }),
}),
).not.toContainEqual(
expect.objectContaining({
icon: 'mdi:circle-medium',
}),
);
});
});
}); });
}); });