Merge pull request #53 from dermotduffy/titles-in-viewer

Show event titles in viewer for reference
This commit is contained in:
Dermot Duffy
2021-09-05 14:03:47 -07:00
committed by GitHub
2 changed files with 8 additions and 43 deletions
+8 -38
View File
@@ -7,7 +7,7 @@ import {
html, html,
unsafeCSS, unsafeCSS,
} from 'lit'; } from 'lit';
import { customElement, property, query, state, } from 'lit/decorators'; import { customElement, property, query, state } from 'lit/decorators';
import { classMap } from 'lit/directives/class-map.js'; import { classMap } from 'lit/directives/class-map.js';
import { until } from 'lit/directives/until.js'; import { until } from 'lit/directives/until.js';
@@ -36,7 +36,6 @@ import type {
FrigateCardConfig, FrigateCardConfig,
FrigateCardView, FrigateCardView,
FrigateMenuMode, FrigateMenuMode,
MediaBeingShown,
ResolvedMedia, ResolvedMedia,
} from './types'; } from './types';
import { CARD_VERSION } from './const'; import { CARD_VERSION } from './const';
@@ -141,7 +140,6 @@ export class FrigateCardMenu extends LitElement {
return html` <ha-icon-button return html` <ha-icon-button
class="${classMap(classes)}" class="${classMap(classes)}"
icon=${button.icon || 'mdi:gesture-tap-button'} icon=${button.icon || 'mdi:gesture-tap-button'}
data-toggle="tooltip"
title=${button.description} title=${button.description}
@click=${() => this._callAction(name)} @click=${() => this._callAction(name)}
></ha-icon-button>`; ></ha-icon-button>`;
@@ -273,13 +271,6 @@ export class FrigateCard extends LitElement {
@property({ attribute: false }) @property({ attribute: false })
protected _view: View = new View(); protected _view: View = new View();
// Media (both browse item & resolved media) actually being shown to the user.
// This may be different from _view.target when no particular event is
// requested (e.g. 'clip' view that views the most recent) -- in that case the
// _view.target will be null, but _mediaBeingShown will be the actual event
// shown.
protected _mediaBeingShown: MediaBeingShown | null = null;
// Whether or not there is an active clip being played. // Whether or not there is an active clip being played.
protected _clipPlaying = false; protected _clipPlaying = false;
@@ -409,7 +400,6 @@ export class FrigateCard extends LitElement {
} else { } else {
this._view = view; this._view = view;
} }
this._mediaBeingShown = null;
} }
// Determine whether the card should be updated. // Determine whether the card should be updated.
@@ -602,7 +592,6 @@ export class FrigateCard extends LitElement {
</ha-card> </ha-card>
</div>` </div>`
: html`<img : html`<img
data-toggle="tooltip"
title="${child.title}" title="${child.title}"
class="mdc-image-list__image" class="mdc-image-list__image"
src="${child.thumbnail}" src="${child.thumbnail}"
@@ -652,19 +641,6 @@ export class FrigateCard extends LitElement {
} }
} }
// Extract the Frigate event id from the resolved media. Unfortunately, there
// is no way to attach metadata to BrowseMediaSource so this must suffice.
protected _extractEventIDFromResolvedMedia(
resolvedMedia: ResolvedMedia,
): string | null {
// Example: /api/frigate/frigate/clips/camera-1630123639.21596-l1y9af.jpg?authSig=[large_string]
const result = resolvedMedia.url.match(/-(?<id>[\w]+)\.(jpg|m3u8|mp4)($|\?)/i);
if (result && result.groups) {
return result.groups['id'] || null;
}
return null;
}
protected _extractEventStartTimeFromBrowseMedia( protected _extractEventStartTimeFromBrowseMedia(
browseMedia: BrowseMediaSource, browseMedia: BrowseMediaSource,
): number | null { ): number | null {
@@ -687,16 +663,11 @@ export class FrigateCard extends LitElement {
if (!this.config.frigate_url) { if (!this.config.frigate_url) {
return null; return null;
} }
if (this._mediaBeingShown) { if (this._view.is('live')) {
const eventID = this._extractEventIDFromResolvedMedia(
this._mediaBeingShown.resolvedMedia,
);
if (eventID) {
return `${this.config.frigate_url}/events/${eventID}`;
}
}
return `${this.config.frigate_url}/cameras/${this.config.frigate_camera_name}`; return `${this.config.frigate_url}/cameras/${this.config.frigate_camera_name}`;
} }
return `${this.config.frigate_url}/events?camera=${this.config.frigate_camera_name}`;
}
// From a BrowseMediaSource item extract the first true media item (i.e. a // From a BrowseMediaSource item extract the first true media item (i.e. a
// clip/snapshot, not a folder). // clip/snapshot, not a folder).
@@ -793,11 +764,6 @@ export class FrigateCard extends LitElement {
return this._renderError(localize('error.could_not_resolve')); return this._renderError(localize('error.could_not_resolve'));
} }
this._mediaBeingShown = {
browseMedia: mediaToRender,
resolvedMedia: resolvedMedia,
};
const neighbors = this._getMediaNeighbors(parent, childIndex); const neighbors = this._getMediaNeighbors(parent, childIndex);
return html` return html`
@@ -805,6 +771,7 @@ export class FrigateCard extends LitElement {
? html`<img ? html`<img
src="${neighbors.previous.thumbnail}" src="${neighbors.previous.thumbnail}"
class="frigate-media-controls previous" class="frigate-media-controls previous"
title="${neighbors.previous.title}"
@click=${() => { @click=${() => {
this._view = new View({ this._view = new View({
view: this._view.view, view: this._view.view,
@@ -820,6 +787,7 @@ export class FrigateCard extends LitElement {
.hass=${this._hass} .hass=${this._hass}
.url=${resolvedMedia.url} .url=${resolvedMedia.url}
class="frigate-card-viewer" class="frigate-card-viewer"
title="${mediaToRender.title}"
muted muted
controls controls
playsinline playsinline
@@ -830,6 +798,7 @@ export class FrigateCard extends LitElement {
: html`<img : html`<img
src=${resolvedMedia.url} src=${resolvedMedia.url}
class="frigate-card-viewer" class="frigate-card-viewer"
title="${mediaToRender.title}"
@click=${() => { @click=${() => {
// Get clips potentially related to this snapshot. // Get clips potentially related to this snapshot.
this._findRelatedClips(mediaToRender).then((relatedClip) => { this._findRelatedClips(mediaToRender).then((relatedClip) => {
@@ -849,6 +818,7 @@ export class FrigateCard extends LitElement {
? html`<img ? html`<img
src="${neighbors.next.thumbnail}" src="${neighbors.next.thumbnail}"
class="frigate-media-controls next" class="frigate-media-controls next"
title="${neighbors.next.title}"
@click=${() => { @click=${() => {
this._view = new View({ this._view = new View({
view: this._view.view, view: this._view.view,
-5
View File
@@ -83,11 +83,6 @@ export const frigateCardConfigSchema = z.object({
}); });
export type FrigateCardConfig = z.infer<typeof frigateCardConfigSchema>; export type FrigateCardConfig = z.infer<typeof frigateCardConfigSchema>;
export interface MediaBeingShown {
browseMedia: BrowseMediaSource;
resolvedMedia: ResolvedMedia;
}
export interface MenuButton { export interface MenuButton {
icon?: string; icon?: string;
description: string; description: string;