Merge pull request #1443 from dermotduffy/menu-fix2

Fix menu hide bug causing menu background to stay even when hidden

src/components-lib/menu-controller.ts

@@ -14,7 +14,7 @@ import {
   frigateCardHandleActionConfig,
   getActionConfigGivenAction,
 } from '../utils/action';
-import { arrayify, isTruthy } from '../utils/basic.js';
+import { arrayify, isTruthy, setOrRemoveAttribute } from '../utils/basic.js';
 import { refreshDynamicStateParameters } from '../utils/ha/index.js';
 
 export class MenuController {
@@ -86,7 +86,7 @@ export class MenuController {
 
   public setExpanded(expanded: boolean): void {
     this._expanded = expanded;
-    this._host.setAttribute('expanded', '');
+    setOrRemoveAttribute(this._host, expanded, 'expanded');
     this._host.requestUpdate();
   }
 

tests/components-lib/menu-controller.test.ts

@@ -67,6 +67,22 @@ describe('MenuController', () => {
     expect(host.getAttribute('data-alignment')).toBe('top');
   });
 
+  it('should expand', () => {
+    const host = createLitElement();
+    const controller = new MenuController(host);
+
+    expect(controller.isExpanded()).toBeFalsy();
+    expect(host.getAttribute('expanded')).toBeNull();
+
+    controller.setExpanded(true);
+    expect(controller.isExpanded()).toBeTruthy();
+    expect(host.getAttribute('expanded')).toBe('');
+
+    controller.setExpanded(false);
+    expect(controller.isExpanded()).toBeFalsy();
+    expect(host.getAttribute('expanded')).toBeNull();
+  });
+
   describe('should set and sort buttons', () => {
     it('by priority', () => {
       const controller = new MenuController(createLitElement());