flan/advanced-camera-card
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: media_stop not supported on Google Cast devices (#1605)

Browse Source 
* fix: `media_stop` not supported on Google Cast devices

* Add tests for new stop functionality

---------

Co-authored-by: Dermot Duffy <dermot.duffy@gmail.com>
This commit is contained in:
Felipe Santos
2024-10-02 20:06:08 -07:00
committed by GitHub
co-authored by Dermot Duffy
parent 9098eb3483
commit 1f5d4bd8b0
3 changed files with 108 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/card-controller/media-player-manager.test.ts
+80 -13
View File
@@ -1,7 +1,11 @@
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { mock } from 'vitest-mock-extended';
import { MediaPlayerManager } from '../../src/card-controller/media-player-manager';
import { MEDIA_PLAYER_SUPPORT_BROWSE_MEDIA } from '../../src/const';
import {
MEDIA_PLAYER_SUPPORT_BROWSE_MEDIA,
MEDIA_PLAYER_SUPPORT_STOP,
MEDIA_PLAYER_SUPPORT_TURN_OFF,
} from '../../src/const';
import { ExtendedHomeAssistant } from '../../src/types';
import { EntityRegistryManager } from '../../src/utils/ha/registry/entity';
import {
@@ -179,21 +183,84 @@ describe('MediaPlayerManager', () => {
});
});
it('should stop', async () => {
const api = createCardAPI();
vi.mocked(api.getHASSManager().getHASS).mockReturnValue(createHASS());
describe('should stop', () => {
it('should call media_stop when device supports it', async () => {
const api = createCardAPI();
vi.mocked(api.getHASSManager().getHASS).mockReturnValue(
createHASS({
'media_player.foo': createStateEntity({
entity_id: 'media_player.foo',
attributes: {
supported_features: MEDIA_PLAYER_SUPPORT_STOP,
},
}),
}),
);
const manager = new MediaPlayerManager(api);
const manager = new MediaPlayerManager(api);
await manager.stop('media_player.foo');
await manager.stop('media_player.foo');
expect(api.getHASSManager().getHASS()?.callService).toBeCalledWith(
'media_player',
'media_stop',
{
entity_id: 'media_player.foo',
},
);
expect(api.getHASSManager().getHASS()?.callService).toBeCalledWith(
'media_player',
'media_stop',
{
entity_id: 'media_player.foo',
},
);
});
it('should call turn_off when device does supports it', async () => {
const api = createCardAPI();
vi.mocked(api.getHASSManager().getHASS).mockReturnValue(
createHASS({
'media_player.foo': createStateEntity({
entity_id: 'media_player.foo',
attributes: {
supported_features: MEDIA_PLAYER_SUPPORT_TURN_OFF,
},
}),
}),
);
const manager = new MediaPlayerManager(api);
await manager.stop('media_player.foo');
expect(api.getHASSManager().getHASS()?.callService).toBeCalledWith(
'media_player',
'turn_off',
{
entity_id: 'media_player.foo',
},
);
});
it('should do nothing without some supported feature', async () => {
const api = createCardAPI();
vi.mocked(api.getHASSManager().getHASS).mockReturnValue(
createHASS({
'media_player.foo': createStateEntity({
entity_id: 'media_player.foo',
}),
}),
);
const manager = new MediaPlayerManager(api);
await manager.stop('media_player.foo');
expect(api.getHASSManager().getHASS()?.callService).not.toBeCalled();
});
it('should do nothing without hass state', async () => {
const api = createCardAPI();
vi.mocked(api.getHASSManager().getHASS).mockReturnValue(createHASS());
const manager = new MediaPlayerManager(api);
await manager.stop('media_player.foo');
expect(api.getHASSManager().getHASS()?.callService).not.toBeCalled();
});
});
describe('should play', () => {