fix: Clear the initialized condition state when the card is not usable (#2646)
The `initialized` state (used in conditions/triggers) was written once and never cleared, so it meant "has this card ever been initialized" while everything reading it took it as "is this card usable now". Home Assistant takes a card off the page and puts it back whenever its dashboard tab is left and returned to, so the card initialized again while the state claimed it was initialized throughout: `trigger: initialized` fired once per card rather than once per startup, and automations were dropped in between. The card lifecycle is now an explicit state machine (`SessionManager`), the only writer of `initialized`, which separates a card that is starting up from one initializing part of itself again while it runs. A new `ever` parameter (conditions/triggers) selects the old latched behaviour. `remote_control` uses that parameter to keep its two camera priorities correct under repeated starts. With `camera_priority: entity` the card now re-reads the entity every time it starts, so a camera selected while the card was away is picked up on return. With `camera_priority: card` the card writes the entity on its first start only, unchanged, since repeating that write would overwrite a camera the user had selected. Closes: #2642 BREAKING CHANGE: `condition: initialized` is now `false` whenever the card is not usable, and `trigger: initialized` fires each time the card starts up rather than only the first time. Set `ever: true` on either to keep the previous behaviour.
This commit is contained in:
@@ -890,13 +890,13 @@ describe('config defaults', () => {
|
||||
|
||||
it('should include all conditions', () => {
|
||||
const conditions = [
|
||||
{ condition: 'and', conditions: [{ condition: 'initialized' }] },
|
||||
{ condition: 'and', conditions: [{ condition: 'initialized', ever: false }] },
|
||||
{ condition: 'call', call: ['ringing', 'answered'] },
|
||||
{ condition: 'camera', cameras: ['camera.office'] },
|
||||
{ condition: 'display_mode', display_mode: 'single' },
|
||||
{ condition: 'expand', expand: true },
|
||||
{ condition: 'fullscreen', fullscreen: true },
|
||||
{ condition: 'initialized' },
|
||||
{ condition: 'initialized', ever: false },
|
||||
{ condition: 'interaction', interaction: true },
|
||||
{
|
||||
condition: 'key',
|
||||
@@ -909,14 +909,14 @@ describe('config defaults', () => {
|
||||
},
|
||||
{ condition: 'media_loaded', media_loaded: true },
|
||||
{ condition: 'microphone', muted: true },
|
||||
{ condition: 'not', conditions: [{ condition: 'initialized' }] },
|
||||
{ condition: 'not', conditions: [{ condition: 'initialized', ever: false }] },
|
||||
{
|
||||
condition: 'numeric_state',
|
||||
entity_id: 'sensor.office_temperature',
|
||||
above: 10,
|
||||
below: 20,
|
||||
},
|
||||
{ condition: 'or', conditions: [{ condition: 'initialized' }] },
|
||||
{ condition: 'or', conditions: [{ condition: 'initialized', ever: false }] },
|
||||
{ condition: 'screen', media_query: '(orientation: landscape)' },
|
||||
{
|
||||
condition: 'state',
|
||||
@@ -1934,7 +1934,7 @@ describe('automations should accept Home Assistant input shorthands', () => {
|
||||
},
|
||||
]);
|
||||
|
||||
expect(result[0].triggers).toEqual([{ trigger: 'initialized' }]);
|
||||
expect(result[0].triggers).toEqual([{ trigger: 'initialized', ever: false }]);
|
||||
});
|
||||
|
||||
it('should reject a non-object automation', () => {
|
||||
|
||||
Reference in New Issue
Block a user