fix: Clear the initialized condition state when the card is not usable (#2646)
The `initialized` state (used in conditions/triggers) was written once and never cleared, so it meant "has this card ever been initialized" while everything reading it took it as "is this card usable now". Home Assistant takes a card off the page and puts it back whenever its dashboard tab is left and returned to, so the card initialized again while the state claimed it was initialized throughout: `trigger: initialized` fired once per card rather than once per startup, and automations were dropped in between. The card lifecycle is now an explicit state machine (`SessionManager`), the only writer of `initialized`, which separates a card that is starting up from one initializing part of itself again while it runs. A new `ever` parameter (conditions/triggers) selects the old latched behaviour. `remote_control` uses that parameter to keep its two camera priorities correct under repeated starts. With `camera_priority: entity` the card now re-reads the entity every time it starts, so a camera selected while the card was away is picked up on return. With `camera_priority: card` the card writes the entity on its first start only, unchanged, since repeating that write would overwrite a camera the user had selected. Closes: #2642 BREAKING CHANGE: `condition: initialized` is now `false` whenever the card is not usable, and `trigger: initialized` fires each time the card starts up rather than only the first time. Set `ever: true` on either to keep the previous behaviour.
This commit is contained in:
@@ -96,6 +96,10 @@ describe('setRemoteControlEntityFromConfig', () => {
|
||||
triggers: [
|
||||
{
|
||||
trigger: 'initialized',
|
||||
|
||||
// Writes the entity, so it asserts the card's camera once and does
|
||||
// not repeat on a later initialization.
|
||||
ever: true,
|
||||
},
|
||||
],
|
||||
tag: setRemoteControlEntityFromConfig,
|
||||
@@ -178,6 +182,10 @@ describe('setRemoteControlEntityFromConfig', () => {
|
||||
triggers: [
|
||||
{
|
||||
trigger: 'initialized',
|
||||
|
||||
// Only updates the card, so it repeats on every initialization and
|
||||
// picks up an entity change made while the card could not act.
|
||||
ever: false,
|
||||
},
|
||||
],
|
||||
tag: setRemoteControlEntityFromConfig,
|
||||
@@ -659,9 +667,9 @@ describe('setRemoteControlEntityFromConfig', () => {
|
||||
.calls[0][0];
|
||||
|
||||
vi.mocked(api.getHASSManager().hasHASS).mockReturnValue(true);
|
||||
vi.mocked(api.getInitializationManager().isInitializedMandatory).mockReturnValue(
|
||||
true,
|
||||
);
|
||||
vi.mocked(
|
||||
api.getInitializationManager().areMandatoryAspectsInitialized,
|
||||
).mockReturnValue(true);
|
||||
const stateManager = new ConditionStateManager();
|
||||
vi.mocked(api.getConditionStateManager).mockReturnValue(stateManager);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user