fix: Hold the 2-way audio backchannel open for the shortest possible time (#2697)

The card claimed a camera's ONVIF audio backchannel in two places that
had
nothing to do with a call: the capability probe at camera init
(`&microphone`),
and a pre-armed `sendonly` audio transceiver on every live WebRTC offer.
Merely
looking at a dashboard occupied the camera's speaker line. Outbound
audio now
travels on its own audio-only WebRTC connection, opened when a call is
answered
and closed when it ends.

- The backchannel is claimed only for the duration of a call. Idle
viewing
  claims nothing.
- Two-way audio now works in `mse`, `mp4` and `mjpeg` modes (note: the
outbound
  audio still traverses WebRTC).
- No renegotiation and no video blink at call start or end.
- A call that cannot carry audio now reports it and ends, instead of
showing a
  live microphone that goes nowhere.
- `live.microphone.always_connected` is now purely about the browser
microphone
  permission prompt.
- Call setup measured at 66ms (LAN) and ~260ms (cellular) for ICE and
DTLS, plus
  ~300ms for `go2rtc` to open an RTSP backchannel.

Verified against a live Frigate + `go2rtc` instance, and by unit tests
at 100%
coverage.

 - Closes #2691
 - Closes #2039
 - Closes #2178

Ref #2299 -- the probe no longer opens a backchannel, but it still runs
per
camera on every load and reconnect, and still dials the camera on the
direct-`go2rtc` path. Caching remains to be done.

Ref AlexxIT/go2rtc#1860 -- once a call has opened a backchannel,
`go2rtc` keeps
that media set up on the camera's RTSP session for the life of the
producer.

Diagnoses #2678
This commit is contained in:
Dermot Duffy authored and GitHub committed 2026-08-21 20:13:58 -07:00
1 parent 2d7c86c93c
commit 11cc543406
65 files changed
+2251 -1045

No files matched your search

+1 -1
View File
@@ -1 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" contentStyleType="text/css" data-diagram-type="SEQUENCE" height="1183px" preserveAspectRatio="none" style="width:899px;height:1183px;background:#FFFFFF;" version="1.1" viewBox="0 0 899 1183" width="899px" zoomAndPan="magnify"><?plantuml 1.2026.3?><defs/><g><rect fill="none" height="110.5313" style="stroke:#000000;stroke-width:1.5;" width="838.5503" x="32" y="98.2969"/><rect fill="none" height="235" style="stroke:#000000;stroke-width:1.5;" width="734.6846" x="32" y="222.8281"/><rect fill="none" height="110.5313" style="stroke:#000000;stroke-width:1.5;" width="828.7109" x="32" y="471.8281"/><rect fill="none" height="75.3984" style="stroke:#000000;stroke-width:1.5;" width="734.6846" x="32" y="820.5547"/><g class="participant-lifeline" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-lifeline"><g><title>User</title><rect fill="#000000" fill-opacity="0.00000" height="1019.5859" width="8" x="56.9551" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="60" x2="60" y1="81.2969" y2="1100.8828"/></g></g><g class="participant-lifeline" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-lifeline"><g><title>Call</title><rect fill="#000000" fill-opacity="0.00000" height="1019.5859" width="8" x="342.8721" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="346.8052" x2="346.8052" y1="81.2969" y2="1100.8828"/></g></g><g class="participant-lifeline" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-lifeline"><g><title>Microphone</title><rect fill="#000000" fill-opacity="0.00000" height="1019.5859" width="8" x="647.667" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="650.7676" x2="650.7676" y1="81.2969" y2="1100.8828"/></g></g><g class="participant-lifeline" data-entity-uid="part4" data-qualified-name="Guest" data-source-line="6" id="part4-lifeline"><g><title>Guest</title><rect fill="#000000" fill-opacity="0.00000" height="1019.5859" width="8" x="729.1255" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="732.5664" x2="732.5664" y1="81.2969" y2="1100.8828"/></g></g><g class="participant participant-head" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-head"><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="31.9102" x="42" y="77.9951">User</text><ellipse cx="60.9551" cy="13.5" fill="#E2E2F0" rx="8" ry="8" style="stroke:#181818;stroke-width:0.5;"/><path d="M60.9551,21.5 L60.9551,48.5 M47.9551,29.5 L73.9551,29.5 M60.9551,48.5 L47.9551,63.5 M60.9551,48.5 L73.9551,63.5" fill="none" style="stroke:#181818;stroke-width:0.5;"/></g><g class="participant participant-tail" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-tail"><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="31.9102" x="42" y="1112.8779">User</text><ellipse cx="60.9551" cy="1124.6797" fill="#E2E2F0" rx="8" ry="8" style="stroke:#181818;stroke-width:0.5;"/><path d="M60.9551,1132.6797 L60.9551,1159.6797 M47.9551,1140.6797 L73.9551,1140.6797 M60.9551,1159.6797 L47.9551,1174.6797 M60.9551,1159.6797 L73.9551,1174.6797" fill="none" style="stroke:#181818;stroke-width:0.5;"/></g><g class="participant participant-head" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-head"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="40.1338" x="326.8052" y="50"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="26.1338" x="333.8052" y="69.9951">Call</text></g><g class="participant participant-tail" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-tail"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="40.1338" x="326.8052" y="1099.8828"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="26.1338" x="333.8052" y="1119.8779">Call</text></g><g class="participant participant-head" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-head"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="95.7988" x="603.7676" y="50"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="81.7988" x="610.7676" y="69.9951">Microphone</text></g><g class="participant participant-tail" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-tail"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="95.7988" x="603.7676" y="1099.8828"/><text fill="#000000" font-family="sans-serif" font-size="14Line truncated
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" contentStyleType="text/css" data-diagram-type="SEQUENCE" height="1283px" preserveAspectRatio="none" style="width:899px;height:1283px;background:#FFFFFF;" version="1.1" viewBox="0 0 899 1283" width="899px" zoomAndPan="magnify"><?plantuml 1.2026.3?><defs/><g><rect fill="none" height="110.5313" style="stroke:#000000;stroke-width:1.5;" width="838.5503" x="32" y="98.2969"/><rect fill="none" height="235" style="stroke:#000000;stroke-width:1.5;" width="734.6846" x="32" y="222.8281"/><rect fill="none" height="110.5313" style="stroke:#000000;stroke-width:1.5;" width="828.7109" x="32" y="471.8281"/><rect fill="none" height="75.3984" style="stroke:#000000;stroke-width:1.5;" width="734.6846" x="32" y="885.9531"/><g class="participant-lifeline" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-lifeline"><g><title>User</title><rect fill="#000000" fill-opacity="0.00000" height="1120.1172" width="8" x="56.9551" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="60" x2="60" y1="81.2969" y2="1201.4141"/></g></g><g class="participant-lifeline" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-lifeline"><g><title>Call</title><rect fill="#000000" fill-opacity="0.00000" height="1120.1172" width="8" x="342.8721" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="346.8052" x2="346.8052" y1="81.2969" y2="1201.4141"/></g></g><g class="participant-lifeline" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-lifeline"><g><title>Microphone</title><rect fill="#000000" fill-opacity="0.00000" height="1120.1172" width="8" x="647.667" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="650.7676" x2="650.7676" y1="81.2969" y2="1201.4141"/></g></g><g class="participant-lifeline" data-entity-uid="part4" data-qualified-name="Guest" data-source-line="6" id="part4-lifeline"><g><title>Guest</title><rect fill="#000000" fill-opacity="0.00000" height="1120.1172" width="8" x="729.1255" y="81.2969"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5,5;" x1="732.5664" x2="732.5664" y1="81.2969" y2="1201.4141"/></g></g><g class="participant participant-head" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-head"><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="31.9102" x="42" y="77.9951">User</text><ellipse cx="60.9551" cy="13.5" fill="#E2E2F0" rx="8" ry="8" style="stroke:#181818;stroke-width:0.5;"/><path d="M60.9551,21.5 L60.9551,48.5 M47.9551,29.5 L73.9551,29.5 M60.9551,48.5 L47.9551,63.5 M60.9551,48.5 L73.9551,63.5" fill="none" style="stroke:#181818;stroke-width:0.5;"/></g><g class="participant participant-tail" data-entity-uid="part1" data-qualified-name="User" data-source-line="3" id="part1-tail"><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="31.9102" x="42" y="1213.4092">User</text><ellipse cx="60.9551" cy="1225.2109" fill="#E2E2F0" rx="8" ry="8" style="stroke:#181818;stroke-width:0.5;"/><path d="M60.9551,1233.2109 L60.9551,1260.2109 M47.9551,1241.2109 L73.9551,1241.2109 M60.9551,1260.2109 L47.9551,1275.2109 M60.9551,1260.2109 L73.9551,1275.2109" fill="none" style="stroke:#181818;stroke-width:0.5;"/></g><g class="participant participant-head" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-head"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="40.1338" x="326.8052" y="50"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="26.1338" x="333.8052" y="69.9951">Call</text></g><g class="participant participant-tail" data-entity-uid="part2" data-qualified-name="Card" data-source-line="4" id="part2-tail"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="40.1338" x="326.8052" y="1200.4141"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="26.1338" x="333.8052" y="1220.4092">Call</text></g><g class="participant participant-head" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-head"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="95.7988" x="603.7676" y="50"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="81.7988" x="610.7676" y="69.9951">Microphone</text></g><g class="participant participant-tail" data-entity-uid="part3" data-qualified-name="Mic" data-source-line="5" id="part3-tail"><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="95.7988" x="603.7676" y="1200.4141"/><text fill="#000000" font-family="sans-serif" font-size="14Line truncated

Before

Width:  |  Height:  |  Size: 27 KiB

After

Width:  |  Height:  |  Size: 28 KiB