refactor: Convert protected methods to private (#2358)

src/components/live/providers/go2rtc/index.ts

@@ -53,11 +53,11 @@ export class AdvancedCameraCardGo2RTC extends LitElement implements MediaPlayer
   public controls = false;
 
   @state()
-  protected _message: Message | null = null;
+  private _message: Message | null = null;
 
-  protected _player?: VideoRTC;
+  private _player?: VideoRTC;
 
-  protected _mediaPlayerController = new VideoMediaPlayerController(
+  private _mediaPlayerController = new VideoMediaPlayerController(
     this,
     () => this._player?.video ?? null,
     () => this.controls,
@@ -81,7 +81,7 @@ export class AdvancedCameraCardGo2RTC extends LitElement implements MediaPlayer
     this.requestUpdate();
   }
 
-  protected _handleError(message: Message, e?: Error): void {
+  private _handleError(message: Message, e?: Error): void {
     if (e) {
       errorToConsole(e as Error);
     }
@@ -94,7 +94,7 @@ export class AdvancedCameraCardGo2RTC extends LitElement implements MediaPlayer
     return;
   }
 
-  protected async _getPlayerSource(): Promise<string | null> {
+  private async _getPlayerSource(): Promise<string | null> {
     const cameraConfig = this.camera?.getConfig();
     const proxyConfig = this.camera?.getProxyConfig();
     if (!this.hass || !cameraConfig) {
@@ -155,7 +155,7 @@ export class AdvancedCameraCardGo2RTC extends LitElement implements MediaPlayer
     return result;
   }
 
-  protected async _createPlayer(): Promise<void> {
+  private async _createPlayer(): Promise<void> {
     const src = await this._getPlayerSource();
     if (!src) {
       return;

src/components/live/providers/ha.ts

@@ -24,7 +24,7 @@ export class AdvancedCameraCardLiveHA extends LitElement implements MediaPlayer
   @property({ attribute: true, type: Boolean })
   public controls = false;
 
-  protected _playerRef: Ref<MediaPlayerElement> = createRef();
+  private _playerRef: Ref<MediaPlayerElement> = createRef();
 
   public async getMediaPlayerController(): Promise<MediaPlayerController | null> {
     await this.updateComplete;

src/components/live/providers/image.ts

@@ -19,7 +19,7 @@ export class AdvancedCameraCardLiveImage extends LitElement implements MediaPlay
   @property({ attribute: false })
   public cameraConfig?: CameraConfig;
 
-  protected _refImage: Ref<MediaPlayerElement> = createRef();
+  private _refImage: Ref<MediaPlayerElement> = createRef();
 
   public async getMediaPlayerController(): Promise<MediaPlayerController | null> {
     await this.updateComplete;

src/components/live/providers/jsmpeg.ts

@@ -39,7 +39,7 @@ const JSMPEG_URL_SIGN_REFRESH_THRESHOLD_SECONDS = 1 * 60 * 60;
 
 @customElement('advanced-camera-card-live-jsmpeg')
 export class AdvancedCameraCardLiveJSMPEG extends LitElement implements MediaPlayer {
-  protected hass?: HomeAssistant;
+  private hass?: HomeAssistant;
 
   @property({ attribute: false })
   public cameraConfig?: CameraConfig;
@@ -51,13 +51,13 @@ export class AdvancedCameraCardLiveJSMPEG extends LitElement implements MediaPla
   public cardWideConfig?: CardWideConfig;
 
   @state()
-  protected _message: Message | null = null;
+  private _message: Message | null = null;
 
-  protected _jsmpegCanvasElement?: HTMLCanvasElement;
-  protected _jsmpegVideoPlayer?: JSMpeg.VideoElement;
-  protected _refreshPlayerTimer = new Timer();
+  private _jsmpegCanvasElement?: HTMLCanvasElement;
+  private _jsmpegVideoPlayer?: JSMpeg.VideoElement;
+  private _refreshPlayerTimer = new Timer();
 
-  protected _mediaPlayerController = new JSMPEGMediaPlayerController(
+  private _mediaPlayerController = new JSMPEGMediaPlayerController(
     this,
     () => this._jsmpegVideoPlayer ?? null,
     () => this._jsmpegCanvasElement ?? null,
@@ -75,7 +75,7 @@ export class AdvancedCameraCardLiveJSMPEG extends LitElement implements MediaPla
     }
   }
 
-  protected async _createJSMPEGPlayer(url: string): Promise<JSMpeg.VideoElement> {
+  private async _createJSMPEGPlayer(url: string): Promise<JSMpeg.VideoElement> {
     this._jsmpegVideoPlayer = await new Promise<JSMpeg.VideoElement>((resolve) => {
       let videoDecoded = false;
       const player = new JSMpeg.VideoElement(
@@ -132,7 +132,7 @@ export class AdvancedCameraCardLiveJSMPEG extends LitElement implements MediaPla
     }
   }
 
-  protected _resetPlayer(): void {
+  private _resetPlayer(): void {
     this._message = null;
     this._refreshPlayerTimer.stop();
     if (this._jsmpegVideoPlayer) {
@@ -164,7 +164,7 @@ export class AdvancedCameraCardLiveJSMPEG extends LitElement implements MediaPla
     super.disconnectedCallback();
   }
 
-  protected async _refreshPlayer(): Promise<void> {
+  private async _refreshPlayer(): Promise<void> {
     if (!this.hass) {
       return;
     }

src/components/live/providers/webrtc-card.ts

@@ -59,11 +59,11 @@ export class AdvancedCameraCardLiveWebRTCCard extends LitElement implements Medi
   public controls = false;
 
   @state()
-  protected _message: Message | null = null;
+  private _message: Message | null = null;
 
-  protected hass?: HomeAssistant;
+  private hass?: HomeAssistant;
 
-  protected _mediaPlayerController = new VideoMediaPlayerController(
+  private _mediaPlayerController = new VideoMediaPlayerController(
     this,
     () => this._getVideo(),
     () => this.controls,
@@ -74,7 +74,7 @@ export class AdvancedCameraCardLiveWebRTCCard extends LitElement implements Medi
   }
 
   // A task to await the load of the WebRTC component.
-  protected _webrtcTask = new Task(this, this._getWebRTCCardElement, () => [1]);
+  private _webrtcTask = new Task(this, this._getWebRTCCardElement, () => [1]);
 
   connectedCallback(): void {
     super.connectedCallback();
@@ -97,7 +97,7 @@ export class AdvancedCameraCardLiveWebRTCCard extends LitElement implements Medi
     }
   }
 
-  protected _getVideoRTC(): VideoRTC | null {
+  private _getVideoRTC(): VideoRTC | null {
     return (this.renderRoot?.querySelector('#webrtc') ?? null) as VideoRTC | null;
   }
 
@@ -105,13 +105,11 @@ export class AdvancedCameraCardLiveWebRTCCard extends LitElement implements Medi
    * Get the underlying video player.
    * @returns The player or `null` if not found.
    */
-  protected _getVideo(): HTMLVideoElement | null {
+  private _getVideo(): HTMLVideoElement | null {
     return this._getVideoRTC()?.video ?? null;
   }
 
-  protected async _getWebRTCCardElement(): Promise<
-    CustomElementConstructor | undefined
-  > {
+  private async _getWebRTCCardElement(): Promise<CustomElementConstructor | undefined> {
     await customElements.whenDefined('webrtc-camera');
     return customElements.get('webrtc-camera');
   }
@@ -119,7 +117,7 @@ export class AdvancedCameraCardLiveWebRTCCard extends LitElement implements Medi
   /**
    * Create the WebRTC element. May throw.
    */
-  protected _createWebRTC(): HTMLElement | null {
+  private _createWebRTC(): HTMLElement | null {
     const webrtcElement = this._webrtcTask.value;
     if (webrtcElement && this.hass && this.cameraConfig) {
       const webrtc = new webrtcElement() as HTMLElement & {