refactor: Convert protected methods to private (#2358)

This commit is contained in:
Dermot Duffy
2026-02-19 20:47:59 -08:00
committed by GitHub
parent 529500ed94
commit 0a67df9a25
122 changed files with 815 additions and 829 deletions
@@ -4,8 +4,8 @@ import { FullscreenProviderFactory } from './factory';
import { FullscreenProvider } from './types';
export class FullscreenManager {
protected _api: CardFullscreenAPI;
protected _provider: FullscreenProvider | null;
private _api: CardFullscreenAPI;
private _provider: FullscreenProvider | null;
constructor(api: CardFullscreenAPI, provider?: FullscreenProvider) {
this._api = api;
@@ -48,7 +48,7 @@ export class FullscreenManager {
}
}
protected _fullscreenHandler = (): void => {
private _fullscreenHandler = (): void => {
this._api.getExpandManager().setExpanded(false);
this._setConditionState();
@@ -59,7 +59,7 @@ export class FullscreenManager {
this._api.getCardElementManager().update();
};
protected _setConditionState(): void {
private _setConditionState(): void {
this._api.getConditionStateManager()?.setState({
fullscreen: this.isInFullscreen(),
});
@@ -15,7 +15,7 @@ export class WebkitFullScreenProvider
extends FullscreenProviderBase
implements FullscreenProvider
{
protected _playTimer = new Timer();
private _playTimer = new Timer();
public connect(): void {
this._api.getConditionStateManager().addListener(this._stateChangeHandler);
@@ -25,7 +25,7 @@ export class WebkitFullScreenProvider
this._api.getConditionStateManager().removeListener(this._stateChangeHandler);
}
protected _stateChangeHandler = (change: ConditionStateChange): void => {
private _stateChangeHandler = (change: ConditionStateChange): void => {
if (
change.old.mediaLoadedInfo?.mediaPlayerController?.getFullscreenElement() !==
change.new.mediaLoadedInfo?.mediaPlayerController?.getFullscreenElement()
@@ -42,7 +42,7 @@ export class WebkitFullScreenProvider
}
};
protected _getVideoElement():
private _getVideoElement():
| (HTMLVideoElement & Partial<WebkitHTMLVideoElement>)
| null {
const element = this._api
@@ -74,7 +74,7 @@ export class WebkitFullScreenProvider
}
}
protected _endHandler = (): void => {
private _endHandler = (): void => {
this._handler();
// Webkit on iPhone stops the video when exiting fullscreen (why!). This