flan/advanced-camera-card
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix TODO items.

Browse Source
This commit is contained in:
Dermot Duffy
2023-01-24 19:36:54 -08:00
parent f073f06789
commit 09c38d96f6
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/camera/frigate/engine-frigate.ts
+1 -1
View File
@@ -83,7 +83,7 @@ export class FrigateCameraManagerEngine implements CameraManagerEngine {
protected _throttledSegmentGarbageCollector = throttle( protected _throttledSegmentGarbageCollector = throttle(
this._garbageCollectSegments.bind(this), this._garbageCollectSegments.bind(this),
60 * 60 * 1000, 60 * 60 * 1000,
{ trailing: true }, { leading: false, trailing: true },
); );
constructor(recordingSegmentsCache: RecordingSegmentsCache) { constructor(recordingSegmentsCache: RecordingSegmentsCache) {
src/view/view.ts
+2 -2
View File
@@ -1,12 +1,12 @@
// Medium: // Medium:
// - TODO: Move frigate specific view-media under the camera manager.
// - TODO: ts-prune https://camchenry.com/blog/deleting-dead-code-in-typescript // - TODO: ts-prune https://camchenry.com/blog/deleting-dead-code-in-typescript
// - TODO: Use sortedUniqBy in the engine sort/uniq combo. // - TODO: getRecordingTitle should use getCameraTitle but need hass.
// Hard: // Hard:
// - TODO: Implement dragging the timeline seeking forward in both Frigate recordings & events. // - TODO: Implement dragging the timeline seeking forward in both Frigate recordings & events.
// - TODO: Implement gallery. // - TODO: Implement gallery.
// - TODO: Remove FrigateBrowseMediaSource if not necessary (post-gallery). // - TODO: Remove FrigateBrowseMediaSource if not necessary (post-gallery).
// - TODO: Remove browse-media.ts TODOs.
// - TODO: In generateMediaViewerContext there is an assumption that recordings start/end on the hour, which is true for Frigate but that assumption should be in the engine. // - TODO: In generateMediaViewerContext there is an assumption that recordings start/end on the hour, which is true for Frigate but that assumption should be in the engine.
// - TODO: What should the timeline do when an event is clicked on that is not in the queryResults (or if queryResults is empty)? // - TODO: What should the timeline do when an event is clicked on that is not in the queryResults (or if queryResults is empty)?
// - TODO: Should the timeline data source clear events (as it currently does) when the query changes? // - TODO: Should the timeline data source clear events (as it currently does) when the query changes?